From 4d6c37440b1d80cff6caa599a8bcca4c195ebef7 Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 7 Mar 2024 18:22:48 +0100 Subject: [PATCH] Simplify getBridgeNode() Use simple returns instead of overwriting a local variable. Change-Id: I886590ddcfc5b15c69a6f63953eaffdce5348dc8 Signed-off-by: Robert Varga --- .../southbound/ovsdb/transact/BridgeOperationalState.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/BridgeOperationalState.java b/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/BridgeOperationalState.java index 2c3703006..c04d4a2fb 100644 --- a/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/BridgeOperationalState.java +++ b/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/BridgeOperationalState.java @@ -42,13 +42,12 @@ public class BridgeOperationalState { @SuppressWarnings("IllegalCatch") public Optional getBridgeNode(InstanceIdentifier iid) { InstanceIdentifier nodeIid = iid.firstIdentifierOf(Node.class); - Optional bridgeNode = Optional.empty(); try (ReadTransaction transaction = db.newReadOnlyTransaction()) { - bridgeNode = SouthboundUtil.readNode(transaction, nodeIid); + return SouthboundUtil.readNode(transaction, nodeIid); } catch (Exception exp) { LOG.error("Error in getting the brideNode for {}", iid, exp); + return Optional.empty(); } - return bridgeNode; } public Optional getOvsdbBridgeAugmentation(InstanceIdentifier iid) { -- 2.36.6