From e6e603a9fac4c40e09d71ae7db5d0d777fdb38ff Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Tue, 25 Oct 2016 20:06:45 +0200 Subject: [PATCH] Remove an unneeded branch Instead of maintaining a boolean in an else branch, examine the resulting collection to see if there is anything left. Simplifies and speeds up the code. Change-Id: Ie87c5f845b866e6637a6af0e43cb2153d8e05363 Signed-off-by: Robert Varga --- .../yangtools/yang/parser/stmt/reactor/ModifierImpl.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ModifierImpl.java b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ModifierImpl.java index 154b325dd5..3e1cb3f44f 100644 --- a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ModifierImpl.java +++ b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/reactor/ModifierImpl.java @@ -68,19 +68,16 @@ class ModifierImpl implements ModelActionBuilder { } private boolean removeSatisfied() { - Iterator> it = unsatisfied.iterator(); - boolean allSatisfied = true; + final Iterator> it = unsatisfied.iterator(); while (it.hasNext()) { final AbstractPrerequisite prereq = it.next(); if (prereq.isDone()) { // We are removing current prerequisite from list. LOG.trace("Modifier {} prerequisite {} satisfied", this, prereq); it.remove(); - } else { - allSatisfied = false; } } - return allSatisfied; + return unsatisfied.isEmpty(); } ModelProcessingPhase getPhase() { -- 2.36.6