From 2c7cd23bbfdaff482f8c08c81fdbe076436a6b6b Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Thu, 4 Apr 2024 06:50:56 +0200 Subject: [PATCH] Reduce BGPDocumentedException noise BGPDocumentedException logs itself from one specific constructor. This leads to duplication, as we the exception may end up being recovered from. Change-Id: If9c557c2ab5053dd1c959a0e0db8123b775c4e9b Signed-off-by: Robert Varga --- .../protocol/bgp/parser/BGPDocumentedException.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPDocumentedException.java b/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPDocumentedException.java index bf22b237b2..102af864d3 100644 --- a/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPDocumentedException.java +++ b/bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPDocumentedException.java @@ -10,8 +10,6 @@ package org.opendaylight.protocol.bgp.parser; import com.google.common.base.Preconditions; import com.google.common.primitives.UnsignedBytes; import org.opendaylight.protocol.util.Values; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; /** * There are several errors documented in RFC4271 or in draft, that have specific meaning for the BGP. @@ -19,7 +17,6 @@ import org.slf4j.LoggerFactory; */ public final class BGPDocumentedException extends AbstractBGPException { private static final long serialVersionUID = -6212702584439430736L; - private static final Logger LOG = LoggerFactory.getLogger(BGPDocumentedException.class); /** * Used when an error occurred that is described in an RFC or a draft. @@ -73,8 +70,6 @@ public final class BGPDocumentedException extends AbstractBGPException { public BGPDocumentedException(final String message, final BGPError error, final byte[] data, final Exception cause) { super(message, error, data, cause); - // FIXME: remove this error? - LOG.error("Error = {}", error, this); } /** -- 2.36.6