From f98198bfa8ec780cc8197213720cdca13995f4be Mon Sep 17 00:00:00 2001 From: Robert Varga Date: Fri, 3 May 2024 23:27:27 +0200 Subject: [PATCH] Do not access payload data when not needed We are just putting out a debug, make sure to make this operation conditional. Change-Id: I79c39aab6bb6c94efa03e5a878ceabdb552d93cd Signed-off-by: Robert Varga --- .../SimpleReplicatedLogEntrySerializer.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/persisted/SimpleReplicatedLogEntrySerializer.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/persisted/SimpleReplicatedLogEntrySerializer.java index 250551a780..b0e3c65e56 100644 --- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/persisted/SimpleReplicatedLogEntrySerializer.java +++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/persisted/SimpleReplicatedLogEntrySerializer.java @@ -51,12 +51,15 @@ public class SimpleReplicatedLogEntrySerializer extends JSerializer { final int estimatedSerializedSize = replicatedLogEntry.serializedSize(); - final ByteArrayOutputStream bos = new ByteArrayOutputStream(estimatedSerializedSize); - SerializationUtils.serialize(replicatedLogEntry, bos); - final byte[] bytes = bos.toByteArray(); + final var baos = new ByteArrayOutputStream(estimatedSerializedSize); + SerializationUtils.serialize(replicatedLogEntry, baos); + final byte[] bytes = baos.toByteArray(); - LOG.debug("Estimated serialized size {}, data size {} for payload: {}. Actual serialized size: {}", - estimatedSerializedSize, replicatedLogEntry.getData().size(), replicatedLogEntry.getData(), bytes.length); + if (LOG.isDebugEnabled()) { + final var data = replicatedLogEntry.getData(); + LOG.debug("Estimated serialized size {}, data size {} for payload: {}. Actual serialized size: {}", + estimatedSerializedSize, data.size(), data, bytes.length); + } return bytes; } -- 2.36.6