git.opendaylight Code Review - bgpcep.git/commit

author	Robert Varga <rovarga@cisco.com>
	Fri, 23 Aug 2013 13:55:03 +0000 (15:55 +0200)
committer	Robert Varga <rovarga@cisco.com>
	Fri, 6 Sep 2013 09:05:19 +0000 (11:05 +0200)
commit	a01e8a8629311b3480b2085aca40feea539f4ba0
tree	2c235778a91da616c384a648f77eca5356c25d27	tree \| snapshot
parent	16688ea6965356c21a863c6f7e76ce9c50910eec	commit \| diff

BUG-58: refactor to take advantage of netty

This patchset reworks the framework to take advantage of features in
netty, shortcutting many of the previous concepts. This lead to a major
refactor, reorganizing the way things are glued together.

SessionProposal/Checkers have been removed in favor of an explicit
negotiation piece, which is put on the channel pipeline to negotiate
session parameters -- uopn success it replaces itself with a complete
session.

ProtocolSessionInboundHandler has been integrated into
AbstractProtocolSession, handling the tasks normally.

Finally, Dispatcher uses all this restructure to implement Session
reconnect in a relatively straightforward manner.

Change-Id: I84a6b4c99282212505e6d91ab40da9867ca95e53
Signed-off-by: Robert Varga <rovarga@cisco.com>

132 files changed:

bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSession.java		diff \| blob \| history
bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPSessionListener.java		diff \| blob \| history
bgp/parser-api/src/main/java/org/opendaylight/protocol/bgp/parser/BGPTerminationReason.java	[new file with mode: 0644]	blob
bgp/parser-impl/src/main/java/org/opendaylight/protocol/bgp/parser/impl/BGPMessageFactory.java		diff \| blob \| history
bgp/parser-impl/src/test/java/org/opendaylight/protocol/bgp/parser/impl/BGPParserTest.java		diff \| blob \| history
bgp/parser-mock/src/main/java/org/opendaylight/protocol/bgp/parser/mock/BGPMessageParserMock.java		diff \| blob \| history
bgp/parser-mock/src/test/java/org/opendaylight/protocol/bgp/parser/mock/BGPMessageParserMockTest.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPConnectionImpl.java	[deleted file]	blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPDispatcherImpl.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPImpl.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPSessionFactory.java	[deleted file]	blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPSessionImpl.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPSessionNegotiator.java	[new file with mode: 0644]	blob
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPSessionNegotiatorFactory.java	[new file with mode: 0644]	blob
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPSessionProposalCheckerImpl.java	[deleted file]	blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPSessionProposalImpl.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPSynchronization.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/spi/BGPConnection.java	[deleted file]	blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/spi/BGPConnectionFactory.java	[deleted file]	blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/spi/BGPDispatcher.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/spi/BGPSessionPreferences.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/spi/BGPSessionProposal.java		diff \| blob \| history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/spi/BGPSessionProposalChecker.java	[deleted file]	blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/ApiTest.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/BGPImplTest.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/FSMTest.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/MockDispatcher.java	[deleted file]	blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/ParserTest.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/SimpleSessionListener.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/SpeakerSessionListener.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/SpeakerSessionMock.java		diff \| blob \| history
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/SynchronizationTest.java		diff \| blob \| history
bgp/rib-mock/src/main/java/org/opendaylight/protocol/bgp/rib/mock/BGPMock.java		diff \| blob \| history
bgp/rib-mock/src/main/java/org/opendaylight/protocol/bgp/rib/mock/EventBusRegistration.java		diff \| blob \| history
bgp/rib-mock/src/test/java/org/opendaylight/protocol/bgp/rib/mock/BGPListenerMock.java		diff \| blob \| history
bgp/testtool/src/main/java/org/opendaylight/protocol/bgp/testtool/Main.java		diff \| blob \| history
bgp/testtool/src/main/java/org/opendaylight/protocol/bgp/testtool/TestingListener.java		diff \| blob \| history
bgp/testtool/src/test/java/org/opendaylight/protocol/bgp/testtool/BGPSpeakerMock.java		diff \| blob \| history
bgp/testtool/src/test/java/org/opendaylight/protocol/bgp/testtool/SpeakerSessionListener.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/AbstractProtocolSession.java	[new file with mode: 0644]	blob
framework/src/main/java/org/opendaylight/protocol/framework/AbstractSessionNegotiator.java	[new file with mode: 0644]	blob
framework/src/main/java/org/opendaylight/protocol/framework/ChannelInitializerImpl.java	[new file with mode: 0644]	blob
framework/src/main/java/org/opendaylight/protocol/framework/Dispatcher.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/DispatcherImpl.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/NeverReconnectStrategy.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolConnection.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolConnectionFactory.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolHandlerFactory.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolMessageDecoder.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolMessageEncoder.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolMessageFactory.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolMessageHeader.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolServer.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSession.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSessionFactory.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSessionInboundHandler.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ProtocolSessionPromise.java	[new file with mode: 0644]	blob
framework/src/main/java/org/opendaylight/protocol/framework/ReconnectImmediatelyStrategy.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ReconnectPromise.java	[new file with mode: 0644]	blob
framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategy.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/ReconnectStrategyFactory.java	[new file with mode: 0644]	blob
framework/src/main/java/org/opendaylight/protocol/framework/SessionListener.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/SessionListenerFactory.java		diff \| blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/SessionNegotiator.java	[new file with mode: 0644]	blob
framework/src/main/java/org/opendaylight/protocol/framework/SessionNegotiatorFactory.java	[new file with mode: 0644]	blob
framework/src/main/java/org/opendaylight/protocol/framework/SessionParent.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/SessionPreferences.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/SessionPreferencesChecker.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/SessionPreferencesCheckerFactory.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/SessionProposal.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/SessionProposalFactory.java	[deleted file]	blob \| history
framework/src/main/java/org/opendaylight/protocol/framework/TimedReconnectStrategy.java		diff \| blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/MessageFactory.java		diff \| blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/ServerTest.java		diff \| blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/Session.java		diff \| blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleMessage.java	[moved from framework/src/test/java/org/opendaylight/protocol/framework/Message.java with 83% similarity]	diff \| blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSession.java		diff \| blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionFactory.java	[deleted file]	blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionListener.java		diff \| blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionListenerFactory.java		diff \| blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionNegotiator.java	[new file with mode: 0644]	blob
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionPreferences.java	[deleted file]	blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionProposal.java	[deleted file]	blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionProposalChecker.java	[deleted file]	blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionProposalCheckerFactory.java	[deleted file]	blob \| history
framework/src/test/java/org/opendaylight/protocol/framework/SimpleSessionProposalFactory.java	[deleted file]	blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPCloseTermination.java		diff \| blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPConnection.java	[deleted file]	blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPConnectionFactory.java	[deleted file]	blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPDispatcher.java		diff \| blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPErrorTermination.java		diff \| blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPSession.java		diff \| blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPSessionListener.java		diff \| blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPSessionListenerFactory.java		diff \| blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPSessionPreferences.java	[deleted file]	blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPSessionProposal.java	[deleted file]	blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPSessionProposalChecker.java	[deleted file]	blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPSessionProposalCheckerFactory.java	[deleted file]	blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPSessionProposalFactory.java		diff \| blob \| history
pcep/api/src/main/java/org/opendaylight/protocol/pcep/PCEPTerminationReason.java	[new file with mode: 0644]	blob
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/AbstractPCEPSessionNegotiator.java	[new file with mode: 0644]	blob
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/AbstractPCEPSessionNegotiatorFactory.java	[new file with mode: 0644]	blob
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/DefaultPCEPSessionNegotiator.java	[new file with mode: 0644]	blob
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/DefaultPCEPSessionNegotiatorFactory.java	[new file with mode: 0644]	blob
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPConnectionImpl.java	[deleted file]	blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPDispatcherImpl.java		diff \| blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPMessageFactory.java		diff \| blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPMessageHeader.java		diff \| blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPMessageType.java	[new file with mode: 0644]	blob
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPMessageValidator.java		diff \| blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionFactoryImpl.java	[deleted file]	blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionImpl.java		diff \| blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionProposalCheckerFactoryImpl.java	[deleted file]	blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionProposalFactoryImpl.java		diff \| blob \| history
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/RawPCEPMessageFactory.java	[new file with mode: 0644]	blob
pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/message/PCEPRawMessage.java		diff \| blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/CompositeTest.java		diff \| blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/FiniteStateMachineTest.java		diff \| blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/MockDispatcher.java	[deleted file]	blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/MockPCE.java		diff \| blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/PCEPValidatorTest.java		diff \| blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/ServerSessionMock.java		diff \| blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/SimpleSessionListener.java		diff \| blob \| history
pcep/impl/src/test/java/org/opendaylight/protocol/pcep/impl/SimpleSessionProposalChecker.java	[deleted file]	blob \| history
pcep/testtool/src/main/java/org/opendaylight/protocol/pcep/testtool/Main.java		diff \| blob \| history
pcep/testtool/src/main/java/org/opendaylight/protocol/pcep/testtool/SessionListenerFactory.java		diff \| blob \| history
pcep/testtool/src/main/java/org/opendaylight/protocol/pcep/testtool/SimpleSessionListener.java		diff \| blob \| history
pcep/testtool/src/main/java/org/opendaylight/protocol/pcep/testtool/TestingSessionListener.java		diff \| blob \| history
pcep/testtool/src/main/java/org/opendaylight/protocol/pcep/testtool/TestingSessionListenerFactory.java		diff \| blob \| history
pcep/testtool/src/test/java/org/opendaylight/protocol/pcep/testtool/PCCMock.java		diff \| blob \| history
pcep/testtool/src/test/java/org/opendaylight/protocol/pcep/testtool/PCEPTestingToolTest.java		diff \| blob \| history

BGP/PCEP protocol library

RSS Atom