BUG-3888 : fix comparing ASnumbers 96/24396/6
authorDana Kutenicsova <dkutenic@cisco.com>
Wed, 22 Jul 2015 12:56:46 +0000 (14:56 +0200)
committerMilos Fabian <milfabia@cisco.com>
Mon, 3 Aug 2015 17:09:56 +0000 (17:09 +0000)
commitd99e924ff10bb7652ef12e7989540b9ffecb2dd3
tree40ad5c7facee3b32d2d32892b7e939d005bee562
parenta06c52b352e2fb70918814d204b31331b60ba52e
BUG-3888 : fix comparing ASnumbers

In order to allow BGP connection, expected remote AS (configured in ODL)
needs to match AS number received in peer Open message. Added expected
remote AS to BGP Session Preferences to allow for this comparison.

Moved validate method from client validator to registry that is used
anytime a peer connects.

This commit is intended to be cherry-picked. Refactoring commit
will be followed up in master branch.

Change-Id: Ie8bfd8b51ee7654b284fe0b0d4ce1db5e365d55b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
15 files changed:
bgp/rib-impl/src/main/java/org/opendaylight/controller/config/yang/bgp/rib/impl/BGPPeerModule.java
bgp/rib-impl/src/main/java/org/opendaylight/controller/config/yang/bgp/rib/impl/StrictBgpPeerRegistryModule.java
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/AbstractBGPSessionNegotiator.java
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPClientSessionNegotiator.java
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPServerSessionNegotiator.java
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPSessionProposalImpl.java
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/StrictBGPPeerRegistry.java
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/spi/BGPPeerRegistry.java
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/spi/BGPSessionPreferences.java
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/ApiTest.java
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/BGPDispatcherImplTest.java
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/FSMTest.java
bgp/rib-impl/src/test/java/org/opendaylight/protocol/bgp/rib/impl/StrictBGPPeerRegistryTest.java
bgp/testtool/src/main/java/org/opendaylight/protocol/bgp/testtool/Main.java
bgp/testtool/src/test/java/org/opendaylight/protocol/bgp/testtool/BGPSpeakerMock.java