Code Review / bgpcep.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 15dd40c) | patch
Refactor AbstractPeer initialization 35/111135/1
authorRobert Varga <robert.varga@pantheon.tech>
Thu, 28 Mar 2024 10:06:59 +0000 (11:06 +0100)
committerRobert Varga <robert.varga@pantheon.tech>
Thu, 28 Mar 2024 10:06:59 +0000 (11:06 +0100)
commit22895faa7e282c28a06ef4f1b95d431697774958
treeeea7c241346a18630790954f38360c81bceafabatree | snapshot
parent15dd40c3fd6dbfac67b9fca232d8c7a7a592f7d0commit | diff
Refactor AbstractPeer initialization

We are running createDomChain() in constructor, which not only triggers
SpotBugs, but also results in bad logging: 'Creating DOM peer chain null'
because peerId is not initialized yet.

Fix this by moving the call to createDomChain() to subclasses.

Change-Id: Id1b6f125c49db46eaff73a0e47eaed9718d90fd5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/AbstractPeer.java diff | blob | history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/ApplicationPeer.java diff | blob | history
bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/BGPPeer.java diff | blob | history
BGP/PCEP protocol library