Reduce noise from BGPSessionImpl

We are including Netty thread trace whenever we terminate because of a
BGPDocumentedException. Improve the logging/reporting smarts here to
exclude DecoderExceptions unless they are requested.

Change-Id: If6f036bae67b16d7796d8616e4fbdb2491171bba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Reduce BGPDocumentedException noise

BGPDocumentedException logs itself from one specific constructor. This
leads to duplication, as we the exception may end up being recovered
from.

Change-Id: If9c557c2ab5053dd1c959a0e0db8123b775c4e9b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve findSingleCapability()

We can use a switch expression, improving readability. Furthermore we
can ditch the use of Optional by passing the empty value around.

Change-Id: I08caba1304b382ec4499c3c000aa51532303d3f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.21.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I7afe2995c6704156452fc071e78dd2790369e45c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Bump upstreams

Adopt:
- controller-9.0.2
- aaa-0.19.3
- netconf-7.0.4

Change-Id: I9bf2b7062b6a11e24afccc9ca79a659e67799120
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor AbstractPeer initialization

We are running createDomChain() in constructor, which not only triggers
SpotBugs, but also results in bad logging: 'Creating DOM peer chain null'
because peerId is not initialized yet.

Fix this by moving the call to createDomChain() to subclasses.

Change-Id: Id1b6f125c49db46eaff73a0e47eaed9718d90fd5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.21.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I60a8b6f327d93b60184a0096a8508c95386a86fa
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Bump netconf to 7.0.3

Pick up latest fixes.

Change-Id: I056cfe31dca04ae6ed08757ad5fc5ad6cedcbb81
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix bmp-mock executable

Shading is failing to include slf4j-api, leading to a startup exception.
Fix that.

Change-Id: Icefb92ef03a7bfe5ca45a31ea9a9d5998e12ba97
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize RPC registration

Do not use ClassToInstanceMap to register RPCs.

Change-Id: I205bc4b51459b771d61580dde8aac7d5da74c451
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.21.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I6659ba6b8b91da9c2ace7aff5f0a26ed4565ce9b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Moderinize algo-impl

Reduce use of deprecated methods and make sure we retain values we
acquire from getters.

While we are here, use local variable type inference.

Change-Id: Ib4b3b945ca0443c2344716d5a10f3ba3bb20c386
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-13.0.11
- infrautils-6.0.6
- yangtools-13.0.2
- mdsal-13.0.1
- controller-9.0.1
- aaa-0.19.2
- netconf-7.0.2

Change-Id: Ia74cc942697ec34ec89804fc8918fb17fc2b825b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add RTD configuration

Our RTD build has been failing for some time, fix it.

Change-Id: Ie0019f104748195bf8b5a50c6435db2c7ba9fbe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.21.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I8d8f1fea35b8e0dee86713ddfdf194e5d928307d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Fix NeighborUtil saturated conversion

Use Uint32.saturatedOf() instead of our home-grown, buggy
implementation.

Change-Id: I4be14a570f3160d59cea0d7dc937a94b5774dc8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a switch expression in NeighborUtil

Use a switch expression to convert enum values, ensuring exhaustive
coverage.

Change-Id: I26669f0da284d54bd6300768977369e11e42553a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netconf to 7.0.1

Pick up fixes from upstream.

Change-Id: Id3b797adde22010b64ff382fdd1429d335e7b282
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.21.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I10fcc401f54aecb54aac489797adc32c1dd583e9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Modernize bgp-rib-spi

Switch to using BuilderFactory instead of deprecated Builders.

Change-Id: I792ef52670934ceec6e87d9b2761b40a4c43de63
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded warning suppression

Methods are in proper order, there is no need to suppress checkstyle.

Change-Id: I9e5e1d4ac0241269f989cd1442a969c9070ededc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize bgp-topology-provider

Migrate users of deprecated MD-SAL APIs.

Change-Id: I4f4529e1b962a95cfeb91948d94161b817760a84
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize bmp-impl

Use new ImmutableNodes and take advantage of getName() method generated
for YANG enumerations.

Change-Id: I9a452d936dd4bfcb9c7cf55249ef1f4cb29883dd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize bgp-evpn

Use data.spi.node.ImmutableNodes instead of deprecated yang-data-impl
classes.

Change-Id: I767049fb50904e4ec42a1a460a88aecb4013d68f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize bgp-rib-impl

Remove references to ClusteredDataTreeChangeListener, as we are using
the correct method already. Also migrate other users of MD-SAL-deprecated
methods.

Change-Id: Ibf2b194550e50676776f61643eeb0e5069161a77
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate bgp-rib-impl use of Builders

Use spi.node.ImmutableNodes instead, reducing the overall dependencies.

Change-Id: I048138e00c175392f3808100e2d0fd3077a7d062
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize bgp-flowspec

Migrate users of deprecated methods.

Change-Id: I76b6444b4e07dc2ecdbbc6eb3b7b8dbfadf10814
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize linkstate parser

Use ImmutableNodes instead of Builders.

Change-Id: I2980add186d346472d0f424403ef16c0f4623685
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch use of EventListener

As noted in upstream changes, the use of EventListener is quite
superfluous. Ditch its use.

Change-Id: I9f3749d3709b653fc51ab1e58f3f8f167d26632f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix a few deprecation warnings

Migrate towards data.spi.node.ImmutableNodes in a few components.

Change-Id: I02b29e4a51acd5f979ba70b939ea1bbae351aa20
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- yangtools-13.0.1
- mdsal-13.0.0
- controller-9.0.0
- aaa-0.19.1
- netconf-7.0.0

Also convert a few classes to simpler constructs than
DataTreeChangeListener, as they typically just need the after-image of a
set of changes.

Change-Id: I23dbc8dcd123beaa57bdbd1256ad73cf7d284207
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a dedicated timer in programming-impl

The global timer is going away. Use a dedicated timer instead.

Change-Id: I78a21dee2905f66ce04af9751a154b7cb7780fb9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor BmpDispatcherUtil

Rather than having a utility class and dealing with epoll/nio
bifurbication, promote BmpDispatcherUtil into a component.

Change-Id: I3e1506967d13e787cb9d9d2e8827646b1d9ba3d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deanonymize BGP threads

Use thread factories to identify boss and worker threads.

Change-Id: Ibfe7bf6b869e94a2e243b11d61ecfba0e5ccc008
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disconnect bgp-rib-impl from global event loop groups

We are dancing around event loop group lifecycle based on epoll
availability. Since the global groups are going away anyway, extract
this complexity into an artifact.

Change-Id: Ifdc5404603c96a939659d13e339a7f83c268c2d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.21.0-SNAPSHOT

This starts the Calcium release iteration.

Change-Id: I3d9d945cdcdf441fffd33bf3a3b368f63cbd5deb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.20.7-SNAPSHOT

This starts the next development iteration.

Change-Id: I2dd96349eab91b9f94a89d804707ea1867a4f60d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Bump upstreams

Adopt:
- odparent-13.0.10
- infrautils-6.0.5
- yangtools-11.0.5
- mdsal-12.0.4
- controller-8.0.4
- aaa-0.18.4
- netconf-6.0.6

Change-Id: Iada1a2c4d0ecfd4fad14430ec450190ffa8305fe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate users of YangInstanceIdentifier.create()

Use of() instead. Also take advantage of the fact getPathArguments() has
been returning a List for quite some time.

Change-Id: Idfa5c98690be7127e8cc176bae9294ebaba365b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate DataTreeCandidateNode methods

We have a few users of deprecated methods, let's migrate them.

Change-Id: Ie57ca80e63ff1efd0d864f87ad5acb48306da16c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate users of NormalizedNode.getIdentifier()

Use NormalizedNode.name() instead.

Change-Id: I3f566b3a24b87234a0c8344a98432be24977d197
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate OSGiTopologyDataChangeCounterDeployer

Use constructor injection on TopologyDataChangeCounterDeployer to
eliminate the need for a separate class.

While we are here, also make sure to shutdown individual counters.

Change-Id: I8485968c1e44c0187ef03367cd998fd5e2301894
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.20.6-SNAPSHOT

This starts the next development iteration.

Change-Id: I44480fd71d4ac3b00ee1820117cfa0e6e8ae0cbc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Bump upstreams

Adopt:
- odlparent-13.0.7
- infrautils-6.0.4
- yangtools-11.0.4
- mdsal-12.0.3
- controller-8.0.3
- aaa-0.18.3
- netconf-6.0.5

Change-Id: I1f8e4083f2c826c82e1455d3396f999b4fb27de4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up dependencies

Propagate JDT annotation dependency, re-enabling dependency enforcement
where applicable.

Change-Id: I56e4e914c59392c553f3c62979f9e47ca15a8280
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RpcService in pcep-tunnel-provider

Migrated usage of RpcService to Rpc<?,?> for pcep-tunnel-provider.

JIRA: BGPCEP-1027
Change-Id: I93f829868681d66382b3d79595dc055720f08a37
Signed-off-by: lubos-cicut <lubos.cicut@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RpcService in programming-impl

Migrated usage of RpcService to Rpc<?,?> for programming-impl.

JIRA: BGPCEP-1027
Change-Id: Id5059bdb656b3f7427f72d6e9fc51c6e691382c3
Signed-off-by: lubos-cicut <lubos.cicut@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RpcService in pcep-server-provider

Migrated usage of RpcService to Rpc<?,?> for pcep-server-provider.

JIRA: BGPCEP-1027
Change-Id: I143557b91d0d8f6a131cd2ec4a34136d5490bbbc
Signed-off-by: lubos-cicut <lubos.cicut@pantheon.tech>

Do not use RpcService in pcep-topology-provider

Migrated usage of RpcService to Rpc<?,?> for pcep-topology-provider.

JIRA: BGPCEP-1027
Change-Id: If7b9733e71e60f34d459165a544e76b0490f9a73
Signed-off-by: lubos-cicut <lubos.cicut@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-jxr-plugin to 3.3.1

** Improvement
    * [JXR-175] - Support Java 14 record as class type in cross reference
    * [JXR-176] - Remove dependency org.apache.commons:commons-lang3

** Dependency upgrade
    * [JXR-177] - Upgrade Plexus Utils to 3.5.0
    * [JXR-178] - Update parent pom to 39
    * [JXR-180] - commons-io to 2.14.0
    * [JXR-181] - Upgrade to Parent 40

Change-Id: I8597db703f83b3f66f0fdce48240ec731274a00f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize concepts

Use local variable type inference and migrate to JUnit5.

Change-Id: If80b8eb6b5c5ae49c248bcf8c4710c96b1cbc51f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RpcService in bgp-rib-impl

Migrated usage of RpcService to Rpc<?,?> for bgp-rib-impl.

JIRA: BGPCEP-1027
Change-Id: Ic0452314f060fdb9146873c5c2fc0912d6a608de
Signed-off-by: lubos-cicut <lubos.cicut@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RpcService in algo-impl

Migrate usage of RpcService to Rpc<?,?> for algo-impl. There is only a
single RPC, so this is simple.

JIRA: BGPCEP-1027
Change-Id: I570a7dd448ff66ffccf81c961d5630df5d6c479c
Signed-off-by: lubos-cicut <lubos.cicut@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RpcService in bgp-benchmark-app

Migrated usage of RpcService to Rpc<?,?> for bgp-benchmark-app.

JIRA: BGPCEP-1027
Change-Id: I9db81fa5ea4bd12f3ab5037e361fbbeeb91520db
Signed-off-by: lubos-cicut <lubos.cicut@pantheon.tech>

Bump versions to 0.20.5-SNAPSHOT

This starts the next development iteration.

Change-Id: I0d7471fb20c20f7621358051b28428aaa33bc8de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Bump upstreams

Adopt:
- yangtools-11.0.2
- mdsal-12.0.2
- controller-8.0.2
- aaa-0.18.2
- netconf-6.0.4

Change-Id: Ic6c4044a5943c134f46390fead508514d3275fc3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.20.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I96630d3a3572aefe1a149ccd97c1fdca520e57ce
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Bump netconf to 6.0.3

Fix a couple of regressions from upstream.

Change-Id: I0e70b6774e4c71b055663201fd0e1d644f960639
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.20.3-SNAPSHOT

This starts the next development iteration.

Change-Id: I621f01d610e8af91152739dca6a8e564ff36a8a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Bump versions to 0.20.2-SNAPSHOT

This starts the next development iteration. Now for real.

Change-Id: I299e32851a0ead89b0a7ba75f81aa9cc26c3be2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odparent-13.0.4
- infrautils-6.0.2
- yangtools-11.0.1
- mdsal-12.0.1
- controller-8.0.1
- aaa-0.18.1
- netconf-6.0.2

Change-Id: I6daeaf690318b135ca5b289d73a1753ec3b6df88
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkstyle

Upgraded checkstyle is finding a few violations, fix them up.

Change-Id: Iaa581a6616d2a46baaf49d960cdf7835192eee76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add sonarcloud badges to README.md

Added coverage, reliability rating, technical debt and more badges.

JIRA: BGPCEP-1026
Change-Id: I27901fbb68259d07631bb414352e47ebdeb8deb6
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>

Bump versions to 0.20.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I85dd2b104ebf0b504c069d22f9e1dece612c558d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Bump netconf to 6.0.1

Pick up the latest release.

Change-Id: I476fce48b6eb24bb35cc4420c52a178c1479698d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add maven central and license badge to README.md

JIRA: BGPCEP-1026
Change-Id: If01526e2d20770dc966e954b34c3ce4fdb15267b
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>

Update contents of README.md

The "directory organization" section is outdated and we are missing
a brief description of the project. Get rid of the outdated information,
add a general description.

JIRA: BGPCEP-1025
Change-Id: Icb6b3de8336938c111cdb3d0a5c18395d921797b
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>

Update syntax of README.md to be markdown

The original syntax is reStructuredText, but we need markdown syntax,
since markdown is the standard for README files.

JIRA: BGPCEP-1025
Change-Id: Ia8901c1be7ec51a718eeab01421f66975bb602c1
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>

Rename README to README.md

The standard is that the README file is markdown.
Modify it accordingly.

JIRA: BGPCEP-1025
Change-Id: I399ec72c96b230d9f9f50050e96c10863361c748
Signed-off-by: Šimon Ukuš <simon.ukus@pantheon.tech>

Bump versions to 0.20.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I42a6c00124e6710182c6b5100eb90e6c7d829bc0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release bgpcep

Do not use ListeningExecutorService

We ignore return from submit() -- hence we can just use execute()
instead. Also drop a FIXME to terminate the ExecutorService, as it seems
to be just hanging.

Change-Id: I395e31bbaab8ad41d56e8a9a89839682af42127a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Ditch ListeningExecutorService

We have Futures.submit() at our disposal, hence we can use plain
Executor/ExecutorService to manage our tasks.

Change-Id: I18c26b52603dc6cca11b8feb42f8ac0c6f62bf14
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use release netconf artifacts

Do not use snapshots, use released versions.

Change-Id: If5b5a4d51e6de116d8c1be2c9b8bfb9f5b5cdba2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use controller released artifacts

Ditch snapshots, use the properly-released version.

Change-Id: Id973fa56452ccd51ab8de5cbb6b5aafb1d5363db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use released mdsal artifacts

Use proper mdsal-12.0.0 release artifacts.

Change-Id: I6906dd764df0a8c8af035cd43e9d8b453a374e17
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jxr-maven-plugin to 3.3.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317527&version=12351480

Change-Id: I74e2534509afe23d4a9e41aa72a35c172cc2c9b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update restconf links in documentation

In order to reflect that bierman restconf is no more available,
fix all documentation files under docs.

JIRA: BGPCEP-1024
Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Change-Id: If843d498506d73813a5efbc1bc2994f24b55caec

Consolidate feature repositories

We should only have features-bgpcep, not a separate repository for each
set of features. This squashes the definition and separates
odl-bgpcep-bgp-benchmark into features-bgpcep-testing.

Change-Id: Icac6cb1a52af016e7631d6c486f84b5a1d2447be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rename features-bgpcep-extras to features-bgpcep-testing

This feature repository includes additionally only data-change-counter,
which is only used in testing. Rename the repository accordingly.

Change-Id: I7a204499c04ca98b12278778f971fdec3515019e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Flatten features/ hierarchy

The hierarchy is needlessly complex, flatten it before we start making
sense of the features themselves.

Change-Id: Ia8b4c4aaf2c71f4e14471294c1ea7a5f7df72889
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Eliminate individual artifacts

We really should have only bgpcep-artifacts, fold individual
directories' artifacts pom.xmls into the main one.

Change-Id: I3f9fffae2438c00bac4af484d16310b868106a64
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams

Adopt:
- odlparent-13.0.3
- infrautils-6.0.1
- yangtools-11.0.0
- mdsal-12.0.0-SNAPSHOT
- controller-8.0.0-SNAPSHOT
- aaa-0.18.0-SNAPSHOT
- netconf-6.0.0-SNAPSHOT

Change-Id: I439e4c3d5f920d324e242d5b9cd2eae564704c4f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove RibSupportUtils

ApplicationPeer is the last holdout of reflection-based transcoding,
convert it to pick up the DOM tablesKey from RIBSupport and remove
RibSupportUtils.

JIRA: BGPCEP-1016
Change-Id: Ie567ecd5ff5189538a2c5a98d1cacfe8e7c83796
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RibSupportUtils in SynchronizationAndExceptionTest

We can just hard-code the expected identifier.

JIRA: BGPCEP-1016
Change-Id: I59880bd2e9404ac54e300ec59846e8744306f93c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RibSupportUtils in PeerTest

Use a plain constant instead of relying on reflection. Also centralize
references to AFI/SAFI QNames.

JIRA: BGPCEP-1016
Change-Id: Ibb4e18ee7f83229386a483a912c0ce49e1ffca0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RibSupportUtils in AdjRibOutListener

RIBSupport provides all the information we need, there is no need to
pass TablesKey in or to transcode it separately.

JIRA: BGPCEP-1016
Change-Id: I82e8bac5dffd238e5365d48bdf7a2a1e056af213
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use RibSupportUtils in AdjRibInWriter

RIBSupport has everything we need, there is no point in using
RibSupportUtils for this task.

JIRA: BGPCEP-1016
Change-Id: If692d5b1d84d7596f8af3c13930f420bed901fd3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use SendReceive.getName()

We are playing dirty tricks here in reversing the enum member class
name. This is completely unnecessary, as getName() is guaranteed to give
us exactly what we need.

Change-Id: I22548fd273a0682afd64865e6251cc895bca9e6f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>