Eradicate mockito-configuration references

Change-Id: I5a36564f8ffaa2380c734329e728edbcd768e053
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unused import

Change-Id: I39f60b1e5db79c08ee361da69327616135aae3d6
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make TopologySessionListener implement AutoCloseable

Change-Id: Idb872ebb103d237fe311a78364aab0e6dd91e9e2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Create model-agnostic AbstractTopologySessionListener

This finishes the refactor for support of multiple stateful models: we
now have an Abstract class which each of the model-specific listeners
need to implement.

Change-Id: I074e8c2a593a5e34a652364daa3e4aa21390e516
Signed-off-by: Robert Varga <rovarga@cisco.com>

Extract TopologySessionListener as an interface

This removes coupling between ServerSessionManager and the interface
that per-model listeners need to implement.

Change-Id: Ibdf6d91b571943edf205e8486d06dba50dbd7c10
Signed-off-by: Robert Varga <rovarga@cisco.com>

Break ServerSessionManager into multiple components

In order to support multiple stateful models, ServerSessionManager has
to be split into common and model-specific parts. This commit separates
the topology-wide logic from per-peer logic.

Change-Id: Ia489570270c3aece2ea260c61d222d70bc140d4b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Dynamically manage nodes implied by links

Change-Id: Ibc0d3603124fb48319613471282ea37739c54d75
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fixed incorrect mocking of bundle context.

Mock of bundle context did not adhere to contract
   ServiceReference<T> getServiceReference(T)
   T getService(ServiceReference<T>)
   which caused class cast exception.

Change-Id: I2500d6f30aa01b68f002e87c19ba6a4d17cb393c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Merge "Created stateful and initiated 02 configuration files and make them default."

Add a trace when we update MD-SAL

Improves logging just a tiny bit so that we know wat are we doing

Change-Id: I7b542b973c544fe12c7fb5bc11744b6430e43374
Signed-off-by: Robert Varga <rovarga@cisco.com>

Created stateful and initiated 02 configuration files and make them default.

Change-Id: I12923a279e5601599c7ccf90a0368b2b9e26d26b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Make sure we record a reused node"

Merge "Renamed pcep parser stateful & initiated extensions."

Renamed pcep parser stateful & initiated extensions.

Change-Id: I83f4ac3054e13905a1831295baae8cd8b2094175
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Make sure we record a reused node

This fixes a bug where we fail to record the base node identifier when
we reuse an already-existing node in MD-SAL.

Change-Id: I33f407810da6ab452a0c12933d3572bfa14a1f53
Signed-off-by: Robert Varga <rovarga@cisco.com>

Finish committing transactions when state resync is done

It turns out we forgot to commit the modification transaction when the
initial resync is done. Also add a few debugs so we know what we push
where.

Change-Id: Ia253bd4a421d88ea4f3ed70a73ba238a931e7a4b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bump version model for yangtools release

Change-Id: I8cea9472c8dc6fba90168fa7e09870fe937614a2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix formatting of ISO system IDs

Change-Id: I4751384774680484c167f8b19a8f513998613c45
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make sure we fail on any unresolved bundles

Change-Id: Icf454acf2fd02b0ab5e8866bb114851d89183870
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Fix removal of linkstate routes"

Merge "Change the type of some leafs to uint32"

Fix removal of linkstate routes

Fixes the following exception seen when processing MP_UNREACH:

java.lang.ClassCastException: org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.linkstate.rev131125.update.path.attributes.mp.unreach.nlri.withdrawn.routes.destination.type.DestinationLinkstateCaseBuilder$DestinationLinkstateCaseImpl cannot be cast to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.linkstate.rev131125.LinkstateDestination
        at org.opendaylight.protocol.bgp.linkstate.LinkstateAdjRIBsIn.removeRoutes(LinkstateAdjRIBsIn.java:214) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.RIBImpl.updateTables(RIBImpl.java:132) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:46) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:32) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:199) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:50) ~[na:na]
        at org.opendaylight.protocol.framework.AbstractProtocolSession.channelRead0(AbstractProtocolSession.java:45) ~[na:na]
        at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) ~[na:na]
        at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) ~[na:na]
        at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) ~[bundlefile:na]
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:100) ~[bundlefile:na]
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:480) ~[bundlefile:na]
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:447) ~[bundlefile:na]
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:341) ~[bundlefile:na]
        at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101) ~[bundlefile:na]
        at java.lang.Thread.run(Thread.java:724) ~[na:1.7.0_25]

Change-Id: I95d9b586ddeacbd7bc39500525e8877def604a4c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Moved stateful07 parser to their own project.

Change-Id: I6bc8ec2bb36f8041ee95d5ff38a8640bdccc4e2d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Change the type of some leafs to uint32

These were four-byte entities, which are specified to be "32-bit
integers" in their specification.

Change-Id: Ibfaa7317e8034645311a6f0dddd53d6809f11f15
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Failure to send message should result in negotiation failure"

Failure to send message should result in negotiation failure

This is evidenced by the session getting stuck after the peer closes the
connection but we try to send the open message. The state would be
recovered by the hold timer, but there's no reason why we should wait
for that.

Change-Id: I7abb4e86ced7e36ed720614243ad1938d69fab3a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Update Linkstate attribute parser"

Update Linkstate attribute parser

This updates the parser to check which NLRI type is being handled and
set attributes accordingly.

Do not trigger deserialization errors when an unexpected TLV is seen in
the attribute, just emit a warning.

Change-Id: I5be1bae5448ae299082023b4fd8f424645236c63
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Make sure attributes are parsed in order of their increasing type"

Enabled temporary commented documentation generation.

Change-Id: Ia08ef470eabeb1b8f7a5561f56ef6d842e74277b
Signed-off-by: Martin Vitez <mvitez@cisco.com>

Make sure attributes are parsed in order of their increasing type

This improvement of API specification allows later attributes to see the
previous ones. This is needed for linkstate, where the Linkstate
Attribute needs to see the Multiprotocol attribute.

Change-Id: I3b05cda27ae5277387881d6f34bf6359cae75a99
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Improve generation of node/link identifiers"

Merge changes Ic58ee772,Id447e440

* changes:
  Add more info about state being processed
  Spell out termination points being created

Improve generation of node/link identifiers

Change-Id: I90580daa4f3a2e34cf51b754a07e7e6950bd5015
Signed-off-by: Robert Varga <rovarga@cisco.com>

Moved stateful02 parsers to its own artefact.

Change-Id: I5dfc1f561c0b21932dcf6d9a4e4d35a5ebd77bb0
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Add more info about state being processed

Change-Id: Ic58ee7726658cb98ca96d6ec4ceeb1fcb09fc4d4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Spell out termination points being created

Change-Id: Id447e4409c9d1aee0b7eb19e3c6cdb295cf7c7a8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bumped to ietf-stateful-02.

Change-Id: I0316e6fbc0d0e2ea86d0d89c53ec1d2a9699149a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Created separated project for stateful07.

Change-Id: I04b6f5c4ff8bebcbd9e3e675de853b53c6486d0f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Rename models to reside in ODL namespace

Change-Id: Ica56ec7c909ea6d99649a85b901f846d71c5ea6a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Created separated project for stateful-02."

Created separated project for stateful-02.

Change-Id: I1914920cd7006d272eaed260d868018a871cf663
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Added routed rpcs to pcep-topology|tunnel-provider

Also added integration(pax-exam) test to test the routing

Change-Id: I385f99ecc0fbb9c3cee0a555c87335f3080e2412
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Bump yangtools to 0.6.0"

Bump yangtools to 0.6.0

Change-Id: I7f0018ad64e49356b6f3dd7ab1d42f6cdcb47f82
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Bumped initiated draft to draft-ietf-pce-pce-initiated-lsp-00."

Bumped initiated draft to draft-ietf-pce-pce-initiated-lsp-00.

Change-Id: I0882741b7e8b5a95479aa687d203409cf8562109
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Add logback into dependency management section

Change-Id: I107aa6dd3fd2e5efc065b37e9c16ec3f473e5608
Signed-off-by: Robert Varga <rovarga@cisco.com>

Switch to controller-provided protocol framework

Change-Id: I378be68986a867477044ef8f35a0f50e410de82f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Switch to yangtools-provided mockito configuration

This depends on https://git.opendaylight.org/gerrit/#/c/4316/ being
merged.

Change-Id: Ibbe90af42acb202a42d2329b6e24ee88dc90c981
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add scm tag in preparation for release

Change-Id: I08ccc6ef9fe636a61f659c2b21ce8e3d1449e014
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Bumped stateful draft to 07."

Fix unimplemented module

Change-Id: I6c8a37361ea2305ec3d085fb231e6f0ca651ffc8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bumped stateful draft to 07.

Change-Id: Ic81ddd5138436c2795a7b94505d1df49cd3c6639
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-221 : created Activator for stateful draft.

Change-Id: Ia10f071da98835c29d0e65bb6b5d2952383916af
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Transform initial config files to xml format

Change-Id: I33401ad6065bdf18ad65ed4c2e22a6d05ca39822
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Update to new version of the artifacts proposed by jenkins-bgpcep-version-changes-2

Change-Id: Ie2fc60b51d84ef76a8d7674a59e4eff85bec5718
Signed-off-by: jenkins-bgpcep <jenkins-bgpcep@opendaylight.org>

Deprecate SSLUtil

SSLUtil has no use in this project and was moved into ints sole user in
the controller project.

Change-Id: I10418fb2abe436c79ab967a911e8e9c5fc33c451
Signed-off-by: Robert Varga <rovarga@cisco.com>

More missing copyright headers

Change-Id: Ide3aa6263b557d9497eac1f9a56db1993caca50d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Rework metadata storage to retain metadata through PCEP session flaps

Change-Id: I38651e6286cbca4280ac342799d3b42fab8d8bcd
Signed-off-by: Robert Varga <rovarga@cisco.com>

Disable example BGP client

Change-Id: I81cddad1b763458af42500b4b94f7c22b52c7cbc
Signed-off-by: Robert Varga <rovarga@cisco.com>

Unify logback version

Also remove OSGi dependency, as it is no longer used

Change-Id: Ied9c19c9b761485607f318704e9a08239bacb704
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use ODL nexus group for release artifacts

Change-Id: Ibe1e7a0d9804723f0a9a6bab72b89b465fa850ba
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add missing copyright headers

Change-Id: I5e98168c13ee87e16d76dfed5a983d8d42ed0ab6
Signed-off-by: Robert Varga <rovarga@cisco.com>

Switch to using System.err.println() for help

Change-Id: Ie7a1b1df9393d03472b7975534dda0f2e39eb3b9
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove System.out and improve the test

Change-Id: I53d13a6f08aab159f3c52a1377852c957bc6011e
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-221 : finished splitting stateful draft.

Change-Id: Iabd77a3bc5c9ab8c3b9add1ed8a247b03c0c16e8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Adjusted area identifier.

Change-Id: I0258a1cc80605b30c29835b428c5cbfd2f1d692c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Added test for ProgrammingServiceImpl

Tested
-scheduling, canceling, executing and cleaning of transactions with or without dependencies
-timeout of instructions in different states with or without dependencies

Change-Id: I2fa5d592c31fe93227c535f2c7deb015aaf4f2e2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>

Merge "Improve debug logging to track prefixes"

Merge "Add an attachment point for metadata and propagate it into topology"

Improve debug logging to track prefixes

Change-Id: Ibdd5cf0e50f096153e7e6cbb745fd7ddb30a3dd5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Changed length of IS-IS Area Identifier from fixed to range."

Merge "Re-activate disabled test"

Changed length of IS-IS Area Identifier from fixed to range.

Change-Id: I626f8e6b6bc36a5a5f3d41355e1dd0ae2a48b7df
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Add an attachment point for metadata and propagate it into topology

Change-Id: I3083ea3e6c427d4168376e8158bba9a60d588fec
Signed-off-by: Robert Varga <rovarga@cisco.com>

Re-activate disabled test

The test was deactivated due to deficiencies in testing framework.

Change-Id: I3846dfbf44219e3ddde45a01094ca16ac1e167fb
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-185 : fixed NPE.

Change-Id: Ic2c2e64628815c61a95226bdcab9b22a2d0b0209
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Fixed BGP configuration.

Change-Id: I3aa3dee36d0233b67c8db05f1a21c7fbf2390f04
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

BUG-185 : implemented Best Path Selection Algorithm.

Change-Id: Iec0f6440e21f12e140606973e15901542092c63e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Merge "Generate WADL files for RESTCONF endpoints"

Merge "Adding support for the git-review command line tool"

Generate WADL files for RESTCONF endpoints

Change-Id: Ia6f21ef49d12db95b6ef6af2553711f2e8c65497
Signed-off-by: Robert Varga <rovarga@cisco.com>

Rename lists such that they follow IETF conventions

reported-lsps -> reported-lsp
various subobjects -> subobject

Change-Id: I08bea6203401a2a05a78af669fe3c6a98636b326
Signed-off-by: Robert Varga <rovarga@cisco.com>

Expose PCEP peer IP address in topology

This patch adjusts the PCEP topology extensions to explicitly expose the
PCC IP address as visible by the PCE. Note that this address may be
subject to NAT and thus may not bear any relationship with the IP
address as seen on the PCC.

Change-Id: I7513a6278fadc023a624367a99df2b9edd4e13ca
Signed-off-by: Robert Varga <rovarga@cisco.com>

Adding support for the git-review command line tool

The OpenStack doc workflow (and entire gerrit workflow) has the
option of using a tool called git-review that automates ChangeID:
creation and management,automates rebasing of local commits
as well as simplifies submiting to gerrit and pulling and
pushing reviews.

Usage of the tool is entirely optional, however it does require
a pointer file named .gitreview in the root of the repository
that is referenced.

I am totally new to this project, if you guys don't want to merge
this then no big deal. However I think this will help with dev's
coming over from OpenStack as it will provide a optional workflow
that is closer to the OpenStack workflow.

It is necessary to run git review -s to append the change-id into
git-hooks the first time you use the tool

Change-Id: I73a912d2b8a6a00166387b97d96f1ec8804e3558
Signed-off-by: Colin McNamara <colin@2cups.com>

BUG-221: Split off stateful draft

Change-Id: I053aedb426efaa8d1a1758064d366166feba300f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove stray comment

Change-Id: I3ea3e909982ce0cf1fa224bfd1d7812b802a9019
Signed-off-by: Robert Varga <rovarga@cisco.com>

Initialize instruction list to empty

Change-Id: I972caaa6e320a6335f329ba75bde997066c7165d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Initialize the list of reported LSPs

Change-Id: I07fad7cc59c3c381c15325bfac783177e6af3e7e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix a few deprecation warnings in framework

Change-Id: I8eacfe7e84b2322d6daf8d0838fcb69ec391a050
Signed-off-by: Robert Varga <rovarga@cisco.com>

Instantiate the local rib with empty tables

Change-Id: Ie949507cf51ae8291f513ca5d2a29c34c8f0cdc0
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Add SimpleBGPExtensionProviderContextModuleTest."

Improve BGP/LS topology export

This improves the topology export in the following ways:
- dynamic hostname is propagated
- OSPF router types for internal, ABR and pseudonode are handled
- IS-IS node types are detected correctly
- OSPF TED information is being filled

Change-Id: Ic437871cd658ab44f9914aa86e2846652811b0e7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Replaced Linkstate attribute tlv codes with static finals."

Replaced Linkstate attribute tlv codes with static finals.

Change-Id: Ia7dd3ed6c172ae1e01109c41ca1164dfc6fa20b1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>

Implement PCE ID union type builder

Change-Id: I7e53b274101feb357dfef67bf3d71148be8f94a8
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-185: include the ability to configure multiple peers

Change-Id: Ia09859bc7b2c9483029df0584a8630d3fb92fd9f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make sure RIB entry is created when the implementation starts

Change-Id: I92174ea6634cd738dec97058fa35316d726c477e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix RIB ID not being set

Change-Id: I3cca8ead10a74206e1fcbeaabf967b8d83e3af55
Signed-off-by: Robert Varga <rovarga@cisco.com>