Release Beryllium-SR1

Change-Id: Ic8c50d4cb976cd18761dd89f1ae9ccab9c29bcc1
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 5457 - BGP-LU update from app peer to exabgp peer: Labels missing

Make sure all labels are added into label entry, not only the last one.

Change-Id: I54a28185a46d7757e729be1384485fb610fd8f52
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 5030: BGP Application Peer beanchmark app

Created benchmark ODL application for performance
testing of BGP application peer.
The application offers two types of RPC operations:
*add-prefix - for injection of IPv4 prefix routes
*delete-prefix - for IPv4 prefix routes removal

Change-Id: Ia3e3e930b01d59e0ab21dcf777801716e6f13769
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-2825: optimize NLRI ipv4/ipv6 prefix parsing

Instead of copying arrays around, use offset-based parsers from
IetfInetUtil.

Change-Id: I2d5f8f799ae61e1d6d247827b9d0d1cee6e8b9ef
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
(cherry picked from commit e7ffadf95911352e64f93d2357dffa1a7ff52741)

BUg-2825: optimize prefixForBytes/prefixForByteBuf

Instead of always performing a copy, copy the array only on size
mismatch.

In prefixForByteBuf, allocate a bytearray which has correct size and
read into it -- the rest of it will be zero-initialized, just as it
should be.

Change-Id: I1e71e98e3efba2d731bb8be2c6cfb8062dec00e2
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
(cherry picked from commit 4d5062600e78c4b8c3c2d0e85d454f72f67b8104)

BUG-2825: use IetfInetUtil to instantiate addresses

Rather than brewing our own strings from bytes, use the utility methods
provided with the model. Also use a single instance for empty prefix.

Change-Id: Idfbfc7f2374b8d0205f1d0e3407e3e347242dbc9
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 2aac576b95150606a0d4258b6b57702579156a5b)

ByteArray: do not instantiate arrays if not needed

Move array instantiation into the block where it is used, skipping it
completely in the case we have properly-sized array.

Change-Id: Ie5027f429830a39bfd2835cc5751cb3d6c27dd1e
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 439698fb6b677d9c3e121a0031499b4c68b59c20)

Do not instantiate byte[] needlessly

Creating a single-byte array is not needed here.

Change-Id: I518419438d6eae6146616fba0725245fc348fee7
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit 51ea1ad17e3fd9b7ffe943cfe5f4e3bd71a892c8)

Bug 5453 - PCEP-SR capability is not send in Open Message

The PCEP-SR has to extend latest stateful Open Message handler,
which has changed since Lithium.

An appraoch of overriding parsers seems to be fragile, think about
something more flexible for Boron release (at leat for
capabilities - Open Message TLVs).

Change-Id: I42795a796e163722cf00066b64b83551051ab28b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit d3f723e81e2878b81d11b5c1d5e1e4aa3c462564)

Bug 5449: Fix ClassCastException in BGP-LU

Fix MPLS label value conversion from BI to BA.

Change-Id: Ief28ce287baac9432d61ab7860701917018c194b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Do not use Lists.newArrayList()

We have diamond notation, which renders this unneeded.

Change-Id: I530718c00020a82f3af20d98b17d7a6e3bb3854f
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
(cherry picked from commit 7cebc7387df2face7a2e0e2ec71f1edd891166da)

Pre-size NLRI lists

We have an input list, hence we know how big the output will be. Use
that to make sure we do not resize the list.

Change-Id: I6b8c9ec771416b98578820fd8b0b0d5104231c19
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
(cherry picked from commit 21b6b6dbcaa74e71ceb39492b76cc3171e5b6de0)

Do not use string concat in precondition

Change-Id: Id25e4baab39ba13ad71748f4835732357fc11104
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
(cherry picked from commit f5b6727ce04f1f3224076ed316ebd19064a84b97)

Bug 5380 - NPE in BGP-LS MPLS-TE LSP serializer

Fix NLRI transformation from BI to BA - cases are
not a part of the BI data representation.

Fix typo in LSP TE NLRI type enumeration encoding -
missing hypen.

Change-Id: I0ee2470bc287b438a3d96189ea524145784ff95c
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 430e082b6a89ea6957fdb3c1b6930f72f702dac1)

Bumping versions by 0.0.1 for next dev cycle

Change-Id: I39e750df8214cb264ddf51f100a60b168efdb575
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Release Beryllium

Change-Id: I025ffdda05e8e89721af44e217a4a018e8ce0acb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-5285: Transaction chain broken

Transaction chain broken when peer is connected after
application peer has been configuted.
Issue is caused when it tries to update app-peer adj-rib-out,
which doesn't exist.

Change-Id: I6c765cc0fb03100bc6564466f93eb65fb72cfe48
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Bug 5265: Failed to deploy multiple instances of BMP monitoring station

Avoid overriding of previously created instance.
Create common parent node using merge operation.

Change-Id: I860be2d8cf44826e2d3c4975276664ef3f852313
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-5266: Perform role change in one step

Two steps role change was done when peer was removed,
after code on LocRibWriter has been reworked for previous
fixes this is not required any more and can be done in
only one step.

Change-Id: I9d885f9b99cffc21f93d18dcf8e953885a44ef38
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5097: Modified CacheDeletedPeers to to be local for each RIB

Modified CacheDeletedPeers to to be local for each RIB

Change-Id: Ie6ec3a74686fbff7f700de97cad919d0f3bc0b9e
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5243: Failed to send message Notify

Don't try to send Notify message if the session
has been closed externally

Change-Id: Idd57bd5bf60e4f758ed0187bd12149854740cd36
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5166: Configuration of iBGP peer failed after previous BGP peers deconfiguration

De/Re-configuration was not treated well in the OpenConfig provider.
The Neighbor comaparator was outputting false-negative results,
because of some default values, which are not in our BGP configuration
interest.
Change Neighbor comparator to compare values realted to our BGP
peer configuration only.

Change-Id: I5e406e23bde8b183decf915e786f0fc29423ec7a
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Use pingpong data broker for BI datastore

This mirrors the use of BA use of pingpong broker.

Change-Id: I4db39f6cd24c9512fbbc1806a49b1318ae15cd55
Signed-off-by: Robert Varga <rovarga@cisco.com>
(cherry picked from commit e26553db70190697773174d2002f79a2fbdf2e29)

BUG-5202: BGP Application Peer configuration failure.

Use ModuleKey from existing BGPApplicationPeer module,
set it to the modified module.

Change-Id: I4feb888f92194c578ca38513b16d24043ba9a15e
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5097: Error trying to update EffectiveRibIn from a removed Peer

When more than one peer are removed at same time, cause a race
condition between remove Peer from DS and update removed routes.
Fix by creating a shared Singleton cache with removed peers between
listeners.

Change-Id: Ic4b2ab8283e07695203f9e4d9ceb245985104766
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5141: Failed to send Update Message on reconfigure Peer

Clean up when reconfigurin Peer as we do when we reconnect peer.
Update Log levels on LocRibWriter for skipped change.
Making Debug logs more clear.

Change-Id: Ifb3fa2a0e4dc4633814ce3620f5ac585d01aa575
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5138: NPE in PcRptMessageCodec

To avoid NPE, process Bandwidth object first, then
all other objects in the list.

Change-Id: I2a09c7d9be1c2ee83bcd3563c854faaefe35ccd4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit fa5f6bf0a6751f5a1d2866e4951951bd21135a73)

BUG-5098: NPE when reconfiguring openconfig

When configuring more than one BGPPeer through Netconf
consecutive withouth give time to reconfiguration
to finish will cause an NPE.
Fix by doin blocking reconfiguration.

Change-Id: I000fe3a146f40713fb918c07442396bd8eaa7598
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5084: BGPOpenConfigListener NPE

Fix by check wheter List<Neighbor> is null.

Change-Id: Ia332df95b52f7b792bdb0a815d696453f33a1a8d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5076: OffSetMap reworked

OffSetMap reworked, removed previously introduced ArrayList

Change-Id: Id429fda477c8a038c1d64ec103b62e625637c1fd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-5055: Initialization of LocRib Table

When LocRib table are created when insert already
existan routes. They where created when inserting
supported tables. Which will make the process to be
repeated if more than one table is supported.
Solved by move the process at the point where
specific table is created.
Also fixed onTable change, since it should add only
table to corresponding LocribWriter listener

Change-Id: I4f87d1bf6e2b24d9ad1911d15ce3923c7538c156
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4689: Advertising performance fix II

When AdjRibOutListener get a notification with too many changes,
it can fill output buffer with wrtitten Update messages,
without a chance to flush a socket, because the AdjRibOutListener
is blocked when channel is not writable - deadlock situation until a
savior (KA message) will not be send.
Flushing with every write operation is uneffective, hence try to call
the "flush" in a situation when the channel become unwritable.

Change-Id: Ie50b9154d1166d55308c3438c12b9c1b9d3ce19f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 095c87da7d565dac2cffa11710e7dd0e4a67c20f)

Bug 5048 - Unable to deploy multiple RIB instances

When creating a new RIB instances do not override
top-level parent node common for all instances.
To make sure the node exists, merge an empty structure
of parent node.

Change-Id: Ide9c9a726e078deca4ec5ad6fd06d4d3868f9706
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit c9bd8c30bc308e44e5252f041927fd7c45a1c55a)

BUG-4835: Routes no withdrawn when the same prefixes annonced.

Routes not withdrawn when eBGP peers are disconnected and
the same prefixes annonced
Fix by shrink OFFSET

Change-Id: I7756c677b34372f5e0c19aefdd14bca74a226d78
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Bug 4921 - Support Bandwidth Usage object

Support Bandwidth-Usage object as defined in
https://tools.ietf.org/html/draft-dhody-pce-stateful-pce-auto-bandwidth-06#section-5.3.2
The object is used in PcRpt message report the real-time
bandwidth usage of a TE LSP.
Make object-type configurable, since no codepoint is assigned by IANA.
By default object-type=5.

Change-Id: I8aacf86cee3f647ad47a0dc01a861b16f89a62c5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 5bd37a2832c88475435300ffe46836cb895309c4)

BUG-4982:  NPE in LocRibWriter when removing a route

Fix by check wheter entry is null.

Change-Id: I4d464e8bdb0ff0e4bbaeeb19f4ad46745b67d367
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 86a47d69e05d776bc4b049600a10c257300ff125)

BUG-2208: PCC-MOCK Stateful Sync Opt

Update pcc-mock to support:
+State Synchronization Avoidance.
+Incremental Synchronization
+PCE Triggered Initial Synchronization
+PCE Triggered Lsp Resynchronization
+PCE Triggered Full DB Resynchronization
Input
--state-sync-avoidance 10 5 5
--incremental-sync-procedure 10 5 5
--triggered-initial-sync
--triggered-re-sync
+DBVersion number after PCC reconnection
+Seconds to wait until disconnect
+Seconds to wait until PCC reconnects

Change-Id: I61f673177a086d969b6f097733351413b71ea8e2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit a829992c535982c390229b86ed86aa02ad5dd4e0)

BUG-2208: BUG-2208: Fix minors triggered resync bugs

Fix isTriggeredInitialSyncEnable
Change isSynchronized by method getSynchronized

Change-Id: Icef303f48fb0b192e4d62494e6462aca34e3eea8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit 6e9a5f7e5d30aea4811f1afa6eaadae8179e739e)

Bug 4836 - tunnel's paths are not removed from ODL after tunnel status "Down" is reported

In a case when PCC reports tunnel has been shutdowned, but not removed
(LSP-ID=0, remove=false), ODL PCE should remove all previously reported
paths related to the tunnel as there are no paths signaled anymore.
Also, in this case PCC will not send report/s with explicit removal
of those paths.

Change-Id: I7b2c34431b094b27ac1fc55c2a75312e00868532
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit 4381024781b5ecda601eee2217c8c10e4d61a6c8)

Bug 4864 - BMP: No RIB table is created for non-MP peer

Initiate IPv4 Unicast RIB tables by default for all peers.
Fixes case when peer is not supporting
multiprotocol capability.

Change-Id: I8b133cfe621e5ab5c46cc41f604b68854bb4d607
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit e7943ece42dfa9b983ebac41566d145cefb88fdb)

Bug 4837 - BMP test tool

The bmp-mock is a standalone java application for puropose of
testing BMP monitoring station, in a way of faking BMP-enabled routers
and their peers. It allows to report mock Route Monitoring messages including
simple BGP routes.

Change-Id: Ibed6d239a933f84a5dfeda8ff18bcf6ddf2b8c3e
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Update .gitreview for stable/beryllium

Change-Id: Ic006d74b5284de85b48b928862e0ed6702d4c2b4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-4714 : No routes from loc-rib are advertised

When new peer connects, already existent routes on EffectiveRibIn
Table are not advertised and stored on corresponding AdjRibOut
Peer table. Therefore AdjRiboutListener doesnt advertise
these routes.
Fix by apply routes, when supported tables are created.

Change-Id: Id263723ee685bbc61468e1ea532f0f57f1c6c6c7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4939: Remove BGP Peer structure from DS once session is close

When session is close remove whole Peer Structure from DS,
and create it again on Session up.

Change-Id: I7796983a98d8378b7fa80c61a9bed55bf46c836f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4962:LocRibWriter shouldn't announce routes to Application Peer

Fix by skip the step when Peer is Internal Role

Change-Id: I8c7932e9cc092d583c3db7b2ee03d38323499b73
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4834: resolve values for new best path state

Change-Id: I44c606aa4998a3e3a898d55e87c2f1978cf596dd
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4867: AdjRibOutListener is one per Table

AdjRibOutListener is one per Table, therefore we need to store all
of them for later close.

Change-Id: Ied60bd9046dc21f03cb6d45418f0348109c66ae5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-2208: Fix wrong order on method calls

Fix wrong order on method calls which caused empty
stateful proposal

Change-Id: I3935e348a707657fb41eaa58f9cc545abd1aeab4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-2208: Add missing return on PCCDispatcherImpl

Change-Id: Ie9ff5d9ce8ab54ed9682ddc9da48eba7d7534cc8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-2208: Cancel PCEPSessionNegotiator Timers on session down

On session goes down PCEPSessionNegotiator Timers need to
be canceled

Change-Id: I82091efb6e8ffcda992f08bc3fdcbf1cf63a1ab5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-2208: leaf triggered-initial-sync should be by default true

leaf triggered-initial-sync should be by default true

Change-Id: If0ccdd658805b8ae35999ceb270641c7d20a604d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Bug 4863 - BMP: PeerUp Notification serializer bugs

-fix NPE for optional Information TLV
-fix Sent/Received Open Message encoding order

Change-Id: I9de38b02b0b105b4828aaa140fa5f5861fa5d56e
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4802: LS-SR enabling multiple SIDs

specifically: AdjSIDs, Peer-Set-SIDs, BindingSIDs

Change-Id: Ic75bcd6cec20ce70d8351a1f7891e3630369ae76
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4867: AdjRibOutListener still listening changes after peer Session closed

Once Peer session is closed. Listener needs to be removed.

Change-Id: Ie3575bdd42e9b0924e48f110652d0c595b42804c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove deprecated Qname.cachedReference method

Remove deprecated Qname.cachedReference method

Change-Id: I401b75a2a583b9fd048dba6ac7698dd84c47f915
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Add a private constructor to hide the implicit public one

Add a private constructor to hide the implicit public one on
OpenConfigComparatorFactory.

Change-Id: Id24e1b3bb8c59e0eaed71093acd4443e75ac50db
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Rename Label package name to match the regular expression

Change-Id: I31996acbcca5b3e247c977a3615f2b4050670488
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Use StandardCharsets.UTF_8

Do not look up the charset, but use a global shared instance.

Change-Id: I43ae1e93c0a13675585e69cf32bbf46d80c1ebfa
Signed-off-by: Robert Varga <robert.varga@pantheon.sk>

BUG-4729: PCEP RP object priority can be set 0

Fix RP object priority parser - if priority is 0,
priority is not present.

Change-Id: I86a9ffb652763524440e9f1599b468bbf27704db
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Bug 4801 - FromExternalImportPolicyTest is failing at JDK7

Enable the test.
The failure was caused by:
https://git.opendaylight.org/gerrit/#/c/31365/
The change was reverted:
https://git.opendaylight.org/gerrit/#/c/31511/

Change-Id: I70b130b15ec57fc696a3af02b9dfc7f8f9e93ae7
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Unit tests for openconfig-impl/moduleconfig

Change-Id: I179021c1214f127151defcc77cd2a6eaec6ab251
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Bug 4781 - BGP at work is not ready for application of 43-bgp-openconfig.xml

Change starting order - first BGP OpenConfig app is stared, then RIBImpl
is started.
The change avoids problem with reconfiguring RIBImpl instance at startup.

Change-Id: I8777bb0175b03bd4450076b6e916fc1d015d1394
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4780: New peers failed to connect after one gets connected

After one peer gets connected, new peer failed to connect.
Cause of the issue was that we were reusing DefaultPromise
from previous connection.
Fix by creating new promise for each connection.
Remove needless EventExecutor variables, use
GlobalEventExecutor.INSTANCE instead.

Change-Id: I2938b9f16087d5b004fdbd43bcf082e26bb8a071
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4740: No reconnect after negotiation failure

Change-Id: I31a152bcfc52f98a9e95a8a75b26d42d2da8a014
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4779: Openconfig mandatory descendant missing

Make sure mandatory leaf is allways present.
Map RIB module configuration on OpenConfig Bgp top level container.

Change-Id: I5f28a5fa2924ec2ddc721c69f0b2a67fdf374f63
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4792: Fix failing single feature tests

Use "odl-netty" feature from odlparent.

Ignore JUnit test FromExternalImportPolicyTest.testEffectiveAttributes
Will be fixed in additional patch.

Change-Id: I7baa260325cbf4fe6d317d71315e091fcf1d7a6b
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4696: BGP OpenConfig bugfixing

-introduce comparators, used when comparing current configuration state
with proposed state

-pass whole configuration (not only identifier) when removing
config module instance

-use MountPointListener instead of DataTreeChangeListener

-refactor implementations

Change-Id: I388dcd6ccb094a82d922740b86f721b5baf23e18
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4730: Update BGP-LS EPE

Update implementation to conform draft-ietf-idr-bgpls-segment-routing-epe-01
which is reflecting changes in latest linkstate segment routing extension draft.
-TLVs redefined with common structure
-changed TLVs codepoints

API (Yang data model) change:
renamed container "peer-sid" -> "peer-node-sid"
added container "peer-adj-sid"

Change-Id: I391862970fd751f54426e7222eb99519a68b4d99
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4689: Advertising performance fix

The TCP channel become unwritable too fast and too often, hence
use high & low write watermark option for channel.

Change-Id: Icd52f164153dde94cd7c61a0c38f805a5c0593cf
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Sonar warning fix: IPv4RIBSupport

attribute name refactor

Change-Id: I89e58a8a1b4120b44085983ccf724f94b0370c27
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Test coverage: rsvp-spi/subobjects

Change-Id: I29400140d6e5cb5846473896a20151e3a57fbdc5
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4705: LS-SR MplsLabel as 20 rightmost bits

Change-Id: Ia8c47d4f9b16785b911025994c5b56cd6e7b78d9
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Refactor classes names

Refactor classes name to have same stetic in capitals
all, like BGP and PCEP.

Change-Id: I58fb5a3524e2628a4b7555621e34b2d1f3c3c362
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Unit Test: BGPOpenConfig

Change-Id: I501cc7c2ecde00e00d68535aa4b05ae1f3bbb52b
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Test coverage: rsvp-spi

Change-Id: I4cdcecd0610c667e3d1f4bbe3e4871b77c869c7f
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Use odlparent jacoco configuration

Change-Id: I2948f02064ad38fa018b7ae05068a65d3a961ae7
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 4646: Fixed up duplicate use of reference statements.

minor fix of invalid yang files

Change-Id: Ic8dbcee91e9be2c78813291dd95239d3ca5895b6
Signed-off-by: Filip.Gregor <fgregor@cisco.com>

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: Icff4d53b0af400ecae86c6099ebba00ec0509c72
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Eradicate use of commons-codec

Guava provides hex-codec, use that instead of commons-codec. Also turn
some methods into statics while we're in the area.

Change-Id: I9e950277995f78bfe6323b11b41ef840e427726a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove antlr4-runtime-osgi-nohead

This bundle was removed from yangtools so no longer exists. See:
https://git.opendaylight.org/gerrit/28272/

Change-Id: I7094edc12c3f12ad6ef8aee0e4c2cfaf98af7263
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-4672: BMP client reconnection not working

-get rid of protocol-framework's reconnect strategy
-introduce simple initial reconnection as suggested in
https://tools.ietf.org/html/draft-ietf-grow-bmp-15#section-3.2
-BMP session should go to "up" state once the connection is established (channel is active),
introduced "IDLE" state of a BMP session
-added commented sample of active client (monired router) configuration

Introduces "IDLE" state of a BMP session,
session goes up once the channel is active.

Change-Id: Ibd78fe708162a710fdcc20c614cc1d9c1be6eb95
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-3919: Support for non-MP advertisement

Add a support for old-school BGP-4 advertising,
if peer do not advertise IPv4-Unicast MP capability.

Revert changes in IPv4RIBSupport class.

Change-Id: I0f3a4c767f4f7048e4867ec3aab6c2b8dac6c008
Signed-off-by: Milos Fabian <milfabia@cisco.com>

BUG-4569: Data-change-counter reconfiguration failure

Data-change-counter reconfiguration fails because of
race condition. Last task which removes model from
DS is not executed before new data-change-counter is
created and insert his own model on DS.
Fix by wait until last task is executed when close module.

Change-Id: Ic9349bf99d6a96fd44babdb874158138d7eaf6e8
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4679: NPE in IPv4 prefix withdrawn Update msg serialization

When building Update message for withdrawing routes, check if
Multi-protocol is supported for this type of route.
If not, pack withdrawing routes as per RFC4271.

Change-Id: Ia9a36add74dd817bf0a460cfeaa5281f9b2fb50a
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Refactor Tunnel-Programming

Refactor Tunnel-programming and create new
TunnelInstrucctionExecutor classes.

Change-Id: I0be6fd4f5a050a9b81f8f7bed01b3eabb848fd25
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove redundant modifier

Change-Id: Ibfc7b03b4e73fd4d329af0b690967ce38772a2c9
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BGPRibImplProvider sonar fix

Change-Id: I9c3101ba41b5cadadbbc1d1fc24b1b19c67296cb
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

OpenConfigUtil sonar fix

Change-Id: I16c4abaca3cd57e492695ae896fb54271b17db93
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

Rev130715Util minor fixes

misspelled Uitl -> Util
added private constructor

Change-Id: I949cceb518cdaa4a66b9b725d5974f09610b15f6
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

SrRangeTlv: inner area parsing/serializing

Inner area should be handled just in case of OSPF protocol.

Change-Id: I8468dfe0aeff6ed6c4ee7945f489b22bf8874075
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>

BUG-4617: BGP Flow-Spec Redirect to IP Action

-adds support for BGP FS Redirect to IP action
-implementation is based on draft-ietf-idr-flowspec-redirect-ip-02
-registered under Ex. comm type/subtype as per
https://tools.ietf.org/html/draft-ietf-idr-flowspec-redirect-ip-00#section-7

Change-Id: If889e1b65d944c71b85e0d27c57af4be7e08af6c
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Move releaseConnection from ReusableBGPPeer to BGPSessionListener

Move releaseConnection from ReusableBGPPeer to BGPSessionListener

Change-Id: Ief296eccc81cc00661462cc9ec861ff4acc379de
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Refactor LinkstateNlriParser

Refactor LinkstateNlriParser to fix Sonar complains

Change-Id: If4f523bc7fe338f370b809df68c952ceef8e403f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Implement changedRoutes Test

Implement changedRoutes Test

Change-Id: I2026338225959325efefd9501248a0fa01cc6335
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove unnecesary dependency

Remove unnecesary yang-ext dependency

Change-Id: I9a0434a756326ebe5d670d346a01b01648cb5c60
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove workaround for bug 1276

Since bug 1276 is fixed, workaround is not required
anymore.

Change-Id: I5939f3ac94ab3b3f865c3c2920e4f491f39f9827
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Refactor Stateful07TopologySessionListener

Refactor Stateful07TopologySessionListener to fix Sonar
complains.

Change-Id: Ib9548697baa6e405cadc1013857388df1379b99b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Create AbstractEROPathKeySubobjectParser

Create AbstractEROPathKeySubobjectParser for PCEP

Change-Id: Ifeb84955f2002d78871705c0e7091ac3df31e894
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-4616: Update Flowspec Redirect Ext. Communities

-implementation of handlers for BGP flowspec
Ipv4 and AS4 Redirect extended communities

ref.: http://tools.ietf.org/html/rfc7674

Change-Id: Ia4da00db3b62633206e643654e64a3faf5b76aa2
Signed-off-by: Milos Fabian <milfabia@cisco.com>

Fix extended community parser key generator

Change-Id: Ie311b0f1a03b1475313f4c657ffa6d9147965ca9
Signed-off-by: Milos Fabian <milfabia@cisco.com>