Release Carbon

BUG-8987: Print Exception when Css registration fails

Change-Id: I34236ac8546358fe3c00985fbbf40f69aa0bef19
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-8942: Fix DelegatedLspsCount

mbean value returns count of all LSPs and not just
the ones that are delegated

- Fixed code to return count of delegated LSPs only
- Added unit-test

Change-Id: I067b4cff8c7503fa878742ab6605fca2685a6c15
Signed-off-by: Ajay Lele <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8156 : conflicting listener fix

In case another session listener is in conflict
with the existing one, close the new listener.

Change-Id: I1a594c3876eb1d28133dcc08b31f38deb5ceb27a
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>

BUG-8156 : fixed start of session manager

Upon restart of session manager, its close flag was never
set to false, causing pcep sessions to be rejected as they
rely on this value.

Change-Id: I676ea5774cea4cbbee84222d2ad562bea70e83f3
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>

BUG-8156 : duplicate session up fixed

In case of session up twice, the second session gets
deleted from pcep and controller.

Change-Id: I192a13e29ccb69bb869a9ed344d6f504d80100af
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>

Enforce no split packages

This patch augments Export-Packages with a directive to fail build
if a split package is detected.

Change-Id: I52a2a157f992cb97fd8c6a88cf45c933ed0fd953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c03293f4b1f5e396235713dc9b148eb32c19ddc9)

BUG-8722: fix regression introduced by BUG-5876

Change I707914f3ab0786c0ad8ba71a5476b3b7e322b0cd regressed
bgp-rib-impl packaging such that it massively over-included
classes, leading to split package.

This patch fixes that regression.

Change-Id: I6366972b88e3881675c3dd70517fc4e95c050261
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e6368af274f1971ef5bf5e68ad4d1a11a8f86eab)

Bug 8667 - PCEP: When peer closes got IO exception

When peer closes the pcep session, it results on IO
Exception.
it is due to this close is not recognized as local pcep
PCEP session termination.
It was first implemented as a local pcep session
termination.
https://git.opendaylight.org/gerrit/#/c/906/1/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionImpl.java
Solution: Use the reason encapsulated in the close message to close the session.

Change-Id: Ia423f5c10b117ef21af5a3bddc28652ebb659e26
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
(cherry picked from commit b8d57a84bd130ff3f98cd08b175bb9da18a6e24e)

BUG-7027 : Remove Data change counter CSS configuration

since is not longer need it. New configuration is
done via REST.

Change-Id: I32c3ffcfa66108d72dd8033e44b1cbd7596537eb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: I4ca0c3db2122263426d90fa678e81dd4d9dd27aa
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Revert "BUG-8156 Terminate PCEP session properly when ServerSessionManager is closed"

This reverts commit 361265e3d13003bc3bfe75c888c40713ecbb36de
which introced a new bug.
bgpcep-csit-1node-periodic-throughpcep-*-carbon not passing

Change-Id: I965b09b36ef46f2a0ba4ea6b4861d66b7d0ddaec
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8156 Terminate PCEP session properly when ServerSessionManager is closed

When the PCEP topology provider is loading the configuration initially,
the ServerSessionManager will be restarted.  Any new PCEP connection
coming in during this period will be rejected by the ServerSessionManager.

This patch is to terminate these rejected PCEP session properly when above
situation happens, so that the session can be established successfully
in the next retry.

Change-Id: Ifa3366c97025a0b31fb7d3ee50b1142f63a6209c
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7027 : wired data-change-counter with Blueprint

Deprecate existing config modules,
add BP xml with custom config yang file.
No default configuration is set, to avoid
conflict modification when using on 3 node clustering.

Change-Id: I2b0408310605c9b96388585582d2e7a9f63007cb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 32edf04044a599bfff9a69abd94af53650c4a5ad)

Code Cleanup: unused var and imports

Remove unused logs, class member and
methods paramenters

Change-Id: I02640d49844d46726da8da9ae162507dc6c6e581
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
(cherry picked from commit f23133e4267aa3a759eca8f03c4c51346418d0a1)

Code cleanup: Duplicate Code

Remove duplicated code

Change-Id: I318e391e95bc892ebcf6af3081a455e84843c93a
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
(cherry picked from commit 54c65cb54ea79c7681d3dee6c0a289bd90f8b5b3)

BUG-8292 Fix BGP flowspec NLRI length read

In BGP Flowspec, NLRI length is set per NLRI. The
current implementation only read NLRI once. So
BGP parser will throw exception when multiple
NLRIs are batched in one BGP UPDATE message.

Change-Id: I6630bca4c222e68f4609134192550d6c0a7ea3ba
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-8156 Fix PCEP topology registration

It is possible that when a PCEP session is being dropped and being
unregistered from ServerSessionManager, the thread gets switched
thus the topology unregistering cannot finish.

If such situation happens, PCEP session from the same PCEP peer will
not be able to established until after DEADTIMER_EXPIRED, as the
topology instance was not removed correctly.

Change-Id: I647ecfbbb35ef6805d563753b7ebd87edfc350fe
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 2801f2b71ca49dcee50b643ef5ed4f53938609fc)

Remove unused LOG

Change-Id: I03d203e42e009ef737b07e05d56f2df5d650cded
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8548: Pass missing parameter to

SimpleBGPExtensionProviderContext#registerNlriParser

Change-Id: I625f82d64efa0d2843b94de31c649572be9cacf9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: I53f8c0348eaa3d2c652f7d8ab928deebc8de8e3d
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Fix RD pattern in RouteDistinguisherBuilder

Type 0 RD is 2+4 bytes.

Change-Id: I7ec0099cf5c1cdf8ab7d333dc26756c17228579b
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
(cherry picked from commit a52ecc55a9dca19ce563cea27263ea0842ff9789)

migrate yangtools deprecated BindingNormalizedNodeSerializer

migrate yangtools deprecated BindingNormalizedNodeSerializer
to mdsal BindingNormalizedNodeSerializer

Change-Id: I32439a487a209a567b5436b204c11d979ac46cc8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6801: Remove deprecated bgpcep *-all features

Remove deprecated bgpcep *-all features

Change-Id: Ib87ea2d091e2eead955b8cf959a02f071365a7f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8356: Rename features4-extras

Rename features4-extras which colides
with controller features4-extras, making
SingleFeatureTest for repos/index fail.

Change-Id: I04c693f853178e08a15eaa5435310659f66ee061
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Commenting failing test until fix is implemented

Commenting out failing until fix is implemented

Change-Id: Icecd697ef54d8141780dfd2ee5cbb1f1f84e05ca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8335: @Ignore InstructionDeployerImplTest

This test hangs fairly consistently in autorelease-carbon.

Change-Id: Idc6a207ff669f433096017494c24d99b8ec02c09
Signed-off-by: Colin Dixon <colin@colindixon.com>

BUG-8306: Fix Pcep failing test

Given that messages takes differents time to arrive on listener
Fix  Stateful07TopologySessionListenerTest by
use checkEquals, which checks the assertion with timeout.

Change-Id: I13733fa7ad7686671d9c026a8528ad912e2c7cd5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix karaf4 features

Features should be pulling in transitive dependencies from
the corresponding features. Fix that.

Change-Id: Ib758202ad0ff03e3a44b8a040dcc72f241c59920
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8275: Close ReadOnly transaction

PCEPStatefulPeerProposal needs to
close ReadOnlyTransaction created
after use it

Change-Id: I1515f09028c9e6bd8403d6ea2851196511d4da24
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8202: Fix Conflict Modification on odl-programming

Instruction DS configuration only should be written
on Leader when instatiateService.

Change-Id: I9acf17c8a19d8b22d83e62b315fdadf9494783f2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8252 Fix IP prefix length util

The byte representing IP prefix length is a unsigned byte.
The length should be converted to an unsigned int explicitly.

Change-Id: I0c1df171822858825da69f39c91de9ed332865f8
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-8198: Fix InferenceException

Add presence statement under graceful-restart-capability.

Change-Id: Idc98f74661d4dea4f440d178da868ec83f896370
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8213: Add missing mandatory attribute on tests

Add missing origin attribute on tests

Change-Id: I125437e187286a7a949e26191e66f19ded123274
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Update .gitreview to stable/carbon

Change-Id: Ia647e2ba233012ddd0d7a1e4896bb8f8210b4700
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Improve synchronization under BMP

Improve synchronization under BMP whenever
transaction chain is created and submitted.

Change-Id: If7a61c394218bd7c78c6021ee19ba42f4276560a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Restrict dependencies scope to test

Restrict various dependencies scope to test

Change-Id: I23cef78c244454d2059311c0d56af753f695c02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-4491: Race condition under PCEP Topology Provider

Race condition under PCEP Topology Provider when
instace is reconfigured, since closeInstance under CSS
is nonbloking, it can race the delete with the writing
of the new instance when restarting.

Fix by calling first closeServiceInstance(blocking)
on topology instance and once it gets done call close.

Change-Id: If79bf34f77223bc56424a57e4e600fdb17ddd154
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8021: Race between Peer structure creation and route init.

There is a possibility of race between Peer structure
creation and route initialization/advertizement.

Fix by introducing a flag, which indicates whether
peer's structure has been created and is able to be updated.

Change-Id: Ia9515d2017cb5213ce286e463712092c87764e10
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7976: Race between peer removal and routes update

There is a race condition when we are advertizing routes,
and a session peer goes down which will end in
removing the peer from DS.
Since advertizement and removal are done by 2 different tx,
we need to do it blocking mode, and not route should be
advertized until peer is removed and vice versa, peer
should not be removed until routes are advertized.
Otherwise toure update will try to update a peer/path which
is not longer present.
Fix by rework PeerExportGroup & ExportPolicyPeerTracker,
now instead of generate PeerExportGroup each time a peer
is reg/unreg,  we make PeerExportGroup work as a
blocking registry to solve previous issue.

Change-Id: I46a27871bfa2aa2a632e3bfb76061105c62bb6d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix sonar complains

- Remove unused imports
- Throw exception
- Name convention
- Comparison
- private constructor on util
- replace explicit type per <>
- migrate to java stream api

Change-Id: I224eb8dfe776130b0f45468be4791239daf878af
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix BmpDispatcherImplTest intermitent failure

-Use CheckUtil under test.
-Use mockito timeout.

Change-Id: I2e6c77de1324dc079375271bd7c2e2d028a9fc4f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975: Integrate Topology Provider with CS Service

Integrate Topology Provider with CS Service

Change-Id: I0e9c42aa3538e0936b74120535fee369db1ad9d5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement test for InstructionDeployer

Cover InstructionDeployer with test

Change-Id: I8ed071a8a11dd0d9183fe6c5b45ae7616f6ce5f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework CheckUtil Test

Change-Id: Icada2980901bea076b061b933d8ba42876d0e5f5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Correct XSD pattern

YANG patterns are XSD regexes, so they have implicit ^/$
anchors. Fix this up.

Change-Id: I911ca3d3bd286c0f77bccfb4f3e9a3ef8fc8dbdb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean Up

Classes missing final

Change-Id: Ie260d9f4a48290b492171f79f94f7f8ee53ccbde
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Clean Up

Fix instance fields not accessed with this

Change-Id: Iec1520fa728ea21098dd5a79dbfa25837b117e1c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Clean Up

Anonymous type replaced by lambda

Change-Id: Idd81b1e43866e5d960ec2dfa777b66bae3e53da9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire topology-provider with BP

-Wire topology-provider with BP
-Preserve backwards compatibility

Change-Id: Ibc459117b1656a0efe5e34365b9fc131479bdaea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7960: Fix AssertionError under AppPeerBenchmarkTest

Use CheckUtil.readData for check DS update.

Change-Id: Iae77923c4b8fe0e3a87ffeff0b5c4d00815bf88d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code clean up

Remove unnecesaries imports

Change-Id: I0ecf1894c1be211f9ffd7ed0d98a3c80ae9a6025
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7964: IllegalStateException under testReconectClient test

Fix by wait until channel is closed before retry to connect.

Change-Id: If1c7889b7988ce5cab3e11f73b6134ad2af182c7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 7b48d57ba01775ff48b1686ea8093b009df2ee3c)

Fix NPE under TopologyProviderTest test

Fix by check reportedLsps is not null.

Change-Id: I18878db061ab5816ac5f13e5cdac21107df86aa1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest

Remove deprecated class AbstractDataBrokerTest under
programming and data-change-counter tests
Perform some code clean up

Change-Id: I2ff02760338d8774c3908d107ff76de433acba2a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7946: Fix  SomeModifiersUnresolvedException

SomeModifiersUnresolvedException under ConfigLoaderImplTest
Fix by remove duplicated schema.

Change-Id: I1200e21e76e6da0d35a10932eede27df4a410aa0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7894: Fix ConcurrentModificationException under test

-Fix ConcurrentModificationException under
testSessionTriggeredFullDBReSync test
-Perform some code clean up

Change-Id: I8e4652f273ea994efa5b9477f8af59239e92dd08
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove pcep-service.yang.disabled

Remove pcep-service.yang.disabled

Change-Id: Ib862326a5cd976c6cc9fb714892c8064915a3cfb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest under BGP

Remove deprecated class AbstractDataBrokerTest on tests.
Perform some code clean up under tests.

Change-Id: I64b120bdbbf59db4df0e4d4e2d769eac22738c33
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7937: Fix BGPTerminationReason

When closing the session because of some error
2 Notify messages are sent. One containing the
reason and other with CEASE.
Fix by dont send CEASE Termination Notification
if already other termination notification has
been sent.

Change-Id: Ibfabd7cfb038bef7a452a7458cd5cc1e6fa4b9a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7003: Remove sleeping from Tests

Remove sleeping from test whenever possible.
Clean up some tests.

Change-Id: I734ca5721090669c75f09d107ee4c5ea1e3d14ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7505: Conflict Modification

When closing Peer and Rib, can cause
race condition between the removal
of the peer and the rib when updating DS.
Fix by close peers on blocking mode, and once
they are closed proceed with rib.
Same its applied in case that peer/rib is updated.
First we close it and then once DS is updated
we proceed with creating the new instance.

Change-Id: Ibe70e0324ae12bcbb88b2e7f039671141447ddb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest under PCEP

-Remove deprecated class AbstractDataBrokerTest on tests.
-Perform some code clean up under tests.

Change-Id: Iee8bdb1e190c80aa0ae883e52963afb6b29cc4f0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Programming Clean up

Migrate deprecated classes
Code clean up

Change-Id: I06551491a30499d81d4c0dc7f0e1dbe68dc04eab
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975:  Integrate Programming with Cluster Singleton Service

Integrate Programming with Cluster Singleton Service

Change-Id: I95e3c8c1dc1e596c060256d3f59fec9cfe882456
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement Programming config via DS

-Expose programming's configuration in config DS
-Allow multiple programming configuration

Change-Id: Ib6de3355dae6533367890ef87c504edbdca04654
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire Programming with BP

-Wire Programming with BP
-Preserve backwards compatibility

Change-Id: I750fdb86a6c22d3b1a90e7466466ab7c5426d729
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug 6859 - Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:
org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

Refactoring changes in MDSAL, see:
https://git.opendaylight.org/gerrit/#/c/52107

By using of Binding generator v1, this change needs to be addressed in
Bgpcep project.

- refactoring itself

Change-Id: Iccb2af9806db18a3e5bf98092ca70ae9b350dabf
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Improve Singleton Service Logs

Improve Singleton Service Logs

Change-Id: Ie09d2e00e7159539dcecc520ef0e9cd39ca4e02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-7614: LocRibWriter does not recover well from transaction chain failure

If transaction chain associated with LocRibWriter fails, create a
new transaction chain and re-initialize it with the new chain.

Change-Id: Ibbb60c41594ad6b3602cabac18f5e4bccaa093bb
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7768 Fix missing registration

In previous BUG-7768 fix, pcep topology registration was
missing. This patch adds it back. It also adds several debug
logging and unit test.

Change-Id: I4c82a7fcd9cb1ed7371817ffabc52fdf927ab51e
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Add CheckUtil coverage

Add CheckUtil coverage

Change-Id: I90524766fa989c97ab2e10d7fbe08904e269770c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7222: Make BGP DS clean up asynchronous

Close of the service must be done async, otherwise
will bock the thread.
Fix by make BGP DS clean up asynchronous

Change-Id: Icb19ef7b7f118fbc6b07407d1df2cb5f6cffc0fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Clean up check tests and  util tests

Remove duplicated code on check utils for tests.
Clean up PCC mock tests

Change-Id: I1347f6561cb4ede6c8f4147680d92c3a84f92520
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-4808: remove reference to IdentityHashMap

Class documentation is misleading, as the internal cache is implemented
by a weak key/weak value equivalent.

Change-Id: Ie0d08ee990b725c5ed1a52cb074b6f72eff2a26f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Remove redundant cast/type argument

Change-Id: I446cb24bdbcb5156136899798eb6d3d607291e62
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Remove unused test class

Remove unused test class MockPCE

Change-Id: If0afe1e8f78beca02dd397c9e18f3da408a939bf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove no longer required pcepdump

Remove no longer required pcepdump.py

Change-Id: I662f6971c3b0e210e4c692402a23617d6e473939
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7768 Synchronize ServerSessionManager for PCEP

Add the check so that session manager can only be closed once
and becomes unusable after closing.

A java.util.ConcurrentModificationException is possible to happen
due to the close() method of ServerSessionManager is not synchronized.
The situation mostly likely will happen during a controller reboot.
It may also happen when a PCEP config is updated. The ServerSessionManager
is being restarted while all the PCEP negotiation is still happening.

Change-Id: I0e0d387add046a4fe9ec5ac74a85f8350e238d60
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 7a866eee4dec5dc368ef11c90473b3c2a256f281)

BUG-7550: Implement CSS under Operational State

Implement Cluster singleton service under
Operational State.

Change-Id: Iaea4d97948b8c260fb38172107a155a298fd889e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code clean up

replace long literal 'l' by 'L'

Change-Id: I9d8bffb3559887336299e84d77db82fdf7e5f379
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7776 Fix Test

Change-Id: I86bafac12ceada82f18b27bb7adeeaa4ca6783c3
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7706: Fix ServiceUnavailableException

Reconfigure BGP Server durin a session, will produce
ServiceUnavailableException at the moment session is
closed and tries to remove peer from StrictRegistry.
Fix by put aside registry from Peer Acceptor, therefore
when BP container is restarted reference wont be lost.

Change-Id: I4eb018a24e5c5ea2a4b479cba61d94cb3658f583
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Migrate test from junit 3 to junit 4

Change-Id: I88e78739de6acf531154e2238e569ad5abd2f0da
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7512: BMP features migration to karaf 4

BMP features migration to karaf 4

Change-Id: Iee8a60c7831cb8a5af791b297b2052648e21b26e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7510: BGP features migration to karaf 4

BGP features migration to karaf 4

Change-Id: I78156ba3da5a5da396d8b98bc77f79e16ae8d2c7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

BUG-7739: Fix ParserToSalTest/Topology Tests

Fix ParserToSalTest/Topology failing test

Change-Id: I01cec1b9ab83c14cec8674465ed690e77d820adc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-7708: Invalid Route Distinguisher error while processing withdraw update containing VPN route

 - RFC 3107 says that label value in withdraw message should be 0x800000
   ref. https://tools.ietf.org/html/rfc3107#section-3
 - Changed code to correctly handle this value in withdraw message received from peer.
   Also ODL will now use this value when sending withdraw message to its peer
 - Updated unit-tests accordingly

Change-Id: Ie9d90779c32e9141f953a18b07a86d0624eaee5c
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 16e0aa31e782252f25860556bd3eb4fd59431789)

Pull in osgi.core explicitly

Inherited scope runtime is not sufficient, as something
in the dependecies is causing us to compile against 4.3,
which does not have generics.

Change-Id: I7a4fda07f10859698892414b43ba64cbb6e5f3fb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

replace asList by singletonList

Change-Id: Ie3235ce8e7c7df527765e69183a52a1d56f30d70
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Switch to using odl-netty-4

odl-netty is deprecated by odlparent, the new name is odl-netty-4
and shares odlparent's version.

Change-Id: Ib07fea42952d9c9a157fb8d3c9fa7f6a2ce7128c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Remove unnecessary semicolon

Change-Id: I1fae14a786876bdb5da830a31d64987498bd18ca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7511: PCEP features migration to karaf 4

PCEP features migration to karaf 4

Change-Id: I490f7504c078cf21642d9fd527d2bd4ac9dd83bd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-7514: Extras features migration to karaf 4

Extras features migration to karaf 4

Change-Id: Ie5f459a45ab74baa17b3544cba101beaadaabf12
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove duplicate code for test utilities

Remove duplicate code for test Utilities

Change-Id: I8d7d2652cd5159af106d439a6b62767a73296e87
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7732: Improve BGPDeployer synchronization

Improve BGPDeployer synchronization

Change-Id: I0a4c321ac36efefea473d0e2557588c6d687d5d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7723 Change BGP connection failure log level

Change the BGP connection failure log level from DEBUG to WARN.

Change-Id: I68766d8849a7ce246959534b5fc80aa2eaf8fc3c
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-7251: Remove pcepy

Remove pcepy folder

Change-Id: I571c9f8f646c0b8207a203a06a49a47649a59c83
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>

Fix missing relativePath

odlparent-lite is outside of bgpcep project, hence
it should have an empty relativePath

Change-Id: If40a1eed870c69bb71290cd19139681fafa18e4e
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add relativePath to RSVP4-features

Add feature-repo-parent as relativePath

Change-Id: I91167632297b629a023b49a019a4fad99dda4ac2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>