jenkins-releng [Wed, 14 Nov 2018 20:36:27 +0000 (20:36 +0000)]
Release Fluorine
Claudio D. Gasparini [Fri, 2 Nov 2018 17:11:45 +0000 (18:11 +0100)]
Remove unnecesary feature
from config loaader feature
Change-Id: I48b767c52265f50072bb82afde7df8b1c5dede97
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit
8597ba2ad92ffeb5ed9644fcd691880e567fcb9f)
Claudio D. Gasparini [Fri, 2 Nov 2018 16:50:05 +0000 (17:50 +0100)]
Fix handleDeletions
JIRA: BGPCEP-840
Change-Id: Icef3407608e526f95621ae786524b70c0358d3d1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit
8f2d7c68510198b33f93185094a065abc18ed863)
Matej Perina [Mon, 22 Oct 2018 11:05:06 +0000 (13:05 +0200)]
remove redundant ImmutableMap call
Change-Id: Idfbbfa44a0835a9caaf0c094b89a2c841224bb09
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
Matej Perina [Wed, 31 Oct 2018 10:22:13 +0000 (11:22 +0100)]
use thread-safe list in ConfigLoaderImplTest
- to prevent ConcurrentModificationException in
situation when List.stream() is called at same
time as List.clear()
JIRA: BGPCEP-829
Change-Id: I9e69971de5ec75ca515e81e2b95fe44e50489fda
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
Claudio D. Gasparini [Fri, 26 Oct 2018 08:36:24 +0000 (10:36 +0200)]
Fix LEAK: ByteBuf.release()
JIRA: BGPCEP-839
Change-Id: I07692d26e7b8cbb3b1134a61f2ea0c5947b8bd81
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 24 Oct 2018 06:16:56 +0000 (08:16 +0200)]
Fix LinkstateTopologyBuilder NPE
JIRA: BGPCEP-838
Change-Id: Ie5ba13434245195d77e3c29850cf54ef973e3441
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Stephen Kitt [Thu, 11 Oct 2018 09:47:01 +0000 (11:47 +0200)]
Bump to odlparent 3.1.4 and yangtools 2.0.12
Also add jaxb-api to dependencies, as we are using DataTypeConverter
from this package.
Change-Id: Id1007af6d0052f65d1105514a14d08bf1398ab3d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Wed, 17 Oct 2018 06:40:04 +0000 (08:40 +0200)]
Include Routes Node when generating route path
Given that it is common node, therefore
duplicate code can removed and is easier for user.
Change-Id: I5babaf17c9b70258aa7772e7cd5c443dcad9a442
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sun, 14 Oct 2018 01:48:40 +0000 (03:48 +0200)]
Remove unneeded references to yang-maven-plugin
This artifacts do not contain a yang model, there is no point
in invoking the plugin.
Change-Id: I8f9dc452e61542310bd28afc3dc024551f754c28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
225040a646751901e50597dabfd8128161cfe188)
Matej Perina [Tue, 9 Oct 2018 10:28:27 +0000 (12:28 +0200)]
fix concurrent access to config file
- calling handleConfigFile from two differrent threads was
causing ConncurentModificationException in ConfigLoaderImpl
test
JIRA: BGPCEP-829
Change-Id: I9ada792c98aafc06daa8971b75df22b85b3ff4c1
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
Claudio D. Gasparini [Fri, 5 Oct 2018 19:50:28 +0000 (21:50 +0200)]
Handle RT removal at different level
under eff-rib-in.
JIRA:BGPCEP-830
Change-Id: Id0539fe1334a03847c1cfeb66dfb074821e8b6ae
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 17 Sep 2018 09:02:01 +0000 (11:02 +0200)]
Bump yangtools-2.0.11
This brinsg in the latest fixes.
Change-Id: I488d974f26b8478b6d60381f48c54e6a85f14c59
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Thanh Ha [Sun, 9 Sep 2018 00:36:10 +0000 (20:36 -0400)]
Migrate bgpcep docs to the bgpcep project
Issue: DOCS-69
Change-Id: I855bbc445316b0b0fef428666cd31eb56f7bac12
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sun, 9 Sep 2018 00:30:30 +0000 (20:30 -0400)]
Bootstrap bgpcep documentation
Issue: DOCS-69
Change-Id: Ia94987eddf0ce52e73b1244770a97f43555e4a8b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Claudio D. Gasparini [Mon, 3 Sep 2018 14:23:45 +0000 (16:23 +0200)]
BGPCEP-826: Add route target extension StatementActivator service
to META-INF.services
Change-Id: Iab969af474936dd226d255d5bf6d618d0b3845ba
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 20 Aug 2018 18:02:27 +0000 (20:02 +0200)]
Return Set instead of Iterable in test setup
This allows us to define equality in superclass, hence return
proper Set.
Change-Id: Ic37c3283ff234181320201f18e14047d6aa92d37
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
3ac945ff239a96c6e9a814e900ada0258ccbbe47)
Robert Varga [Mon, 20 Aug 2018 15:29:30 +0000 (17:29 +0200)]
Fix findbugs warnings
These bugs are reported by upgraded findbugs, fix them prior
to the actual upgrade.
Change-Id: I0c21059a289abec1631f3a7b324c771091930804
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
4ab0ad7fd8743175737b390dae5d13d0736f6ecc)
jenkins-releng [Thu, 30 Aug 2018 16:51:19 +0000 (16:51 +0000)]
Bump versions by x.y.(z+1)
Change-Id: I212f6e70526d8e8611677502d3922c9c03818256
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Anil Belur [Thu, 9 Aug 2018 12:12:24 +0000 (17:42 +0530)]
Update .gitreview to stable/fluorine
Change-Id: Ie124ca1eb155de44e2076e17aba9cac3b84b04eb
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Robert Varga [Mon, 6 Aug 2018 15:48:24 +0000 (17:48 +0200)]
Bump yangtools to 2.0.10
This fixes an issue with actions, hence we need it in Fluorine.
Change-Id: Ie12ee96d9659441d45a144cc99ef46af912dab76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 1 Aug 2018 09:47:52 +0000 (11:47 +0200)]
Use newly-introduced type-safe methods
New methods allow us to precisely target specific case items.
Change-Id: I22c3df0c9bb94767b769020e3d87cad9b4cf7f2d
JIRA: MDSAL-342
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Wed, 1 Aug 2018 14:48:48 +0000 (16:48 +0200)]
Workaround for jenkins Route target test
JIRA: BGPCEP-817
Change-Id: I4bb5bbc0c39388669bb811ad85b12df2394a21f6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Sat, 28 Jul 2018 09:50:45 +0000 (11:50 +0200)]
Adjust for API change
Returned collection type changed slightly, fix that up.
Change-Id: Ib0fede6f8646692d8a9c06740572f51063ba8ccf
JIRA: MDSAL-342
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 27 Jul 2018 12:06:00 +0000 (14:06 +0200)]
Bump yangtools to 2.0.9
This patch bumps yangtools to latest release.
Change-Id: Ie31438a7ce35a149f72a8b024ac2e19e4b736bcd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Matej Perina [Tue, 24 Jul 2018 10:55:24 +0000 (12:55 +0200)]
fix timing issue in server creation for BmpMockTest
- add wait unitl server is created
Change-Id: Id217822e57be8c7df1139341af9ade2517dad516
JIRA: BGPCEP-815
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>
Stephen Kitt [Wed, 18 Jul 2018 16:06:37 +0000 (18:06 +0200)]
Bump to odlparent 3.1.3
Change-Id: I10266e55e95d2697ab8c92c47ac0f08c05a31d71
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Tue, 24 Jul 2018 01:02:46 +0000 (03:02 +0200)]
Use moved BindingReflections
BindingReflections is moving away, make sure we are using the new
version.
Change-Id: I972cad0c094457519a12dba058d43836b045a78c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Fri, 20 Jul 2018 08:21:31 +0000 (10:21 +0200)]
Reduce use of waitFutureSuccess utility
Change-Id: I5c24101645c592052155402cc3835e63dfc690d1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 20 Jul 2018 06:51:43 +0000 (08:51 +0200)]
Rework BmpMockDispatcherTest
- Use test timeout instead of waitFutureSuccess utility
- use blocking futures
JIRA: BGPCEP-814
Change-Id: If21621f2e0aaf3c903671f395d051d6dfca0daa0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Ajay Lele [Tue, 17 Jul 2018 21:09:14 +0000 (14:09 -0700)]
Fix calculation and roll-over of BGP operational neighbor uptime value.
Change-Id: I15211d925664f275f1980df863cf6cefce8c0ba4
JIRA: BGPCEP-813
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Robert Varga [Thu, 19 Jul 2018 13:21:57 +0000 (15:21 +0200)]
Cleanup feature dependencies
Some of our basic features do a rather massive over-inclusion,
fix that.
Change-Id: I483d6b9d83b60087c64589abb19d7fa13e3ff75c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Jul 2018 11:31:39 +0000 (13:31 +0200)]
Remove powermock dependency
powermock is not used anywhere, remove the dependency declaration.
Change-Id: I475eda21b1448cbab46837796f03bdaef409fbfb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 16 Jul 2018 21:17:03 +0000 (23:17 +0200)]
Minimize model dependencies
Change-Id: I829e2411b605963ad642b8a9255297ed1b7cd208
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 15 Jul 2018 22:39:22 +0000 (00:39 +0200)]
Use union stringValue()
getValue() is going away, use stringValue(), which is its replacement.
Change-Id: I1112f5417bb41bd21b7a53913b615afc4c34c190
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio David Gasparini [Thu, 12 Jul 2018 16:32:53 +0000 (16:32 +0000)]
Revert "Add mdsal-dom-api dependency"
This reverts commit
cb0fe804f72ec0c8fb7a002dcf2c64d6b097d489.
Change-Id: I106d1d102fc3b1c9a611cfe05d691aa319131c03
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Wed, 11 Jul 2018 21:13:05 +0000 (23:13 +0200)]
Add mdsal-dom-api dependency
We are now getting mdsal-dom-api, make sure we account for that.
Change-Id: Ib736e51b4ca833b7748d2b2741408d1695386018
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 7 Jun 2018 15:28:52 +0000 (17:28 +0200)]
Convert rsvp-api to use ip-address-no-zone
First step in conversion, more to follow.
Change-Id: I94c7efcdb5fdb6248797105e73e4cacd5b7f5816
JIRA: BGPCEP-790
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Thu, 12 Jul 2018 06:42:56 +0000 (08:42 +0200)]
Add required mdsal-dom-api test dependency
Change-Id: If7dbb7302d25c09ae5b4b4c839632fbb2b817371
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 10 Jul 2018 06:51:34 +0000 (08:51 +0200)]
Handle no present ext community for VpnNonMemberHandler
avoiding possible NPE
JIRA: BGPCEP-811
Change-Id: I1a597d712bb847ca5708345248c2b06766ecd002
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 9 Jul 2018 17:18:04 +0000 (19:18 +0200)]
Fix invalid models
These models do not contain correct import stanzas and were resolved
accidentally via prefixes declared in modules thy are importing.
JIRA: YANGTOOLS-889
Change-Id: Ia94e3f78ed4a9aec8b55743b821373738b4e6c54
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 18:06:00 +0000 (20:06 +0200)]
Fix invalid tests
Generated unions are enforcing length/range of included types,
which means unit tests which use illegal values need to be fixed
up.
Change-Id: Ieb6ff3b2dca42cef5f104ac976e1e54835fba06c
JIRA: MDSAL-360
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 4 Jul 2018 18:11:03 +0000 (20:11 +0200)]
Switch pce-id to a simple type
Union of binary with different lengths does not really make sense,
use length alternatives instead.
Change-Id: I76cd4ad77b51d3e6e6a0522aa5457e7ce56fd590
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Wed, 27 Jun 2018 15:31:27 +0000 (17:31 +0200)]
Route Target Constrain Default Routing Policies Config
JIRA: BGPCEP-527
Change-Id: Ic59614fd81015a66d2ee4d7d9659f273457f21db
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 3 Jul 2018 10:39:52 +0000 (12:39 +0200)]
Follow common singleton pattern
for condition handlers.
Change-Id: Id8568ca0231565e509ce741c9a4fb91f7a6355ff
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 2 Jul 2018 11:02:32 +0000 (13:02 +0200)]
Route Constrain policies
Actions
- Prepend client attribute
JIRA: BGPCEP-527
Change-Id: I24719e1c6a41c11165437539cc8a7714240da798
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 29 Jun 2018 09:19:02 +0000 (11:19 +0200)]
Implement Set Next Hop Type Self
remove duplicated route policy, using
openconfig one.
Change-Id: I04fc6167956134bb2769cedbc04df48fb3d4c943
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 29 Jun 2018 12:52:12 +0000 (14:52 +0200)]
Improve CSS logs
Change-Id: I263d506fb7ba340ecf84c541a08367f458b8ec92
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 29 Jun 2018 12:25:19 +0000 (14:25 +0200)]
Fix checkstyle complains
Change-Id: If6d289edfc8eaab6946fb5c5b3d379909fdbaf98
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Thu, 28 Jun 2018 06:58:02 +0000 (08:58 +0200)]
Bump yangtools to 2.0.7
This patch brings in the latest yangtools release.
Change-Id: Ib25415ef91d228abb3b0c0674452078d4d3377d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Thu, 28 Jun 2018 17:04:25 +0000 (19:04 +0200)]
Fix checkstyle complains
Change-Id: I692780c68bc2d57e497fac10e5595550f020b5cf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 28 Jun 2018 16:19:59 +0000 (18:19 +0200)]
Handle correctly peer group name
when removing peer
JIRA: BGPCEP-804
Change-Id: I11b1e6d222900be5f2986274ad7c0f92c4ba2c35
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 25 Jun 2018 12:17:10 +0000 (14:17 +0200)]
Rib Out Route Paths re evaluation.
Allow to perfom a reevaluation of one specific table,
and update rib out for an specific peer.
This will allow to re evaluate paths advertized
for an specific peer when two families are interconnected
like RT and VPN, reducing the volume of message it can
produce to reevaluate the full table for all peers.
JIRA: BGPCEP-527
Change-Id: I3056aa2e4a2e9b94fb9c4a1c99a09fe972500f4f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 28 Jun 2018 11:45:25 +0000 (13:45 +0200)]
Reduce duplicated code
- reduce noisy log TRACE
Change-Id: I46fc307441f0ca3226f63a0e13c3084c2ed930e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 22 Jun 2018 06:03:58 +0000 (08:03 +0200)]
Route Constrain policies
Conditions
- afi-safi-not-in
Actions
- set-local-address-as-next-hop
- set-originator-id-to-advertizer-router-id
JIRA: BGPCEP-527
Change-Id: I9f784175440fa6f5ab7e7d33cd1d9a72e4bf1ad5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Thu, 28 Jun 2018 09:21:14 +0000 (11:21 +0200)]
Fix invalid rsvp model
Augmenting the same choice with equally-named containers from
a single model is data tree namespace violation. Fix that.
Change-Id: I36eea127a33ade8dec108042bd43dac12e97e64e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 28 Jun 2018 07:30:06 +0000 (09:30 +0200)]
Fix invalid flowspec model
Augmenting the same choice with equally-named containers from
a single model is data tree namespace violation. Fix that.
Change-Id: Icb5f1580c23fd53365481c89111888566eb04747
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Tue, 26 Jun 2018 14:03:23 +0000 (16:03 +0200)]
Update supported afi/safi for bgp testtool
Change-Id: I954354918f7d8a0d3433c6a9068cdca870550345
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 27 Jun 2018 13:29:23 +0000 (15:29 +0200)]
Fix Route target nlri default route serialization
Change-Id: Ic9b16ad72415631efd7814992e99e6b98f1d98f0
JIRA: BGPCEP-802
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Stephen Kitt [Wed, 30 May 2018 13:45:17 +0000 (15:45 +0200)]
Bump odlparent to 3.1.2
Change-Id: Ib8005701ca2b775ff14431c0667be1dafc709cfb
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Claudio D. Gasparini [Mon, 18 Jun 2018 14:24:26 +0000 (16:24 +0200)]
Route Target constrains Extension
https://tools.ietf.org/html/rfc4684
JIRA: BGPCEP-527
Change-Id: Idcb79c3072caa19775a48fbf6980cc8b89504eea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 21 Jun 2018 13:51:30 +0000 (15:51 +0200)]
Improve handling for protocols config changes
Given the dependency of Peers of Rib.
When delete
- remove first peers
- then remove Rib
when modification
- update rib
- then update peers
JIRA: BGPCEP-799
Change-Id: I582398dab191842473f7cbbd1010b76fe9a9d9fd
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 21 Jun 2018 10:00:56 +0000 (12:00 +0200)]
Handle trailing bits under L3vpn mcast
deserialization.
Change-Id: Ib46b269ec0d6138a0234e4478e7d62420814a3bd
JIRA: BGPCEP-800
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 20 Jun 2018 06:12:09 +0000 (08:12 +0200)]
Move route target ext comm container
outside extendend communities cases.
Allowing to reuse the models.
Change-Id: I9faab101f4b5ed0613fe26646be9da2fad58b942
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 19 Jun 2018 12:09:48 +0000 (14:09 +0200)]
Inherit common extensions families dependencies
from extensions parent
Change-Id: Ic115f76bd184142d15e9b42f69f80dfd12fa375a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Tue, 19 Jun 2018 12:00:47 +0000 (14:00 +0200)]
Create common parent for extensions families
Change-Id: I9aff6bb41e565df54fcbcfb660ac014b7547c334
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 16 Jun 2018 14:35:19 +0000 (16:35 +0200)]
Code clean up
- remove unnecesary returns
- simplify asserts
- remove unnecesary casts
Change-Id: I5f1410b35bcb6552e6ecd94d08a155dfbc295d9a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 16 Jun 2018 14:33:43 +0000 (16:33 +0200)]
Simplify assertions
Change-Id: I119df17bdb5a7bbb54245c52b6927ba05f853c0e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Sat, 16 Jun 2018 14:33:05 +0000 (16:33 +0200)]
Remove unused imports
Change-Id: I5ee0880720e5aee4ddb695d7d4d57010fee67ff3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Fri, 15 Jun 2018 09:37:30 +0000 (11:37 +0200)]
Enforce fail on maven-dependency-plugin warning
- fix complains
Change-Id: I2917adc88b3251f39afceff371996d26a6501dbc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 14 Jun 2018 16:18:57 +0000 (18:18 +0200)]
Provide Empty table instead of empty route container
by ribSupport.
Change-Id: Ie75c0005484caf749425551779e6e6a413c72f13
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 22 Mar 2018 07:40:33 +0000 (08:40 +0100)]
Use Peer transport group config
Change-Id: Ibd1caba31db4b95dcdf9f93f91e5e875cab9c25b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 14 Jun 2018 14:56:18 +0000 (16:56 +0200)]
Improve Attribute serializer/parser Interfaces
use Attribute interface as parameter instead of
DataObject. Removing all redundant cast and validations
Change-Id: I97aa58e71cf27a38daf618839d8070ef6dcec48a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 14 Jun 2018 13:47:15 +0000 (15:47 +0200)]
Cache Instance identifier to table/(choice routes)/(map of route)
Change-Id: I7e765f53410b17100a5ff1790c1a038ce66140a3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Thu, 14 Jun 2018 11:45:06 +0000 (13:45 +0200)]
Fix multiple checkstyle complains
Change-Id: Ie499dd6a81262bd5e09823099ce8b6c91ddc9065
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 13 Jun 2018 15:50:21 +0000 (17:50 +0200)]
Move MVPN extended community to concepts
since they are shared by differents family extensions.
Change-Id: Idf1b37946fd3088f4513aaeefa3df31ca8e90639
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Mon, 28 May 2018 10:54:42 +0000 (12:54 +0200)]
L3VPN MULTICAST
- RFC6513
- RFC6514
JIRA: BGPCEP-396
Change-Id: I7d4a7628d8a32f4b00b28a4ee4ad0f926a8f0070
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Thu, 14 Jun 2018 10:15:11 +0000 (12:15 +0200)]
Do not fish for augmentation in getPort()
Pass down the expected augmentation class rather than fishing for
it.
Change-Id: I987ef156e09c70b8de5c5269f43dd7eaf76505bc
JIRA: MDSAL-328
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Mon, 4 Jun 2018 11:23:56 +0000 (13:23 +0200)]
Split Peer Ribout storage from loc rib
Meanwhile loc rib is part of rib,
loc rib out is represented per peer.
Therefore loc rib should be updated
by rib transactions chains,
and peer shuld be on charge of
handling transaction for updating ribout.
Achieving a correct sync when closing session
and cleanin datastore Peer ribs.
JIRA: BGPCEP-785
Change-Id: I891a6842c68a1d017fff22a6c0f34c2090c140bc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Tom Pantelis [Wed, 6 Jun 2018 13:38:37 +0000 (09:38 -0400)]
Use ServiceTracker instead of WaitingServiceTracker
WaitingServiceTracker is in config-api which is going away.
WaitingServiceTracker is just a thin wrapper around ServiceTracker
so just use ServiceTracker directly.
Change-Id: I1a2742941db31ed98431fefee8310a4cb6735730
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Robert Varga [Tue, 5 Jun 2018 11:57:39 +0000 (13:57 +0200)]
Access augmentations only once
Cache the result, making the code simpler and faster.
Change-Id: Ib7f56ca8ec6d71633d76964af856d05367c9f212
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Mon, 11 Jun 2018 03:45:44 +0000 (05:45 +0200)]
MVPN Extension Clean up
- initialize Ipv6 Registry before start Ipv6Ribsupport Test
- remove unnecesary variables
- make final when possible variables
Change-Id: I6704d1ef732c6092b85c4fa3bae422a6ca2a10b4
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 28 May 2018 10:18:41 +0000 (12:18 +0200)]
Bump yangtools to 2.0.5
Latest fixes.
Change-Id: I16db310fab811486942b90778d5beefedfa1679d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Mon, 4 Jun 2018 10:58:21 +0000 (12:58 +0200)]
Add MDSAL Trace feature to distribution
Change-Id: Ib3484c1ccfdddb567a11a2a578013211af228f29
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Tom Pantelis [Mon, 4 Jun 2018 13:59:11 +0000 (09:59 -0400)]
Remove sal-dom-broker-config dependency
It's not needed and is going away.
Change-Id: Ie87ab33386017930e43c875695a3fe6adaf9c25f
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Robert Varga [Tue, 24 Apr 2018 14:52:26 +0000 (16:52 +0200)]
Fixup Augmentable and Identifiable methods changing
This is a fixup of the change in binding codegen, adjusting:
- getKey() -> key()
- setKey() -> withKey()
- getAugmentation() -> augmentation()
Change-Id: I0c43fd2ff1d7913718597ebf18d979842c4559c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Robert Varga [Mon, 4 Jun 2018 11:03:39 +0000 (13:03 +0200)]
Fix more type safety warnings
We can use proper arguments to make warnings go away.
Change-Id: I626a3ed5b90c00822e0f62381d995c720fcc7108
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 4 Jun 2018 10:57:21 +0000 (12:57 +0200)]
Fix more potentially-static methods
All these methods can easily be static, make it so. Also do not
access attributes/augmentations multiple times.
Change-Id: I784ce35ce9d6e9f86e51514c98d6432db9a0f4ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 4 Jun 2018 10:50:17 +0000 (12:50 +0200)]
Add some RIBImpl.toString() attributes
This fixes a static method warning.
Change-Id: I9132a7cb1db588cddca38eea17dfc8bfea855cdf
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 4 Jun 2018 08:59:52 +0000 (10:59 +0200)]
Make AbstractRIBSupportTest type-safe
Add generic arguments to bind types which the test needs.
Change-Id: Ie3c874dbcd30a8366ec342edb4e0ff24353e42cb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 4 Jun 2018 08:50:01 +0000 (10:50 +0200)]
Fix a couple of warnings in l3vpn
- static method
- unnecessary if/else
Change-Id: I1efa627d7cd4ffcef239caac0244581921fae376
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 1 Jun 2018 10:40:42 +0000 (12:40 +0200)]
Fix raw RIBSupport reference
This should be properly parameterized.
Change-Id: Ie4a366d7f2f23b89ddffe37aa84da5503cd0d89d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 1 Jun 2018 10:46:14 +0000 (12:46 +0200)]
Use case-based addressing in RIBSupport
This improves type safety of RIBSupport implementations by taking
advantage of ChoiceIn.
Change-Id: Icc75b1489a88e9526cf28af15fb2cbba61cee880
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 1 Jun 2018 10:41:54 +0000 (12:41 +0200)]
Use case-based addressing in BGP topology provider
This removes ambiguity and improves type safety around choice/case
classes.
Change-Id: If3d2ffb54061ccfe2e5916f5da03216c0556272c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Fri, 1 Jun 2018 08:43:01 +0000 (10:43 +0200)]
Use range to import yangtools features
This removes version-specific binding, allowing features to be
resolved against newer versions.
Change-Id: I62728a4aa1d3fd817c629bcd7057724b448379ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Claudio D. Gasparini [Wed, 30 May 2018 15:02:03 +0000 (17:02 +0200)]
Match AfiSafi Policy implementation
Change-Id: Iaea1cd7d6933a015282e1cb2f3e24a61f299d305
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 30 May 2018 10:59:49 +0000 (12:59 +0200)]
Rework L3VPN Activators
Change-Id: Icc41267f190431ccb147276f6381df73a94e056a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Claudio D. Gasparini [Wed, 30 May 2018 08:35:02 +0000 (10:35 +0200)]
Create common API feature for Extensions familiy features
Change-Id: I31d8897aac5bdd14ddf3b79f95694c70646aee36
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Tomas Markovic [Tue, 29 May 2018 16:39:06 +0000 (18:39 +0200)]
Fix VrfImportRoute ext com registration
Change-Id: If5e7ddef019f76e4f762f2bdc3fd786443cd9917
Signed-off-by: Tomas Markovic <tomas.markovic@pantheon.tech>
Claudio D. Gasparini [Tue, 29 May 2018 11:12:27 +0000 (13:12 +0200)]
create L3pn unicast package
for split new implementation for
multicast l3von support.
Change-Id: I00596dac87b99bd32d8921b8ab8ccebe5bdbcc10
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Code Review / bgpcep.git / log