Thanh Ha [Fri, 4 Mar 2016 04:15:21 +0000 (23:15 -0500)]
Release Lithium-SR4
Change-Id: I0149ebb436c0b16686c4a37a83d1c2ee8de50c72
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Milos Fabian [Thu, 20 Aug 2015 10:54:15 +0000 (12:54 +0200)]
BUG-2208: set "sync" and "create" flags
-when reporting on update to PCE set "sync" flag always true
-when reporting on update to PCE set "create" flag true
if tunnel is pce-initiated, otherwise set false
Change-Id: Ie7e3ba0ec107e6a2f816435f3df298176db1bb03
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Ladislav Borak [Wed, 10 Jun 2015 14:56:04 +0000 (16:56 +0200)]
Bug 2208 - pcc-mock: enhancemnets
*new functionality
- refuse operations with not delegated LSP
- refuse removing of non PCE-initiated LSPs
- delegate PCC's LSPs to the first PCE at start-up
- support "return delegate" request from PCE for PCC's LSPs, re-delegate, after the "redelegation timeout" expires, to the next PCE in cyclic order
- support "delegate" and "return delegation" for PCE-initiated LSPs, delete LSP if "state-timeout" expires
- if PCE connects, report all LSPs (PCC's and PCE-initiated) with actual state
*new input arguments
--redelegation-timeout <seconds>, default 0 - start timer when delegation for PCC's LSP is returned or when PCE fails;
hold delegation for PCE until expiration; timout is cancelled when LSP is delegated to PCE
--state-timeout <seconds>, default -1 (infinite) - start timer when delegation is returned or when PCE fails;
after timeout expiration, LSP is removed; timeout is cancelled when LSP is delegated to PCE
*new PCEP error added
- LSP is not PCE-initiated Error-type=19, Error-value=9
Change-Id: I7bb4cdf03dd04f9caddc13cf7a70c913aa7e6e2b
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 9 Feb 2016 14:28:35 +0000 (15:28 +0100)]
BUG-5285: Transaction chain broken
Transaction chain broken when peer is connected after
application peer has been configuted.
Issue is caused when it tries to update app-peer adj-rib-out,
which doesn't exist.
Change-Id: I6c765cc0fb03100bc6564466f93eb65fb72cfe48
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 8 Feb 2016 11:05:53 +0000 (12:05 +0100)]
BUG-5266: Perform role change in one step
Two steps role change was done when peer was removed,
after code on LocRibWriter has been reworked for previous
fixes this is not required any more and can be done in
only one step.
Change-Id: I9d885f9b99cffc21f93d18dcf8e953885a44ef38
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 27 Jan 2016 18:51:13 +0000 (19:51 +0100)]
BUG-5097: Error trying to update EffectiveRibIn from a removed Peer
When more than one peer are removed at same time, cause a race
condition between remove Peer from DS and update removed routes.
Fix by creating a shared Singleton cache with removed peers between
listeners.
Change-Id: Ic4b2ab8283e07695203f9e4d9ceb245985104766
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Fri, 5 Feb 2016 09:20:36 +0000 (10:20 +0100)]
BUG-5243: Failed to send message Notify
Don't try to send Notify message if the session
has been closed externally
Change-Id: Idd57bd5bf60e4f758ed0187bd12149854740cd36
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit
14cad280a7d1ba51f72d683e689eb3b2eca96909)
Claudio D. Gasparini [Fri, 29 Jan 2016 10:58:35 +0000 (11:58 +0100)]
BUG-5141: Failed to send Update Message on reconfigure Peer
Clean up when reconfigurin Peer as we do when we reconnect peer.
Update Log levels on LocRibWriter for skipped change.
Making Debug logs more clear.
Change-Id: Ifb3fa2a0e4dc4633814ce3620f5ac585d01aa575
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Fri, 29 Jan 2016 11:13:05 +0000 (12:13 +0100)]
BUG-5138: NPE in PcRptMessageCodec
To avoid NPE, process Bandwidth object first, then
all other objects in the list.
Change-Id: I2a09c7d9be1c2ee83bcd3563c854faaefe35ccd4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
fa5f6bf0a6751f5a1d2866e4951951bd21135a73)
(cherry picked from commit
99cefe68d65c3c737a0668d85c6d1e4aa900e1ad)
Milos Fabian [Mon, 11 Jan 2016 01:10:52 +0000 (02:10 +0100)]
Bug 4921 - Support Bandwidth Usage object
Support Bandwidth-Usage object as defined in
https://tools.ietf.org/html/draft-dhody-pce-stateful-pce-auto-bandwidth-06#section-5.3.2
The object is used in PcRpt message report the real-time
bandwidth usage of a TE LSP.
Make object-type configurable, since no codepoint is assigned by IANA.
By default object-type=5.
Change-Id: I8aacf86cee3f647ad47a0dc01a861b16f89a62c5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
5bd37a2832c88475435300ffe46836cb895309c4)
Claudio D. Gasparini [Sat, 23 Jan 2016 11:45:09 +0000 (12:45 +0100)]
BUG-5076: OffSetMap reworked
OffSetMap reworked, removed previously introduced ArrayList
Change-Id: Id429fda477c8a038c1d64ec103b62e625637c1fd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 19 Jan 2016 12:58:57 +0000 (13:58 +0100)]
BUG-4835: Routes no withdrawn when the same prefixes annonced.
Routes not withdrawn when eBGP peers are disconnected and
the same prefixes annonced
Fix by shrink OFFSET
Change-Id: I7756c677b34372f5e0c19aefdd14bca74a226d78
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Tue, 12 Jan 2016 12:25:53 +0000 (13:25 +0100)]
BUG-4714 : No routes from loc-rib are advertised
When new peer connects, already existent routes on EffectiveRibIn
Table are not advertised and stored on corresponding AdjRibOut
Peer table. Therefore AdjRiboutListener doesnt advertise
these routes.
Fix by apply routes, when supported tables are created.
Change-Id: Id263723ee685bbc61468e1ea532f0f57f1c6c6c7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Wed, 20 Jan 2016 12:01:23 +0000 (13:01 +0100)]
BUG-4689: Advertising performance fix II
When AdjRibOutListener get a notification with too many changes,
it can fill output buffer with wrtitten Update messages,
without a chance to flush a socket, because the AdjRibOutListener
is blocked when channel is not writable - deadlock situation until a
savior (KA message) will not be send.
Flushing with every write operation is uneffective, hence try to call
the "flush" in a situation when the channel become unwritable.
Change-Id: Ie50b9154d1166d55308c3438c12b9c1b9d3ce19f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
095c87da7d565dac2cffa11710e7dd0e4a67c20f)
Milos Fabian [Thu, 21 Jan 2016 16:54:33 +0000 (17:54 +0100)]
Bug 5048 - Unable to deploy multiple RIB instances
When creating a new RIB instances do not override top-level
parent node common for all instances. To make sure the
node exists, merge an empty structure of parent node.
Change-Id: Ide9c9a726e078deca4ec5ad6fd06d4d3868f9706
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Sun, 10 Jan 2016 12:38:32 +0000 (13:38 +0100)]
BUG-4939: Remove BGP Peer structure from DS once session is close
When session is close remove whole Peer Structure from DS,
and create it again on Session up.
Change-Id: I7796983a98d8378b7fa80c61a9bed55bf46c836f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Mon, 11 Jan 2016 14:07:21 +0000 (15:07 +0100)]
Bug 4836 - tunnel's paths are not removed from ODL after tunnel status "Down" is reported
In a case when PCC reports tunnel has been shutdowned, but not removed
(LSP-ID=0, remove=false), ODL PCE should remove all previously reported
paths related to the tunnel as there are no paths signaled anymore.
Also, in this case PCC will not send report/s with explicit removal
of those paths.
Change-Id: I7b2c34431b094b27ac1fc55c2a75312e00868532
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Tue, 12 Jan 2016 11:45:51 +0000 (12:45 +0100)]
BUG-4962:LocRibWriter shouldn't announce routes to Application Peer
Fix by skip the step when Peer is Internal Role
Change-Id: I8c7932e9cc092d583c3db7b2ee03d38323499b73
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Wed, 30 Dec 2015 15:32:16 +0000 (16:32 +0100)]
BUG-4867: AdjRibOutListener still listening changes after peer Session closed
Once Peer session is closed. Listener needs to be removed.
Change-Id: Ie3575bdd42e9b0924e48f110652d0c595b42804c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Tue, 12 Jan 2016 12:28:17 +0000 (13:28 +0100)]
BUG-4834: resolve values for new best path state
Change-Id: I44c606aa4998a3e3a898d55e87c2f1978cf596dd
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
(cherry picked from commit
51d0511de6072c8dcbff826a1e4a2991cbb164bd)
Milos Fabian [Thu, 17 Dec 2015 15:07:53 +0000 (16:07 +0100)]
BUG-4729: PCEP RP object priority can be set 0
Fix RP object priority parser - if priority is 0,
priority is not present.
Change-Id: I86a9ffb652763524440e9f1599b468bbf27704db
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
f99afaf67519307317cea17ce500cdee99a1b416)
Milos Fabian [Mon, 14 Dec 2015 10:31:35 +0000 (11:31 +0100)]
BUG-4689: Advertising performance fix
The TCP channel become unwritable too fast and too often,
hence use high & low write watermark option for channel.
Change-Id: Icd52f164153dde94cd7c61a0c38f805a5c0593cf
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 26 Nov 2015 09:36:48 +0000 (10:36 +0100)]
BUG-4679: NPE in IPv4 prefix withdrawn Update msg serialization
When building Update message for withdrawing routes, check if
Multi-protocol is supported for this type of route.
If not, pack withdrawing routes as per RFC4271.
Change-Id: Ia9a36add74dd817bf0a460cfeaa5281f9b2fb50a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 26 Nov 2015 11:10:56 +0000 (12:10 +0100)]
BUG-3919: Support for non-MP advertisement
Add a support for old-school BGP-4 advertising,
if peer do not advertise IPv4-Unicast MP capability.
Revert changes in IPv4RIBSupport class.
Change-Id: I0f3a4c767f4f7048e4867ec3aab6c2b8dac6c008
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 2 Jul 2015 14:14:52 +0000 (16:14 +0200)]
Bug-3919: Advertisement is always done using MP_REACH
Fix Check whenever Tablekey is empty do not advertise using MP_REACH
Change-Id: Ia77e8fbdf841c61b82e85965001ef0f1a183e369
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Thanh Ha [Thu, 3 Dec 2015 21:38:46 +0000 (16:38 -0500)]
Bumping versions by 0.0.1 for next dev cycle
Change-Id: I07a347a4f4f7606465e9ac958c4a0d710a8a0684
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Thu, 3 Dec 2015 21:38:43 +0000 (16:38 -0500)]
Release Lithium-SR3
Change-Id: I5d3a41b5e97713751c6325233618d8d6541d36ce
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Claudio D. Gasparini [Mon, 16 Nov 2015 11:30:36 +0000 (12:30 +0100)]
BUG-4634: Prefix in withdrawn list is not ignored when announced in same msgUpd.
An UPDATE message SHOULD NOT include the same address prefix in the
WITHDRAWN ROUTES and Network Layer Reachability Information fields.
However, a BGP speaker MUST be able to process UPDATE messages in
this form. A BGP speaker SHOULD treat an UPDATE message of this form
as though the WITHDRAWN ROUTES do not contain the address prefix.
Fix by ingore common NLRI on withdrawn router
Change-Id: Ic9ebd3ce13f042f0dfcd2b28815442f8484add16
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 16 Nov 2015 08:25:05 +0000 (09:25 +0100)]
BUG-4622: Sending Empty Optional Attributes
Some of the parsers of Optional Attributes
only take in account the possibility of null
attribute and not of an empty one.
Fix by check it and dont parse them in case of
empty or null.
Change-Id: I34848ae9adff9687d2a64d7b016808fd50329010
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Mon, 9 Nov 2015 11:12:28 +0000 (12:12 +0100)]
BUG-4593: BGP peer registry lookup false negative result
Added method into Ipv6Utill for creating Ipv6Address with uncompressed value.
Used when registring and deleting peer address.
Change-Id: Ifa96a3ec2f9f7cc3ee60329e888590647af40f64
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Thu, 5 Nov 2015 14:21:32 +0000 (15:21 +0100)]
BUG-3771: Use sync on FutureChannels intead of await
"Await" waits until future has finished and throw execution
if thread was interrupted. "Sync"" instead waits for this
future until it is done, and re throws the cause of
the failure if this future failed.
When closing the module, first we ensure that channel
has been closed and if it didn't fail we proceed
with next closures.
Change-Id: I2d1d6c8c82c3fb27205ee2272fbc559c255da0bd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Thu, 5 Nov 2015 13:14:39 +0000 (14:14 +0100)]
BUG-3771: BGPCEP MD5 Password Fix
BGPCEP MD5 Password Fix Password were checked in case
if null but not in case of empty. Fix by creating an
Optional from password where in case of null
or empty will be absent.
Change-Id: Iece0520d0f8e6ddfeca37b9d877a7cabaf1721f2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 9 Nov 2015 11:07:28 +0000 (12:07 +0100)]
BUG-4594: ISIS PseudoNode NPE
NPE caused beacuse of wrong container.
Fix by: add missing is-is-router Container
which contains ISO System ID. Affecting
isis-node-case and isis-pseudonode-case.
Change-Id: I256c36ea980326bd39db4e8189ef092e20491c54
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit
8f4418f8044cabd046ddd440ae0180cfe690780a)
Claudio D. Gasparini [Tue, 3 Nov 2015 06:36:45 +0000 (07:36 +0100)]
Remove duplicate class
Remove duplicate and unnecesaries classes
Change-Id: I5835cb41ef3dfd881478b5ed93930c9cc87cf066
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Fri, 6 Nov 2015 07:52:05 +0000 (08:52 +0100)]
Bug-4568: Extended communities are serialized twice
Avoid serializing an empty (only header, no value) extended communities.
Better resolution is needed for Be - Extended communities registry will
be introduced.
Change-Id: I0ed8ba1bd29f9c22f40885664527ad861e73d7e8
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Thu, 5 Nov 2015 14:24:56 +0000 (15:24 +0100)]
BUG-4581: Fix BGP-FS extended communities serializer
Fixed instanceof checks - evaulating agianst wrong "case" types, that
caused FS extended communities are not serialized.
In reality, FS extended communities are comming from RIB's "route"
to serializer.
Splitted serializer test as a consequence of the change.
Change-Id: I50ea892096f0d4ba00107a813097ad8f9cf03897
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 26 Oct 2015 09:26:35 +0000 (10:26 +0100)]
BGP Logs improvement
Logs in LocRibWriter and EffectiveRibInWriter were not
providing useful information, therefore they are mnodified.
Change-Id: I3ee623d287debf33a12c704b031c11d5fe0f5bad
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 12 Oct 2015 12:26:58 +0000 (14:26 +0200)]
BUG-4438: When delete a route from the app RIB transaction chain brokes
When deleting routes from app RIB, transaction get broken, therefore
some routes keep stored in DS.
Fix by indentify type of modification applied under
routes in ApplicatioPeer and apply correct write transaction
instead of use 'put' with any of them.
Change-Id: I6141cfcbe53cc1ade0d309b09a269808ac07387f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Fri, 9 Oct 2015 13:34:30 +0000 (15:34 +0200)]
BUG-4364: data change counter transaction chain
to avoid logging spam
Change-Id: Ia59091f71edfb69d0fd3860086634112c4de0226
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Tue, 6 Oct 2015 09:19:43 +0000 (11:19 +0200)]
BUG 4409: Routes to be withdrawn ignored.
Routes to be withdrawn ignored when UPDATE contains both
WITHDRAWN ROUTES and NLRI fields. RFC4271 specify that
an UPDATE message MAY simultaneously advertise a feasible route and
withdraw multiple unfeasible routes from service.
Change-Id: I77c810ed7ddb1eda55021ddd05414198f66ec7ec
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit
e5fbd2135b3f361d5383ed6f15aca6b1206ee715)
Thanh Ha [Thu, 8 Oct 2015 15:55:48 +0000 (11:55 -0400)]
Bumping versions by 0.0.1 after the Lithium SR2 release
Change-Id: I839b025088d80084361da3c26755616cccba0cbb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Thu, 8 Oct 2015 15:55:45 +0000 (11:55 -0400)]
Applying the Lithium SR2 release patch
Change-Id: I5757e04234fa50d59472494d6b2a666b0c67622f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Milos Fabian [Tue, 6 Oct 2015 07:36:50 +0000 (09:36 +0200)]
BUG-4415: ISIS Area ID might have variable length
-fixed encoder to fit ISO NET Address ID pattern
Change-Id: I7f8a9311c3437c27e49751a1cd872d4efd687e78
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Mon, 5 Oct 2015 19:00:43 +0000 (21:00 +0200)]
BUG-4415: fix ISIS area Identifer encoding
-area identifier might have a length == 1,
this case was not treated properly
Change-Id: I0831871876121f75adc7f5860ba9e2e688f537ed
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Mon, 5 Oct 2015 12:55:42 +0000 (14:55 +0200)]
BUG 4413: Unit test "BGPDispatcherImplTest.testCreateClient" fails
When testing reconnectClient, cometimes fails because port still not
free from previous test. As we are using NeverReconnectStrategy, after
the first attemp to stablish connection fails, it throws throwable.
Instead we config the Socket to be able to be reused.
Change-Id: I8b79275c50205a2c7a92f1349c8dd80f6d5bcd2b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Thu, 1 Oct 2015 11:11:57 +0000 (13:11 +0200)]
BUG-4381: flowspec next_hop length
zero-length of next_hop in mp_reach made acceptable.
Change-Id: I810668bbb4e104367a305a0b4d2693b6238288da
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Milos Fabian [Mon, 28 Sep 2015 11:01:26 +0000 (13:01 +0200)]
BUG-4182: The "net" IS-IS node attribute is not filled by BGP-LS topo provider
In a case of link-state IS-IS node attribute, the area-id attribute is not
exported in IS-IS topology. Fix BGP-LS topology provider to fill in this attribute
as a "net" (iso-net-id).
Change-Id: I29dfc43590630a80eabad6433ef4a2f4371008b4
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Claudio D. Gasparini [Thu, 17 Sep 2015 12:06:58 +0000 (14:06 +0200)]
BUG-4070: Define new specific Peer role for App Peer.
Currently App Peer is defined a iBGP, therefore it doesnt
advertise to iBGP peers. Setting it as an RR, means that
it will advertise ORIGINATOR_ID and CLUSTER_ID, which
is undesirable.
Instead we create a new role for App Peer, INTERNAL.
Which will act as an RR-client but without advertise
undesirable fields ORIGINATOR_ID and CLUSTER_ID.
Change-Id: I1385158806838623824773c3031556fefa2a0262
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Milos Fabian [Tue, 22 Sep 2015 22:25:50 +0000 (00:25 +0200)]
BUG4066 & BUG-4173: BGP flowspec bugfixing
Fixed nodes extraction in FSNlriParser.
Fixed model for extended communities and augmentation of bgp-rib route.
Corrected and simplified RIB support destination processing.
Unit test correction.
Change-Id: Ia4b073d9147b105bd8c204ff0ffb1bbf3d9dd166
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
Claudio D. Gasparini [Fri, 25 Sep 2015 09:10:11 +0000 (11:10 +0200)]
BUG 4181: Fix PCEP Parsers/Serializers
Objects with more than one Ctype are not serialized
correctly.
This required update pcep-types.yang model, and register correctly
parser/serializers for:
-PathKEy Object /subobject
-EndPoint Object
Change-Id: I4518830b606a644a5673568e33f362f30958a51a
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Claudio D. Gasparini [Mon, 17 Aug 2015 14:37:33 +0000 (16:37 +0200)]
BUG 4138: Fix RROLabelSubobjectParser
Change-Id: I647c5b980d16a03ca010b5d632b5bea8414ff0e5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit
9dc94679b68d2ecdb98f69efa4dac24cf8de3b8e)
Claudio D. Gasparini [Mon, 17 Aug 2015 14:29:43 +0000 (16:29 +0200)]
BUG 4137: Fix XRO SRLG Parser
Change-Id: I3944b01c179c6b6c46aab1e140c50b41e67ef5fb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit
79741bf297c4ecc4a87d3dc23741b4a21f7b9caa)
Thanh Ha [Sat, 22 Aug 2015 22:01:40 +0000 (18:01 -0400)]
Bumping versions by 0.0.1 after the Lithium SR1 release
Change-Id: I3078dba43316d2162a90e579d9203505e7227418
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 22 Aug 2015 22:01:35 +0000 (18:01 -0400)]
Applying the Lithium SR1 release patch
Change-Id: I1225902ee0ad15bbf0eb726bef43ce00cabeb6c2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Milos Fabian [Thu, 13 Aug 2015 08:49:52 +0000 (10:49 +0200)]
Fix ipv6 prefix serializer
-java's genuine string to byte parser is limited to value of 127 max
-use unsigned string to byte parser to able to handle 128 prefix
Change-Id: Iacbb47fc90286e74c01737735f4b78f4d5c89c64
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
92bd1c44c83b9b2c3976bd153386461e4c23ce11)
Iveta Halanova [Fri, 31 Jul 2015 09:03:27 +0000 (11:03 +0200)]
BUG-4071: Cluster value fix
Change-Id: I99c488fb2416480bfd518f5f59d0abe1eb359d1b
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry-picked from
d1ca3ef123903a28d89cce7fc3dcb918b662ded7)
Dana Kutenicsova [Wed, 22 Jul 2015 12:56:46 +0000 (14:56 +0200)]
BUG-3888 : fix comparing ASnumbers
In order to allow BGP connection, expected remote AS (configured in ODL)
needs to match AS number received in peer Open message. Added expected
remote AS to BGP Session Preferences to allow for this comparison.
Moved validate method from client validator to registry that is used
anytime a peer connects.
This commit is intended to be cherry-picked. Refactoring commit
will be followed up in master branch.
Change-Id: Ie8bfd8b51ee7654b284fe0b0d4ce1db5e365d55b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit
d99e924ff10bb7652ef12e7989540b9ffecb2dd3)
Iveta Halanova [Fri, 17 Jul 2015 06:31:03 +0000 (08:31 +0200)]
PCEP LSP obj parser: missing PathBindingTlv serialization
Change-Id: Ife794f9d485cdffc2dc8c1efb9d5e77ccc2c170e
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry picked from commit
1b419d4af6e7bf477eee3b90e11715800f099309)
Iveta Halanova [Wed, 17 Jun 2015 05:26:38 +0000 (07:26 +0200)]
Unit test for Ipv4NlriParser
created Ipv4NlriParserTest
correction of:
- check of nlri instance type
- serialize nlri in <length, prefix> order
Change-Id: I00c06b352aabe4eb94a492c737377ec1efefec99
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherrypicked from
fe956c3355f88b3b4a12ae512ac45d00777e3abf)
Milos Fabian [Tue, 14 Jul 2015 10:17:16 +0000 (12:17 +0200)]
Bug-3780: Fixed 41-bgp-example init config file
bgp-peer was refering to incorrect bgp-rib service type
Change-Id: I5b5dfc94bc073677e9fe4c7fe495cff573b1a2b0
Signed-off-by: Milos Fabian <milfabia@cisco.com>
(cherry picked from commit
740ff1b91e4a51ae25d6dfac174da56d0a61c1d6)
Iveta Halanova [Mon, 13 Jul 2015 07:23:22 +0000 (09:23 +0200)]
BestPathSelector bug fix
expanded unit test BestPathSelectorTest and corrected BestPathSelector code.
Change-Id: I0591e7c7dbe455c852faed677b80694ef0dd9e63
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry picked from commit
a0d205695aedf2d1a2865c0f37824444a35fdc85)
Claudio D. Gasparini [Mon, 13 Jul 2015 07:09:39 +0000 (09:09 +0200)]
Bug: Fix missing break
Change-Id: If67090fbbff9baa160d58df5d9ccbb4884670853
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
(cherry picked from commit
1ade1a3de439f0deb216000f069dc68e31eac121)
Iveta Halanova [Fri, 3 Jul 2015 13:04:37 +0000 (15:04 +0200)]
Fix LS AdjSegmentID
Added parsering/serializing of type and length of (Lan)AdjacencySegmentIdentifier
Change-Id: I7fff827568618566e934c3d2e97391738657ccf9
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Dana Kutenicsova [Mon, 6 Jul 2015 08:34:46 +0000 (10:34 +0200)]
Fixed unit tests after yangtools change.
Commit in yangtools master: https://git.opendaylight.org/gerrit/#/c/23673/
Commit in yangtools lithium: https://git.opendaylight.org/gerrit/#/c/23045/
Change-Id: Ifab39c3188e80e793ecf384d496d853809e940fb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit
9055004831d441068b97825a1f833e7cc74b1cf0)
Dana Kutenicsova [Tue, 30 Jun 2015 13:45:47 +0000 (15:45 +0200)]
BUG-3892 : specify LeafSet as ordered
When creating own ClusterId list it must be
ordered too.
Change-Id: I261f3757cd9ffafa6016d84f6238ce34aeedc69a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit
fa6ea8d54be0faabc6e046048291826247b74004)
Dana Kutenicsova [Mon, 29 Jun 2015 15:51:06 +0000 (17:51 +0200)]
BUG-3892 : added ordered-by user statement to clusterIds
Without this statement, LeafSet does not guarantee the order
of clusterIds. We need to maintain the order as our clusterId
needs to be first when advertising routes.
Change-Id: Ic5d7ca2fb514a31cffc958a8a69ee3f57e3d2636
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
(cherry picked from commit
76030203e1a77b98917dec2e567bb4c889e4c7d1)
Dana Kutenicsova [Thu, 25 Jun 2015 13:36:34 +0000 (15:36 +0200)]
BUG-3879 : Fixed NPE in OspfPseudonodes case.
OspfPseudonodes weren't properly extracted from BI to BA.
Change-Id: I30a6b163806af69c9c8efa77a5d9f208228d54fa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 23 Jun 2015 13:38:02 +0000 (15:38 +0200)]
BUG-3839 : fixed various minor bugs related to AS Path BPS
- fixed classcast from Long to String
- fixed wrong NodeIdentifier
- fixed wrong algorithm in BPS
Change-Id: I7d87534d4e027d62a13fca7da13af81cb5f89caa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 25 Jun 2015 11:07:13 +0000 (13:07 +0200)]
BUG-3860 : fixed config through RESTCONF
Not closing loc-rib caused many loc-ribs to be created
through config-pusher causing NodeModificationExceptions.
Change-Id: I9b168615875f02a40b120b13cc92e9d5bdcd42be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Mon, 22 Jun 2015 13:06:52 +0000 (15:06 +0200)]
BUG-3881 : Fix SrNodeAttributesParser + test
expanded tests by parsering serialized outputs
fixed seralization, parsering
Change-Id: I8382ab97d1b19791ba5395a69d1a9873be6cf8e5
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry picked from commit
407c044762084a6a4217c64d4116befdcf26391e)
Thanh Ha [Thu, 25 Jun 2015 18:33:25 +0000 (14:33 -0400)]
Bumping versions by 0.0.1 for next dev cycle
Change-Id: Ief2c36e1e912223fef6818e779fef8b29b0afa5d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 23 Jun 2015 01:47:13 +0000 (01:47 +0000)]
Release Lithium
Change-Id: I4deb5c009420780de94fd557c7fbf498765cf511
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Dana Kutenicsova [Mon, 15 Jun 2015 21:53:38 +0000 (23:53 +0200)]
BUG-3362 : improved tests for application peer
Change-Id: I7fd771d534b1950ff08b47e7126009d8d3afe768
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Claudio D. Gasparini [Wed, 17 Jun 2015 11:11:38 +0000 (13:11 +0200)]
BGPCEP Tests
PCEPExtensionProviderContextTest
LinkstateRIBSupportTest
FlowspecModuleTest
Change-Id: Ieec83b4dec1b010355a1001cf0f5adda4094c524
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Iveta Halanova [Wed, 17 Jun 2015 12:30:24 +0000 (14:30 +0200)]
Test - PCEPDispatcherImpl : customizeBootstrap method
Change-Id: Ifc2dab2ca522f53de81c31ffe0c3464ab065cef1
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry picked from commit
f884277347f0dab0ee7cf390969ca9695100de6f)
Dana Kutenicsova [Wed, 17 Jun 2015 18:29:00 +0000 (20:29 +0200)]
Get rid of BestPathState FIXMEs.
Created method to parse AsPath segments
from BI to BA.
Change-Id: Ibc49da3ddfb0ba5e1bb0a8da562c00e069df3923
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Milos Fabian [Wed, 17 Jun 2015 15:55:07 +0000 (17:55 +0200)]
Bug-2802: BGP Update message serialization bug
The next-hop value from MP reach attribute is not stored in AdjRibIn,
thus next-hop is missing in output Update message.
Copy next-hop value from MP reach to next hop attribute to keep it in DS.
Change-Id: I866af30ecc2cd0baa0ca1ca2f763dc03176ac009
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Wed, 17 Jun 2015 17:16:21 +0000 (19:16 +0200)]
Bug-2458: Update nagasena to 2.50.0
Change-Id: Icc23a8c9d8cb68eda8df4d63b44d815566a89483
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Robert Varga [Tue, 16 Jun 2015 18:51:35 +0000 (20:51 +0200)]
Do not use string concat in Preconditions
Precoditions use String.format(), so there is no need to use concat,
saving the happy path from doing some unneeded work.
Change-Id: I2ece566a3450cf0e1349d8685de5beeca39130c7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 17 Jun 2015 09:34:50 +0000 (11:34 +0200)]
Store registration info for AdjRibsOutListener.
Change-Id: Ic65fac8e1a1ec7b8e5eda4a2b5507bf7279b7a07
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 17 Jun 2015 08:38:47 +0000 (10:38 +0200)]
BUG-3768 : fixed AdjRibsOutWriter
Added peerId to list of arguments for this writer
and limited listening to AdjRibsOut only for that
particular peer.
Fixed switched arguments for creating Mp_Reach and Mp_Unreach.
Change-Id: If1f3c576395d68aa3c26d2e4fabd696a4bf14457
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 16 Jun 2015 18:37:58 +0000 (20:37 +0200)]
Do not force Long boxing
Traces show that we are performing a few boxing operations to
instantiate the BestPathSelector. As it turns out, we only need it for
equals(), so ditch that and use a primitive long.
Change-Id: Idb01a00685850907f2461eb97f8925c956765c7e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ladislav Borak [Mon, 15 Jun 2015 15:26:21 +0000 (17:26 +0200)]
Bug 3044 - Conversion from Flowspec BI -> BA
Added support to convert flowspec type in BI to the BA.
Change-Id: I780cab9e3a2fb6c8acc4fdab6572057d76f63432
Signed-off-by: Ladislav Borak <lborak@cisco.com>
(cherry picked from commit
272e19b7c8fd2b14509431a4a381c6e1de50d61f)
Claudio D. Gasparini [Mon, 15 Jun 2015 13:35:44 +0000 (15:35 +0200)]
BUG-3664 Fix NPE caused by null AbstractRouteEntry
When we tried to get effectiveAttributes from an AbstractRouteEntry
which is null will cause a NPE, since it doesnt contain any attribute.
Fix by check this case.
Change-Id: I311743a165373ee2da4bd4f73e2d468023e445ad
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Robert Varga [Mon, 15 Jun 2015 20:54:22 +0000 (22:54 +0200)]
BUG-3664: make sure the transaction is committed
Even in face of error, do not leave a transaction hanging, but rather
commit it with an error-level message logged beforehand.
Change-Id: I211caa7cae954d76e9a47021afcb466f8e7e6004
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 15 Jun 2015 09:04:03 +0000 (11:04 +0200)]
Bug-3204: If no LSP Identifiers TLV is present in PCRpt message updateLsp in DS throws exception
-handle report message including non-RSVP-TE payload and no LSP Identifier TLV
-in this case use PLSP-ID value as a path identifier in PCEP topology
Change-Id: If1f5716ce0dfaa635028bb4e956ea8595d7b3e34
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Iveta Halanova [Fri, 12 Jun 2015 11:43:05 +0000 (13:43 +0200)]
BUG-3419 : fix calling get() on Absent value
When BGP shuts down, LocRIB receives and uptodate
change with no data attached causing an Exception.
Fix this by checking existence of the data.
Change-Id: Ibe1aeb8e7f02136be2c83be516e47833c1d8146a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
(cherry-picked from
117ee238c19162335c50ef85114b05e87d50b538)
Claudio D. Gasparini [Thu, 11 Jun 2015 12:56:32 +0000 (14:56 +0200)]
BUG-3300 : Fixed BGP transitive attribute filtering
Namespace in AttributeOperation were hardcode therefore any transitive
attribute with different namespace(inet..) were not valid, reason why
FromExternalImportPolicy did not return any attribute, causing a NPE.
Fixed them by matching extension QName to corresponding Attribute.
Change-Id: Ic3ccf5eb0b1d181baaf8ea5b6dea6f84828b92a4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Robert Varga [Thu, 11 Jun 2015 18:24:27 +0000 (20:24 +0200)]
Cache IPv4/IPv6 nexthops
Next hop values are readily reused, so cache them to share instances.
Change-Id: Ib946a82d950c51644bea3cbc394d536e76663c6e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 11 Jun 2015 05:22:59 +0000 (07:22 +0200)]
Cache UnrecognizedAttributes
UnrecognizedAttributes is typically empty, so we can reuse it widely.
Change-Id: Ifff9a45335e6a0ffaf07db789e9d36394ff61301
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 10 Jun 2015 13:42:00 +0000 (15:42 +0200)]
BUG-3347 : fix receiving updates only on first route
This was due to calling clear before each write into AdjRibsOut.
Create tables in AdjRibsOut beforehand, so we don't have to take
care about it when a route comes.
Change-Id: I8679399a50b54d83d5432c7b75aadd9e1c7ea928
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Iveta Halanova [Thu, 11 Jun 2015 11:50:04 +0000 (13:50 +0200)]
BgpTableType: toString()
added toString method into BGPTableTypeImplModule $ AutoCloseableBgpTableType
changed toString in BgpTableTypeImpl
Change-Id: Ic6e619b6693f8f2d433ce47199e8772e0e9160d0
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Iveta Halanova [Tue, 9 Jun 2015 08:18:05 +0000 (10:18 +0200)]
BGP.parser.impl.messages: minor changes
KeepaliveMsgParser - made final
NotifyMsgParser:
- Log just-built ByteBuf
- Reordered line - getData()
OpenMsgParser - log just-built ByteBuf
UpdateMsgParser - made final
Change-Id: I09283ee4505dfa5f8c747d7bfc12fc6a701efa96
Signed-off-by: Iveta Halanova <iveta.halanova@pantheon.sk>
Robert Varga [Wed, 10 Jun 2015 18:23:25 +0000 (20:23 +0200)]
Remove LocRibWriter registration on close()
Retain the DataTreeChangeListenerRegistration we get when we subscribe
and cancel it when we are being shut down. Also place two FIXMEs for
future work.
Change-Id: I74364473736e863e63557e8ebf652424ea312a59
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 10 Jun 2015 08:17:11 +0000 (10:17 +0200)]
Fix duplicate NodeIdentifier instances
Memory dump has shown we have multitude of NodeIdentifiers pointing to
the prefix QName. This turns out to be the automatic completion of
missing key leaves. Fix the caller to set the leaf up correctly, thus
sharing the NodeIdentifier instance.
Change-Id: I5fb563a9048f4d48c2a2c5b96b8b9bfd08b867f6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 9 Jun 2015 23:38:42 +0000 (01:38 +0200)]
Lower tracing overhead
Arrays.toString() and ByteBufUtil.hexDump() are expensive relative to an
disabled trace call. Guard the corresponding trace() calls with
LOG.isTraceEnabled(). Discovered in BGP performance traces to have some
4% overhead.
Change-Id: I94ce9b57b86bae9be35e5839447a19b268064469
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 9 Jun 2015 20:30:19 +0000 (22:30 +0200)]
Fix confusing peer AS message
We printed the expected number in place of what the peer sent and vice
versa, confusing users. Fix that.
Change-Id: I874a25598818e58f4a05a10a977724b0cc853140
Signed-off-by: Robert Varga <rovarga@cisco.com>
Vratko Polak [Thu, 4 Jun 2015 16:28:10 +0000 (18:28 +0200)]
BGPServerSessionNegotiator: Use the correct AS number
Before: toLong() on 2-octet value could result in AS_TRANS.
After: AsNumberUtil.advertizedAsNumber gives the correct 4-octet value.
Change-Id: I46b2a4baa25029b872e9b52c98823ee2b7f956bf
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Dana Kutenicsova [Tue, 9 Jun 2015 09:33:46 +0000 (11:33 +0200)]
Fix delete case in EffRibIn.
Delete case was pushed with wrong InstanceIdentifier.
Change-Id: I3e57f5f0b7915bcd290d4b2e851bbb388a092eb4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Ladislav Borak [Fri, 5 Jun 2015 12:35:45 +0000 (14:35 +0200)]
Bug 3577 - Message decoder fails to decode "all IP addresses match this update"
Added support to parse and serialize "default route" prefix in Ipv4Util and Ipv6Util.
Change-Id: Ibd84cad5864beb71112f72ac727ff7a65079efcf
Signed-off-by: Ladislav Borak <lborak@cisco.com>
(cherry picked from commit
a277e11606404e307ca037f32e612813ce7a3a51)