Release Nitrogen

BUG-9141: Fix Stateful07TopologySessionListener failing test

Some of the timers are rounding down, which is ending
on some statistics results in 0, when we have better
performance than expected.  Update the code to round up.

Use LongAdder instead of long for counters

Change-Id: I958f1c252ba94f8cd392979fe469555aee3f8d48
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8987: check for null keys

Keys can be passed down as null, hence we need to check for this
happening.

Change-Id: I67018107b0925244f32b0cde6d8b53605594d521
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 9046: Bring back data change counter feature

Tests which rely on data change counter do not work without this.

Change-Id: I0a82674c50887f7282cc6ed7a6a54573da73d637
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Update .gitreview to stable/nitrogen

Change-Id: Ic2b3fe3765b9e57e5751fd77d6ca5f12176fdb44
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump odlparent 2.0.2 to 2.0.4

Change-Id: Ieee18f9e069a0d9eb6ca8cc9e12237654d958105
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-8335: Adjust instantiation

The hanging issue stems from the use of a blocking dispatch for DTCL,
which means we are calling into user code while holding listener
registration lock. This does not happen in production environment.

This patch adds an explicit test for this scenario and migrates
the hanging test to call properly initialize its base class.

Also cleans up warnings in the implementation, as it has not seen much
love lately.

Change-Id: I6c424acfad87244c7a23b013ea91da543ecf72a8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up

- Migrate Futures.addCallback
- Move test to shorter package

Change-Id: I7c5f8f9743cd7220414d68d043ca912261edec4d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Cleanup eclipse warnings

- static methods
- deprecated classes
- raw types
- unneded version declarations

Change-Id: Ibfe2f1f3203ebca416d8badd1f149d669ddc2415
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enforce no split packages

This patch augments Export-Packages with a directive to fail build
if a split package is detected.

Change-Id: I52a2a157f992cb97fd8c6a88cf45c933ed0fd953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8722: fix regression introduced by BUG-5876

Change I707914f3ab0786c0ad8ba71a5476b3b7e322b0cd regressed
bgp-rib-impl packaging such that it massively over-included
classes, leading to split package.

This patch fixes that regression.

Change-Id: I6366972b88e3881675c3dd70517fc4e95c050261
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Re add features-bgpcep-extra to integration test

Change-Id: Ic61d66e420f5281dbde1a836b5adbc1ba78be777
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated CSS Topology provider configuration

replaced by openconfig configuration

Change-Id: I569f75217302e3867a2106065ca9936981a4a126
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6978: Integrate BMP collector with Cluster Singleton Service

Implement bmp HA by introducing CSS to BmpMonitoringStation

Change-Id: I657c367c33fc6b1946c3db19a71725a78917925a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug 8675: Follow-up fix to new XML parser change in yangtools

Behaviour of the new XML parser in yangtools project needs
to be changed a bit so that RESTCONF/NETCONF projects can be
migrated to the new parser. However, these changes break some
parts of BGPCEP which have already been using it.

This patch provides a fix for the issue and should be merged
right after the following yangtools patch goes in:
https://git.opendaylight.org/gerrit/#/c/59036/

Change-Id: I23a5677e31b01fee7f67c8a5eb6b4081bd976f8b
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>

Move tests to base package

Test FQCN is used by surefire to generate a report file, which has
limits on its length, causing problems with archival.

Move these tests to base model package to keep the file name short.

Change-Id: I90a49004c235590c87cb331e7cd31f693b3cd6d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 2.0.2

Automated bump to latest release.

Change-Id: Ib8ecc4751f93c75f93262fa42d43566b0d6094d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug 8667 - PCEP: When peer closes got IO exception

When peer closes the pcep session, it results on IO
Exception.
it is due to this close is not recognized as local pcep
PCEP session termination.
It was first implemented as a local pcep session
termination.
https://git.opendaylight.org/gerrit/#/c/906/1/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionImpl.java
Solution: Use the reason encapsulated in the close message to close the session.

Change-Id: Ia423f5c10b117ef21af5a3bddc28652ebb659e26
Signed-off-by: matcauf <mcauffiez@inocybe.ca>

Remove missing dependency features-extras

This appears to have been removed via
I6db5b40c398fbe5e7cb4077d2c2a321a0286fab0

Change-Id: I161964a0ed1d7e52a8a5d6a7dd28f771de2b29b2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-7027 : Remove Data change counter CSS configuration

since is not longer need it. New configuration is done via REST.

Change-Id: I32c3ffcfa66108d72dd8033e44b1cbd7596537eb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump odlparent dependency to 2.0.1

Change-Id: Ic2c34fb71552aeb6365ce37374c73f0bb909e14a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump odlparent dependency to 2.0.0

also rename karaf4 features

Change-Id: I4d9d9274d12e4bb098884d70827d7ed57e8d7b48
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove BGPCEP Karaf 3 features

Change-Id: I6db5b40c398fbe5e7cb4077d2c2a321a0286fab0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove no longer required 31-bgp.xml for bgp feature

CSS configuration is not longer supported under nitrogen.
Therefore 31-bgp.xml is no longer required for bgp feature.

Change-Id: I43aa0a52d919a03e90133a2f908505941285773a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6976: Migrate BMP collector to use BP wiring

Migrate to BP wiring

Change-Id: I6d7d33029123039d27493b014ae459da1333a77c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

KeyMapping rework

Change-Id: I76a1a1c0353219d453963422b64cd7bcf86bb523
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6801: Remove deprecated bgpcep *-all features

Remove deprecated bgpcep *-all features

Change-Id: Ib87ea2d091e2eead955b8cf959a02f071365a7f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove stale prerequisite sections

It is generally accepted that ODL requires maven 3.3.9+ in order to
compile correctly.  This cleans up a bunch of places that reference
older minimum versions to avoid confusion.  Instead, we should
recommend that all modules are compiled using the ODL global minimum
in order to promote a common toolset across the project.

Change-Id: I61591cfbd262e712bdd428e8b6697f7c0742dbde
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Migrate bgpcep local karaf distribution to karaf4

This change migrates the local karaf distribution from karaf 3 to
karaf 4.

Change-Id: Iabf8a96ecec5e3473eae55e6a1ca8f70856bc60c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Reduce over-inclusion of base BGPCEP artifacts

We have some duplication across concepts/utils, use the extras
dependencies feature to bring those in for now.

Change-Id: I594a8a7d553ab17c992882eb117c7dc94a1a9ee3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BUG-8292 Fix BGP flowspec NLRI length read

In BGP Flowspec, NLRI length is set per NLRI. The
current implementation only read NLRI once. So
BGP parser will throw exception when multiple
NLRIs are batched in one BGP UPDATE message.

Change-Id: I6630bca4c222e68f4609134192550d6c0a7ea3ba
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 51646d108fc36adef7cffd99657386fd6f5f96bd)

Remove dependency on blueprint

There is no need to declare this, as far as I can tell.

Change-Id: I58e8cb0cefff8d05ab00319eb3cb6c9db3a22fa6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate to odlparent 1.9.0

Change-Id: Ie210d3177329d2bd94f590f06ecbcb5ed9877863
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix sonar complains

- Remove unused imports
- Remove unused exception
- Extract try block
- dont use generic Exception
- Reduce the number of conditional operators

Change-Id: I0d51ef2aa6540d1d841f637308431ce768b1636b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7027 : wired data-change-counter with Blueprint

Deprecate existing config modules,
add BP xml with custom config yang file.
No default configuration is set, to avoid
conflict modification when using on 3 node clustering.

Change-Id: I2b0408310605c9b96388585582d2e7a9f63007cb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Jira: RELENG-159
RT: 41406
Change-Id: I3e41a57a11b63902be1bce25f3a6937609eb1f1f
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 8568 - Remove deprecated CSS module tests

Remove Test class that are using deprecated DataProviderService
for Classes
BGPApplicationPeerModule
BGPPeerModule
RIBImplModule
Ipv4ReachabilityTopologyBuilderModule
Ipv6ReachabilityTopologyBuilderModule are deprecated and
will be not tested

Classes AddPathImplModule and BGPTableTypeImplModule are not
deprecated and will be not tested.
Do they need to be deprecated ?

Change-Id: I9b9d3125b6f80ee70c86451f8a46cbd480bde6c2
Signed-off-by: matthieu <mcauffiez@inocybe.com>

Rework failing test testStateful07TopologySessionListener

Change-Id: Id48d30e15351217a9738de742dec2d2581480d29
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated methods

Change-Id: I8d38181081702c692a4d093761b95d5a2dddeca2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Change deprecated SchemaService by DOMSchemaService

Change-Id: Iaa4adace5e15a1aeee2824cac81f8c72703a80fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Introduce dependecies version management

for handle version of ODL features in an
unique place.

Change-Id: Ifbf831a0fd387f548f58084c003ef6475f7b0a8d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8548: Pass missing parameter to

SimpleBGPExtensionProviderContext#registerNlriParser

Change-Id: I625f82d64efa0d2843b94de31c649572be9cacf9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Cleanup: unused var and imports

Remove unused logs, class member and
methods paramenters

Change-Id: I02640d49844d46726da8da9ae162507dc6c6e581
Signed-off-by: matcauf <mcauffiez@inocybe.ca>

Code cleanup: Duplicate Code

Remove duplicated code

Change-Id: I318e391e95bc892ebcf6af3081a455e84843c93a
Signed-off-by: matcauf <mcauffiez@inocybe.ca>

Remove unused LOG

Change-Id: I03d203e42e009ef737b07e05d56f2df5d650cded
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8156 Fix PCEP topology registration

It is possible that when a PCEP session is being dropped and being
unregistered from ServerSessionManager, the thread gets switched
thus the topology unregistering cannot finish.

If such situation happens, PCEP session from the same PCEP peer will
not be able to established until after DEADTIMER_EXPIRED, as the
topology instance was not removed correctly.

Change-Id: I647ecfbbb35ef6805d563753b7ebd87edfc350fe
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 2801f2b71ca49dcee50b643ef5ed4f53938609fc)

Fix RD pattern in RouteDistinguisherBuilder

Type 0 RD is 2+4 bytes.

Change-Id: I7ec0099cf5c1cdf8ab7d333dc26756c17228579b
Signed-off-by: Xiao Liang <shaw.leon@gmail.com>

migrate yangtools deprecated BindingNormalizedNodeSerializer

migrate yangtools deprecated BindingNormalizedNodeSerializer
to mdsal BindingNormalizedNodeSerializer

Change-Id: I32439a487a209a567b5436b204c11d979ac46cc8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8356: Rename features4-extras

Rename features4-extras which colides
with controller features4-extras, making
SingleFeatureTest for repos/index fail.

Change-Id: I04c693f853178e08a15eaa5435310659f66ee061
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8335: @Ignore InstructionDeployerImplTest

This test hangs fairly consistently in autorelease-carbon.

Change-Id: Idc6a207ff669f433096017494c24d99b8ec02c09
Signed-off-by: Colin Dixon <colin@colindixon.com>
(cherry picked from commit 5cca02bf6871cc9345baadcc282acfa76e0ff5de)

BUG-8306: Fix Pcep failing test

Given that messages takes differents time to arrive on listener
Fix  Stateful07TopologySessionListenerTest by
use checkEquals, which checks the assertion with timeout.

Change-Id: I13733fa7ad7686671d9c026a8528ad912e2c7cd5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix yang module file names

This patch fixes these two warnings:

2017-04-25 19:34:22,251 | INFO  | ... | Provided module name bgp-evpn.yang does not match actual text odl-bgp-evpn@2016-03-21.yang, corrected
2017-04-25 19:34:03,806 | INFO  | ... | Provided module name bgp-path-selection-mode.yang does not match actual text odl-bgp-path-selection-mode@2016-03-01.yang, corrected

We do not have to include the revision, as that mismatch leads
only to a debug.

Change-Id: I58dddf24128804a6151ac84369030d8e5f8fcac3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix karaf4 features

Features should be pulling in transitive dependencies from
the corresponding features. Fix that.

Change-Id: Ib758202ad0ff03e3a44b8a040dcc72f241c59920
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 86388150d7239e6430503752f312707bf63d07b6)

BUG-8275: Close ReadOnly transaction

PCEPStatefulPeerProposal needs to
close ReadOnlyTransaction created
after use it

Change-Id: I1515f09028c9e6bd8403d6ea2851196511d4da24
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit b85554f565b2e03d2c8237b160ac055907b86b23)

BUG-8202: Fix Conflict Modification on odl-programming

Instruction DS configuration only should be written
on Leader when instatiateService.

Change-Id: I9acf17c8a19d8b22d83e62b315fdadf9494783f2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8198: Fix InferenceException

Add presence statement under graceful-restart-capability.

Change-Id: Idc98f74661d4dea4f440d178da868ec83f896370
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 187428a5c597c78c625ca2b1baa1a920108a979f)

BUG-8252 Fix IP prefix length util

The byte representing IP prefix length is a unsigned byte.
The length should be converted to an unsigned int explicitly.

Change-Id: I0c1df171822858825da69f39c91de9ed332865f8
Signed-off-by: Kevin Wang <kevixw@gmail.com>

BUG-8213: Add missing mandatory attribute on tests

Add missing origin attribute on tests

Change-Id: I125437e187286a7a949e26191e66f19ded123274
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: I4d89069222217139eceba9eac78cefc1234c3304
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Improve synchronization under BMP

Improve synchronization under BMP whenever
transaction chain is created and submitted.

Change-Id: If7a61c394218bd7c78c6021ee19ba42f4276560a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Restrict dependencies scope to test

Restrict various dependencies scope to test

Change-Id: I23cef78c244454d2059311c0d56af753f695c02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-4491: Race condition under PCEP Topology Provider

Race condition under PCEP Topology Provider when
instace is reconfigured, since closeInstance under CSS
is nonbloking, it can race the delete with the writing
of the new instance when restarting.

Fix by calling first closeServiceInstance(blocking)
on topology instance and once it gets done call close.

Change-Id: If79bf34f77223bc56424a57e4e600fdb17ddd154
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-8021: Race between Peer structure creation and route init.

There is a possibility of race between Peer structure
creation and route initialization/advertizement.

Fix by introducing a flag, which indicates whether
peer's structure has been created and is able to be updated.

Change-Id: Ia9515d2017cb5213ce286e463712092c87764e10
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7976: Race between peer removal and routes update

There is a race condition when we are advertizing routes,
and a session peer goes down which will end in
removing the peer from DS.
Since advertizement and removal are done by 2 different tx,
we need to do it blocking mode, and not route should be
advertized until peer is removed and vice versa, peer
should not be removed until routes are advertized.
Otherwise toure update will try to update a peer/path which
is not longer present.
Fix by rework PeerExportGroup & ExportPolicyPeerTracker,
now instead of generate PeerExportGroup each time a peer
is reg/unreg,  we make PeerExportGroup work as a
blocking registry to solve previous issue.

Change-Id: I46a27871bfa2aa2a632e3bfb76061105c62bb6d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix sonar complains

- Remove unused imports
- Throw exception
- Name convention
- Comparison
- private constructor on util
- replace explicit type per <>
- migrate to java stream api

Change-Id: I224eb8dfe776130b0f45468be4791239daf878af
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix BmpDispatcherImplTest intermitent failure

-Use CheckUtil under test.
-Use mockito timeout.

Change-Id: I2e6c77de1324dc079375271bd7c2e2d028a9fc4f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975: Integrate Topology Provider with CS Service

Integrate Topology Provider with CS Service

Change-Id: I0e9c42aa3538e0936b74120535fee369db1ad9d5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement test for InstructionDeployer

Cover InstructionDeployer with test

Change-Id: I8ed071a8a11dd0d9183fe6c5b45ae7616f6ce5f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework CheckUtil Test

Change-Id: Icada2980901bea076b061b933d8ba42876d0e5f5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Correct XSD pattern

YANG patterns are XSD regexes, so they have implicit ^/$
anchors. Fix this up.

Change-Id: I911ca3d3bd286c0f77bccfb4f3e9a3ef8fc8dbdb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean Up

Classes missing final

Change-Id: Ie260d9f4a48290b492171f79f94f7f8ee53ccbde
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Clean Up

Fix instance fields not accessed with this

Change-Id: Iec1520fa728ea21098dd5a79dbfa25837b117e1c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code Clean Up

Anonymous type replaced by lambda

Change-Id: Idd81b1e43866e5d960ec2dfa777b66bae3e53da9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire topology-provider with BP

-Wire topology-provider with BP
-Preserve backwards compatibility

Change-Id: Ibc459117b1656a0efe5e34365b9fc131479bdaea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7960: Fix AssertionError under AppPeerBenchmarkTest

Use CheckUtil.readData for check DS update.

Change-Id: Iae77923c4b8fe0e3a87ffeff0b5c4d00815bf88d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Code clean up

Remove unnecesaries imports

Change-Id: I0ecf1894c1be211f9ffd7ed0d98a3c80ae9a6025
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7964: IllegalStateException under testReconectClient test

Fix by wait until channel is closed before retry to connect.

Change-Id: If1c7889b7988ce5cab3e11f73b6134ad2af182c7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 7b48d57ba01775ff48b1686ea8093b009df2ee3c)

Fix NPE under TopologyProviderTest test

Fix by check reportedLsps is not null.

Change-Id: I18878db061ab5816ac5f13e5cdac21107df86aa1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest

Remove deprecated class AbstractDataBrokerTest under
programming and data-change-counter tests
Perform some code clean up

Change-Id: I2ff02760338d8774c3908d107ff76de433acba2a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7946: Fix  SomeModifiersUnresolvedException

SomeModifiersUnresolvedException under ConfigLoaderImplTest
Fix by remove duplicated schema.

Change-Id: I1200e21e76e6da0d35a10932eede27df4a410aa0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7894: Fix ConcurrentModificationException under test

-Fix ConcurrentModificationException under
testSessionTriggeredFullDBReSync test
-Perform some code clean up

Change-Id: I8e4652f273ea994efa5b9477f8af59239e92dd08
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove pcep-service.yang.disabled

Remove pcep-service.yang.disabled

Change-Id: Ib862326a5cd976c6cc9fb714892c8064915a3cfb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest under BGP

Remove deprecated class AbstractDataBrokerTest on tests.
Perform some code clean up under tests.

Change-Id: I64b120bdbbf59db4df0e4d4e2d769eac22738c33
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7937: Fix BGPTerminationReason

When closing the session because of some error
2 Notify messages are sent. One containing the
reason and other with CEASE.
Fix by dont send CEASE Termination Notification
if already other termination notification has
been sent.

Change-Id: Ibfabd7cfb038bef7a452a7458cd5cc1e6fa4b9a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7003: Remove sleeping from Tests

Remove sleeping from test whenever possible.
Clean up some tests.

Change-Id: I734ca5721090669c75f09d107ee4c5ea1e3d14ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7505: Conflict Modification

When closing Peer and Rib, can cause
race condition between the removal
of the peer and the rib when updating DS.
Fix by close peers on blocking mode, and once
they are closed proceed with rib.
Same its applied in case that peer/rib is updated.
First we close it and then once DS is updated
we proceed with creating the new instance.

Change-Id: Ibe70e0324ae12bcbb88b2e7f039671141447ddb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove deprecated class AbstractDataBrokerTest under PCEP

-Remove deprecated class AbstractDataBrokerTest on tests.
-Perform some code clean up under tests.

Change-Id: Iee8bdb1e190c80aa0ae883e52963afb6b29cc4f0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Programming Clean up

Migrate deprecated classes
Code clean up

Change-Id: I06551491a30499d81d4c0dc7f0e1dbe68dc04eab
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6975:  Integrate Programming with Cluster Singleton Service

Integrate Programming with Cluster Singleton Service

Change-Id: I95e3c8c1dc1e596c060256d3f59fec9cfe882456
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Implement Programming config via DS

-Expose programming's configuration in config DS
-Allow multiple programming configuration

Change-Id: Ib6de3355dae6533367890ef87c504edbdca04654
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-6973: Wire Programming with BP

-Wire Programming with BP
-Preserve backwards compatibility

Change-Id: I750fdb86a6c22d3b1a90e7466466ab7c5426d729
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug 6859 - Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:
org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

Refactoring changes in MDSAL, see:
https://git.opendaylight.org/gerrit/#/c/52107

By using of Binding generator v1, this change needs to be addressed in
Bgpcep project.

- refactoring itself

Change-Id: Iccb2af9806db18a3e5bf98092ca70ae9b350dabf
Signed-off-by: Jakub Toth <jatoth@cisco.com>

Improve Singleton Service Logs

Improve Singleton Service Logs

Change-Id: Ie09d2e00e7159539dcecc520ef0e9cd39ca4e02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bug-7614: LocRibWriter does not recover well from transaction chain failure

If transaction chain associated with LocRibWriter fails, create a
new transaction chain and re-initialize it with the new chain.

Change-Id: Ibbb60c41594ad6b3602cabac18f5e4bccaa093bb
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7768 Fix missing registration

In previous BUG-7768 fix, pcep topology registration was
missing. This patch adds it back. It also adds several debug
logging and unit test.

Change-Id: I4c82a7fcd9cb1ed7371817ffabc52fdf927ab51e
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Add CheckUtil coverage

Add CheckUtil coverage

Change-Id: I90524766fa989c97ab2e10d7fbe08904e269770c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-7222: Make BGP DS clean up asynchronous

Close of the service must be done async, otherwise
will bock the thread.
Fix by make BGP DS clean up asynchronous

Change-Id: Icb19ef7b7f118fbc6b07407d1df2cb5f6cffc0fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Clean up check tests and  util tests

Remove duplicated code on check utils for tests.
Clean up PCC mock tests

Change-Id: I1347f6561cb4ede6c8f4147680d92c3a84f92520
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BUG-4808: remove reference to IdentityHashMap

Class documentation is misleading, as the internal cache is implemented
by a weak key/weak value equivalent.

Change-Id: Ie0d08ee990b725c5ed1a52cb074b6f72eff2a26f
Signed-off-by: Robert Varga <rovarga@cisco.com>

Code clean up

Remove redundant cast/type argument

Change-Id: I446cb24bdbcb5156136899798eb6d3d607291e62
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>