Release Oxygen

Bump yangtools to 2.0.6.1

Change-Id: I19fb142e8bfe0df457f93d88591af1a31b182012
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix invalid models

These models do not contain correct import stanzas and were resolved
accidentally via prefixes declared in modules thy are importing.

JIRA: YANGTOOLS-889
Change-Id: Ia94e3f78ed4a9aec8b55743b821373738b4e6c54
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 58d5468c187c63e93f7dc2cee09230bf0b8b2e62)

Fix invalid flowspec model

Augmenting the same choice with equally-named containers from
a single model is data tree namespace violation. Fix that.

Change-Id: Icb5f1580c23fd53365481c89111888566eb04747
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit d0aeb999f179d8468aaa77957db7b0fd76845caf)

Fix invalid rsvp model

Augmenting the same choice with equally-named containers from
a single model is data tree namespace violation. Fix that.

Change-Id: I36eea127a33ade8dec108042bd43dac12e97e64e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit c26582bfccc3fb6aca26ac5cbd3932e7a67ed532)

Bump to odlparent 3.1.3

Change-Id: I75aa83a8296da41e79fa6b0ca6c7166f15765921
Signed-off-by: Stephen Kitt <skitt@redhat.com>

fix timing issue in server creation for BmpMockTest

- add wait unitl server is created

Change-Id: Id217822e57be8c7df1139341af9ade2517dad516
JIRA: BGPCEP-815
Signed-off-by: Matej Perina <matej.perina@pantheon.tech>

Reduce use of waitFutureSuccess utility

Change-Id: I90e2cd1104ade35801a734ead26eeac2c90c0361
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework BmpMockDispatcherTest

- Use test timeout instead of waitFutureSuccess utility
- use blocking futures

JIRA: BGPCEP-814
Change-Id: I1471226c703779222ed27f11154d8557b0ab7a65
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 3bab01236ef38a758a96bdaf6a73482bb1840891)

Fix calculation and roll-over of BGP operational neighbor uptime value.

Change-Id: I6ba03074658b45c17ee440fa81158720531a2cef
JIRA: BGPCEP-813
Signed-off-by: Ajay Lele <ajayslele@gmail.com>

Improve handling for protocols config changes

Given the dependency of Peers of Rib.
When delete
 - remove first peers
 - then remove Rib
when modification
 - update rib
 - then update peers

JIRA: BGPCEP-799

Change-Id: I582398dab191842473f7cbbd1010b76fe9a9d9fd
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Inherit common extensions families dependencies

from extensions parent

Change-Id: Ic115f76bd184142d15e9b42f69f80dfd12fa375a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Create common parent for extensions families

Change-Id: I9aff6bb41e565df54fcbcfb660ac014b7547c334
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump to odlparent 3.1.1

JIRA: RELENG-129
Change-Id: I7d8ed367ac99c196fbfac58b1f591f903f4469f8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump versions by x.y.(z+1)

Change-Id: Ie1960106fa701398e6ccb5037875de77865cd313
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Use range to import yangtools features

This removes version-specific binding, allowing features to be
resolved against newer versions.

Change-Id: I62728a4aa1d3fd817c629bcd7057724b448379ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit e83fdd20a40831dfdbdbc21a6ba99611dbe51ab1)

Bump yangtools to 2.0.5

Latest fixes.

Change-Id: I16db310fab811486942b90778d5beefedfa1679d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix IllegalStateException in StateProviderImpl

If a transaction fails, the StateProviderImpl can get stuck in
a perpetual cycle of subsequent transactions failing due to:

java.lang.IllegalStateException: Previous transaction odl2-1-datastore-operational-fe-3-chn-44-txn-1-0 is not ready yet
        at org.opendaylight.controller.cluster.datastore.TransactionChainProxy$Allocated.checkReady(TransactionChainProxy.java:85)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.allocateWriteTransaction(TransactionChainProxy.java:187)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.datastore.TransactionChainProxy.newReadWriteTransaction(TransactionChainProxy.java:166)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.createTransaction(DOMBrokerReadWriteTransaction.java:52)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.databroker.DOMBrokerReadWriteTransaction.createTransaction(DOMBrokerReadWriteTransaction.java:22)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerTransaction.getSubtransaction(AbstractDOMBrokerTransaction.java:57)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.merge(AbstractDOMBrokerWriteTransaction.java:102)[315:org.opendaylight.controller.sal-distributed-datastore:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.md.sal.dom.spi.ForwardingDOMDataReadWriteTransaction.merge(ForwardingDOMDataReadWriteTransaction.java:54)[314:org.opendaylight.controller.sal-core-spi:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.md.sal.binding.impl.BindingDOMWriteTransactionAdapter.ensureParentsByMerge(BindingDOMWriteTransactionAdapter.java:67)[302:org.opendaylight.controller.sal-binding-broker-impl:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.controller.md.sal.binding.impl.AbstractWriteTransaction.put(AbstractWriteTransaction.java:41)[302:org.opendaylight.controller.sal-binding-broker-impl:1.6.0.ODL_7_0_0_0]
        at org.opendaylight.protocol.bgp.state.StateProviderImpl.storeOperationalState(StateProviderImpl.java:151)[252:org.opendaylight.bgpcep.bgp-openconfig-state:0.8.0.ODL_7_0_0_0]
        at org.opendaylight.protocol.bgp.state.StateProviderImpl.lambda$updateBGPStats$1(StateProviderImpl.java:124)[252:org.opendaylight.bgpcep.bgp-openconfig-state:0.8.0.ODL_7_0_0_0]

The root cause is due to attempitng to continue to use a failed
transaction chain. It should close the failed chain and create a new
on as is required by the API contract.

For the UT, I used the RememberingLogger from infrautils to indirectly
verify the tx chain is rest on failure by checking logged errors. The
RememberingLogger is wired via static binding in infrautils which
supplants logback as the backing impl.

Change-Id: Ie26f047c2320ff812d796a25f2e3721b59b73ba0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Improve TopologyStatsProvider transaction chain failure

Create new chain when onTransactionChainFailed
for TopologyStatsProvider.

Change-Id: Ib3ff3b7b1c9381efa8f35cbb5ed88195320f06c9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Improve chain transaction fail handling

under Data change counter.
- Migrate submit to commit.

Change-Id: If2149bdf87ca8a94e4d74f379424ff36f934a52f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework OffsetMap.remove() and share empty arrays

Empty arrays are immutable, hence we can share those instances,
reducing overheads. Also updates OffsetMap.remove() to take an
empty array argument, which will be used when the map would become
empty.

Change-Id: I9e44ec0eb984f8614d307dd679bed8db0739478a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use byte[].clone()

BGPDocumentedException can be made more efficient by using
byte[].clone() instead of Arrays.copyOf(). Also pre-cache empty
data and return it when needed.

Change-Id: Ib4e36522f0d3a734621349c1b62865496d330009
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not use 'new Long()'

Instantiating a long through new is inefficient, use Long.valueOf()
instead.

Change-Id: I7c520334e3a0012e7938a11fc587bfa894afbcf4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate deprecated OsgiCommandSupport

Change-Id: I3fabc2af08746b2690a8e1ca8cb87e6ec84ad411
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Migrate to karaf shell api

org.apache.felix.gogo.commands is deprecated, migrate to
org.apache.karaf.shell.api.action equivalents.

Change-Id: I22d1714f4bff6acfecb0fdd87c595e32af5d9a8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate ShellTable to non-deprecated class

org.apache.karaf.shell.support.table.ShellTable is the new location,
use that.

Change-Id: I85b6adc2ae01a47236217676f78cce9e0f81237e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate parseNlri method

Change-Id: I6a87d4aae25e56029bc412ca7777b90a7c122cef
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Bump versions by x.y.(z+1)

Change-Id: Ifd4808818e4824726c2c0f3c807538f77a88b5b1
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Add Karaf build profile

Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.

Issue: RELENG-86
Change-Id: I3b13b5051907226c136ab2788ee3881794a3ce52
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Remove obsolete Maven Site configuration

Change-Id: I2946377b3a24cedc05073611e13b9973583af8ae
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump to odlparent 3.1.0 and yangtools 2.0.3

Change-Id: Id97e73be4560826c786c7ca661cbffafcef01d27
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix findbug NP_NONNULL_PARAM_VIOLATION complains

Change-Id: I359f4a8c626753e9d5eeb6eb4b2cbd906b28e984
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Use dedicated executor for BGPCEP Stats

BGPCEP-786
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Change-Id: I85d227f237509e3646805258ebeb1c22ebb3a54b

BGPCEP-740: Fix logic for MED comparison in BGP best path selection

New better path should be selected only if new MED is lower than
actual best path MED.

Change-Id: I8bd07dc8b42e575cebcc4e1ea4b55d9c2c842f42
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit c98b6ebaaca98050c7e2bebe4709e918b15fba70)

Add missing copyrights

Change-Id: I992492a29d54cd0d70e0a1289fb891754775584b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-770: Lock file before processing

In this way we ensure is not still been modified
when event is raised.

Change-Id: I69047f244e78bdf4536d6f2a83d3b80c45191e90
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit ac2ebcb16be3c1c17136cb479ba85f1c15dfa02f)

BGPCEP-574: Deprecate simple-routing-policy

Change-Id: I5528f5bd7942e1edf1383176dbf07fa104705ad5
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix model compliance

Declared prefix should be unique within a module, as that is
the prefix that is used to refer to a module within itself.

Change-Id: I699c529831fd62854a50e46c105a3d7922d670f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BGPCEP-764: Use full Ipv6 form under StrictBGPPeerRegistry

Ipv6 equal is not capable of handle short or full form
of Ipv6, returning false when comparing different versions.
Therefore use full form under registry.

Change-Id: I2127f20e847860792d0f1c18b0ae243825a9d86a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
(cherry picked from commit 889700a070e725f44ee3d4fe215d93312ac8f0bf)

Bump versions by x.y.(z+1)

Change-Id: Iac930fab220ac59c3f55ecf66b117c5e02493b4b
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

BGPCEP-766: Reduce synchornization

under AbstractTopologySessionListener

Change-Id: I99efef02cef6f9af761c73d57bb4b37e50177830
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-763: Fix Pcep Deadlocked thread

improve synchronization

Change-Id: Ie10528d511b35911051a9aef149ae0c0c87116e0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Update .gitreview to stable/oxygen

Change-Id: I9b5d182977d37a17d35d41238da8160edc3ba8a5
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

BGPCEP-760: Fix Dead lock

when connecting multiple peers at
the same time multiple routes are announced.
Fix by improve sync under Peer export groups.

Change-Id: I588db1bfc3cfca80308837084ac5088b8fc89cea
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix NPE

when calling containsEqualConfiguration on Peer

Change-Id: Idc674a8be808386c0a3050dca3a3895cf0491caf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove no longer required service-properties

for restart OSGI CSS service

Change-Id: I65c4810ca5da9bd357dbdabb3ed413649ba8fbb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-758: Use random ip for Pcc mock tests

-perform some clean up

Change-Id: I79ef9f8e5f01b1d461c5848d7966f9e3521f926d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-757: Handle WRITE as SUBTREE_MODIFIED

on case of Topology rewrite, following
the same procedure as if it was an update.

Change-Id: Ida6bf596137054bb6a5d02d4345daee8cf5f3394
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove unnecesary sync

Change-Id: I6cf0f20346719e311164bf96c3b87387878200d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove default pcep tunnel topology

until is documented.

Change-Id: Iaa046626cdad1271db7a89a7d455bbe04ea88364
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-745: Improve synchronization

when unbinding PCEPState

Change-Id: I7558610208f12e09f69d859bb0b613a044f8b1ce
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix Tunnel Topology configuration

by catch correctly the id of the pcep
topology from topology-ref.
- Improve logs
- Add tunnel topology to example config

Change-Id: If55ea04c6361241b4199bfca02a4c534e67805b6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove config-parent

Change-Id: I0e75ed7e809b5904e3ec11fa3f1937b371d0c2d2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-739: Fix  "raced with transaction PingPongTransaction"

under TopologyNodeState. Raced call to putTopologyNode
will cause an override node and therefore PathComputationClient
was being removed and ending on exception when trying to update
it after such change.

Change-Id: I1d5b44c383d7159669bec7475afff3713f1370a0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Rework poms

- Remove bundle-parent.
- Remove dependency-version-management
- Use instead bgpcep-parent
- Clean up bgpcep parent

Change-Id: Icc0e40017204916c8fa2c33546195f56e0249591
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Simplify config loader tests

Change-Id: I8c04f7f27aafb9a4760bb5d043db2f08bdee91d9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-748: Fix AFI/SAFI

peer support registration when old-school BGP-4
is used.

Change-Id: I2137ea2647f01fb87bad04e682fe0bf5541768e8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Replace deprecated CheckNotNull

Change-Id: I21ec7c40264533e027320f7b5b31ee895003537e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Document path-id reserved value

Change-Id: I663ffac423e8a48c8528782165abc1406d70bb44
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-672: Fix key storage un adj-rib-out

list key must not be null, therefore
path-id should always be included.
Reserving PATH-ID 0 for non-supporting
add-path.

Change-Id: I9b0af92e91e7c0b1c7281230a804c7adeff2dbca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-724 Make BGP Session recoverable

This patch make BGP Session recoverable when anything wrong
happens during netty session negotiation. When an exception
is captured, the BGP session will be terminated.

Change-Id: Id3fc7ec282a2151e3bd6bdbfa8930e141b3ceaff
Signed-off-by: Kevin Wang <kevixw@gmail.com>

Remove private constructor tests

Change-Id: I33cc6ffcf940db226826e350e59c8af5eb1e1d71
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove no longer required method

Change-Id: Ic987e86f09cff5df35f81c13a7385866727f30ed
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Reduce number of parameters for pcep

-improve logs

Change-Id: Ibdf63a2b7d7894600a466a07086d7b9d4d9b5cc4
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Add feature-repo-parent pom

reducing duplicated dependencies
by inheritance.

Change-Id: I8683f302ec4bd7aa08ed38bbc8a149e17de24a5d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Add single feature parent

reducing duplicated dependencies
by inheritance

Change-Id: Ia143e2f70f1aa76cb611f58b7673bb96a722bdd1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix poms

- use dependency version management
- fix checkstyle complains
- add checkstyles to parents

Change-Id: Ide387d38f5d4e6c865f12070c5f8e3bbea5f9aef
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Eliminate unneeded declarations

yangtools.version is not really useful, as are the plugin
declarations, which we are inheriting from elsewhere.

Change-Id: I78ca9db9bb0341237fca05d251a801efab95266b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Cleanup feature dependencies

Use smaller upstream features to the extent we need them.

Change-Id: I9bf9dac7fe926c5c69a544ac7620d8a18085e5e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix config-loader-spi pulling in bundles

Depend on odl-mdsal-broker instead of pulling in controller bundles
into this feature.

Change-Id: I86c7e150a0e972f2f802c8bc5e8bea892b0d5bad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to yang 2.0.1

Change-Id: I6551c9e338f7e178997edaf1fdc680598f587c6c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Disable offline link detection in bmp-impl

This seems to suffer from a similar affliction.

Change-Id: I236f7bdfd00dc361d8d7e5177c4d9eac8954d2a5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disable offline links in bgp-rib-impl

This is a workaround for broken merge job -- disable link
detection until we figure out what is wrong with jenkins.

Change-Id: I985702541b46fd015cde55a9e35390ffc978cf8a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-3.0.2 and yangtools-2.0.0

This is a combined upgrade of dependencies, adopting them in one
go. Since yangtools has switched to using java.util.Optional,
mirror that decision in interfacing expected do directly interact
with NormalizedNodes.

Change-Id: I87977f2757777c3cefe2a59acb0ec1f2d3beed21
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix yangtools feature reference

The feature was renamed to odl-yangtools-data, fix the reference.

Change-Id: I1f26a9206ff151bc90d8bb298bff8a83af755a1e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-3.0.0 and yangtools-2.0.0

This is a combined upgrade of dependencies,
adopting them in one go.

Change-Id: I68206648e60f657a2d16f1160bd379c0a769ee75
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-742 Fix BGP NPE filter null BGP State

from BGP State collector.

Change-Id: Ic23277b22466140c2e17c429eea7467fd9d33ce8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-739: Improve logs under programming

- make programming service closeable
- close service when pcep-topology provider
service is closed.

Change-Id: I87ad85b3b4a54c71b1020f12b962277b7595b182
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Introduce testtool-parent

to enforce findbug and checkstyle
under testtools

Change-Id: I971c273cbfd739e308d3548faf664af7812cc30c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix findbug and checkstyle issues

Change-Id: Ia8fef246d76af79c9557f7cecf7cbd2740249ab9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix findbug issues under pcep modules

Change-Id: Ia1fd4067479bc0bbdc8242ef7cc111394b62c059
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix findbug issues

for rib-spi & rib-impl module

Change-Id: I76e4bebdab4581ec4475647af5ce87bcfc52d616
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce checkstyle & findbug under bundle-parent

and remove enforcement from modules which
contains it as a parent.

Change-Id: I48846c5765f35411ab28508da8df7fdcf2c8f8a2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce checksyle findbug and checkstyle

under bgp topology

Change-Id: Id30c083d36fa47b42f45f2eaa1c0ccd91109564f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce checkstyle and findbug

under PeerAcceptor

Change-Id: Ied636638346c6a3852aa7c453d73b8d13c011278
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce checkstyle and findbug

under openconfig-state

Change-Id: I01cca3a4b084691449da90f64cfe55d370a99db9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Fix checkstyle issues under rib-spi

and enforce findbug

Change-Id: I4bf3cc40aa28636a016dbc97c9bda17284557c63
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug and checkstyle

under programming spi

Change-Id: I5f2b757c48ac2ae107dadd1174fb4779528b3e77
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug and checkstyle

under openconfig-spi & rib-mock

Change-Id: I09a97928c539f5638d920794704cc9796b534e53
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug and checkstyle

under modules

- openconfig-api
- parser-api
- ri-api
- testool
- util

Change-Id: I01838e001689835f1d4f4b3dab5c1e3fe311fc72
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Remove GLOBAL strict bgp registry

Change-Id: Id11ef8a8bcb31949f90734d43fae0a19da81b4b2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug and checkstyle

under programming impl

Change-Id: I46db1e8dbf0c94ad8640af15b5bbe25e30ff8559
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug and checkstyle under utils

Change-Id: I3598bd00429565b11f5fa1913efe70634ccd5b36
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Optimize TerminationReason memory usage and performance

Using a map is forcing us to box on each lookup. Given the cardinality
a simple array lookup is just fine.

Change-Id: Id39151267545e6c35a3c0b9997612879e9b88c65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enforce findbug and checkstyle under PCEP

Topology provider

Change-Id: I90c6e45d3a9c8ae559c327de8c0e4fa09cc02a76
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

BGPCEP-738: fix unbind pcep stats

by doing it when session is finished
 or topology is closed.

Change-Id: I5f46f1e2bfb7f37a9fad6d3101177c8f127ba67a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug and checkstyle under BMP Parser

Change-Id: I9f2b96af276dbbe4edd528373473c42a1d459daf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug and checkstyle under BMP IMPL

Change-Id: I6f6edbb401c95a80768d2c507e6c909d69ae493d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce findbug and checkstyle under BMP SPI

Change-Id: I6e0de407586040e6de8d86bf45bedb614a769d4d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Enforce Findbug and checkstyle under BMP API

Change-Id: I7882d0af8603bd5939edc4a8d2850c544b6fef50
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>