Bug 6278: Copy karaf-parent from controller to odlparent As discussed in the MD-SAL call, there is an architectural need to move karaf-parent from the controller project to the odlparent project. This is particularly useful for karaf upgrades, since right now a bump in karaf version within odlparent requires a rebuild of controller to reflect the change in karaf-parent, and our build jobs are not set up to support such a process. The move process will be handled in multiple steps: 1) Copy karaf-parent, karaf-branding and opendaylight-karaf-resources to odlparent. All three of these should belong in odlparent. All three must be moved since karaf-parent depends on the latter two artifacts. Since controller depends on odlparent (and not the other way around), they must be moved upstream to odlparent. 2) Have controller's karaf-parent derive from odlparent's karaf-parent. This preserves the ability for downstream consumers to derive from the controller karaf-parent in the interim, while allowing changes to odlparent's karaf-parent to be recognized since controller does not need to be rebuilt. [THIS PATCH] This also involves removing karaf-branding and opendaylight-karaf-resources from the controller project, since they are no longer needed. There are two consumers that need to be patched: lispflowmapping: https://git.opendaylight.org/gerrit/42647 vtn: https://git.opendaylight.org/gerrit/42648 3) Change all downstream projects to utilize odlparent's karaf-parent. This is future work and will be done in several patches. 4) Remove controller's karaf-parent once we feel all downstream consumers are using the odlparent's karaf-parent. Change-Id: Ib42ff5212bbfb93883346a19855544df4fb06d61 Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Bug 6027 - Can't start karaf using symbolic link When executing the karaf script, it gets the DIRNAME based on $0 which is the path used to start the script. This DIRNAME is then used to set the KARAF_HOME and multiple other KARAF_* evn variables. Using a symbolic link, you would have, for instance, usr/bin/karaf redirecting to /opt/opendaylight/bin/karaf. So $0 would be usr/bin and not /opt/opendaylight/bin so the locateHome function isn't setting the right path for the KARAF_HOME. This ends up failing to start ODL with following ERROR: Error: Could not find or load main class org.apache.karaf.main.Main see: https://github.com/opendaylight/controller/blob/master/karaf/opendaylight-karaf-resources/src/main/resources/bin/karaf#l114l126 Change-Id: I36eff657972768de7d7b90f6563addfc3dd96c0f Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com> Co-Authored-By: Michael Vorburger <vorburger@redhat.com>
Set karaf.delay.console=true in etc/config.properties $ ./karaf Apache Karaf starting up. Press Enter to open the shell now... 78% [=========================================> ] (...) 100% [====================================================] Karaf started in 23s. Bundle stats: 276 active, 276 total Change-Id: Iad04b7d03aa5be5dc17e28c4d60a56ded8a2f774 Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Enable Java installation in folder with spaces It has been quoted the variable $JAVA in the karaf script in order to allow that the Java installation is in a folder which name contains any space. Change-Id: I6305204c872552c4e52ec7000720c67340cf0b88 Signed-off-by: danipeon <daniel.peon.quiros@ericsson.com>
BUG-5932: Remove unused OpenFlow configuration parameters OpenFlowPlugin is hosting its own configuration, these knobs are no longer needed. Change-Id: Ib9c9505075ae17a8540219e7b2612494f460366c Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG 5932 - Remove NETCONF property Remove netconf.ssh.pk.path property from controller etc/custom.properties file. It is netconf's project responsibility to manage its own properties. Needs to be merged after https://git.opendaylight.org/gerrit/#/c/39941/ Change-Id: Ib4d882c911682cc8a6844511c935f89aeddbced6 Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Bug 6030 - "karaf" script invokes /bin/sh but requires /bin/bash functions The bin/karaf script uses the "local" command which is a shell builtin of bash and similar shells, but is not required for POSIX-compliance in sh. On most flavors of linux, this resolves to bash or dash which probably runs in a restricted environment after checking to see that its $0 is sh. But on Solaris's /bin/sh is actually ksh93 for backwards compatibility. Change-Id: Ifdd0e9fe798e881df01e7d2b586bc7e7142c0730 Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Upgrade karaf-resources to 3.0.6 Pull in updates from Karaf 3.0.6, and avoid hard-coding the Karaf version. Change-Id: I30a58982ff8f2e85efaecc8edbf7979ad5db3c54 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Make Karaf dump heap on OOM by default See mails in this thread: https://lists.opendaylight.org/pipermail/release/2016-March/006098.html This changes DEFAULT_JAVA_OPTS, so if user sets JAVA_OPTS it would override this. Change-Id: I54fad73c5f50a6bf251bd3b255293ff3ef4ed877 Signed-off-by: Vratko Polak <vrpolak@cisco.com>
JVM8: Remove PermSize and MaxPermSize options PermSize and MaxPermSize JVM options are not supported in Oracle Java 8. Since Boron only supports Java 8, they no longer need to be set. This avoids the following warning: "Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0" Change-Id: I9a8158113746db9a1edf5d7f62a3aaf24a652143 Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Bug 4202: Migrate also toaster to use mdsal project This only changes dependency feature omitted from Change 26079, perhaps Java edits are also needed to keep toaster working. Also, git has somehow enforced change of line endings everywhere. Change-Id: I810fba0ae7a55e123dd6f78ba23a7e77a7118b57 Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Use AsyncAppender in pax-logging Using an async appender throughput of the logger, lowering its impact on overall system performance. Testing with BGP debugging enabled, the overall time to complete for 100K routes went down from 137 seconds to 81 seconds. Change-Id: Ieac46ecbddb701f862f7d58833ebdc94de0fbaf4 Signed-off-by: Robert Varga <rovarga@cisco.com> (cherry picked from commit 1a41b7575f0daa0db6710bf84520c255ed325e1a)
Remove commons-io dependency in netconf-ssh Remove the replacement of File separators in key path, windows can handle linux style paths, added a warning to config to use linux style paths. Change-Id: I01d07fa65cd11dcc321cbf4d6f5aac0792922309 Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-3553 Introduce custom java.security config file Set the list of excluded ciphers available for use in ODL. The list was developed in order to disable weak/vulnerable ciphers and also to prevent the Logjam exploit. The security file can be set using ODL_JAVA_SECURITY_PROPERTIES env variable. Change-Id: I4867fe05986c020e09938c138d4d033299e0f9b7 Signed-off-by: Maros Marsalek <mmarsale@cisco.com> (cherry picked from commit 482cb4a1845e2e8109b9176704f2421ff7f40277)