Reinstate the AbstractConfigTestBase.logConfiguration method https://git.opendaylight.org/gerrit/#/c/68992/ removed this method but there are downstream users so to avoid API breakage the method was added back but as deprecated. Change-Id: I8e8eb452724451792c9ac6a140047d063b5d2441 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Update integration test base classes to use Log4J2 The config-it-base and mdsal-it-base components contain abstract classes to be used for integration tests. This commit migrates those classes to Log4J2. See also: https://lists.opendaylight.org/pipermail/odlparent-dev/2018-March/001769.html Change-Id: Ia19cb2f1d91cc2df7e9fc632a5b82731260652f1 Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Fix checkstyle issues to enforce it Fix checkstyle issues to enforce it. Change-Id: I0657beb7831e81b1d24adcd41dc9bf23d0701d64 Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
config-it-base: final parameters This automatically-generated patch flags all appropriate parameters as final (including caught exceptions). Change-Id: I18d9f65ec8addc7d5ecb7d809260c2d09ee8a4df Signed-off-by: Stephen Kitt <skitt@redhat.com>
Prepare config-it-base for Karaf 4 Downstreams using mdsal-it-parent as their integration test parent will not be able to migrate their IT to a Karaf 4 based distribution without this change. See also https://git.opendaylight.org/gerrit/#/c/51450/ Change-Id: I572151bcf16fb9864f59dd446952ab13a12b295f Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Use opendaylight-karaf-empty from Odlparent The Controller one is kept for project not migrated to features-parent yet. Change-Id: I2354a5e738449494486fc8e433afdc302c6bb7f8 Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Deprecate getModuleName()/getInstanceName() in AbstractConfigTestBase The AbstractConfigTestBase currently requires a config system moduleName/instanceName to be provided by the derived class to ensure the config module is pushed and present in JMX. However blueprint-enabled apps won't have a config system module so deprecate these methods and make them optional along with the check. Change-Id: I1f2f6a993cf99ba25d766ba0ec20ed27b1a9915f Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Make config-it-base capable of accepting additional options from derived classes. Change-Id: I654224bf9c927e0b393f92036f759b487a8075ad Signed-off-by: Kevin Wang <kevixw@gmail.com>
Modify AbstractConfigTestBase to use opendaylight-karaf-empty The vanilla karaf distro that AbstractConfigTestBase installs only has the base features. We need the standard features which includes eventadmin which is needed for the upcomng blueprint work. So I changed AbstractConfigTestBase to install opendaylight-karaf-empty which now includes the standard features as well as the updated Aries proxy-impl 1.0.5 artifact. Change-Id: I46100cc8edb9743e0885b156a1adc37e3a18ca9e Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Convert toaster-it to use mdsal-it I recently added an mdsal dependency to another project and it caused the toaster-it test to fail. There was no useful output to troubleshoot, just that some bundles failed to resolve. It turns out the mdsal dependency and all its dependencies would need to be added to the hard-coded bundle configuration for the test. This will be ongoing issue every time a new dependency is added that might affect the toaster test. To alleviate this I converted the test from manually installing bundles to use the mdsal-it functionality which installs features into the opendaylight-karaf-empty distro. I also changed AbstractConfigTestBase to override the pax logging to append to stdout, otherwise most output goes to karaf.log. This is helpful to troubleshoot failures. Change-Id: I1dd9150c6e617e491458560fe4b360d37548f264 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Use ${karaf.version} in AbstractConfigTestBase Instead of hard-coding the default version of Karaf in AbstractConfigTestBase, pull in the version stored in ${karaf.version} via a filtered properties file. Change-Id: Ia739dd9d2ab34520b611122b296664c82687b3a2 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Upgrade to Karaf 3.0.4 With Karaf 3.0.4 we need everything to be in sync (${karaf.version}, SingleFeatureTest and AbstractConfigTestBase). This goes with Ia6e719ab165586be25d664e226815c0df9478cd2. Change-Id: I9da7721aa29e3f480e8bc35a57acbe77f89a70c4 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Base projects and parents for IT tests. This provides a very very simple working basis for IT tests. Change-Id: I16fae750c32ffe6fce356c8036b6d74988aa4f99 Signed-off-by: Ed Warnicke <eaw@cisco.com> Signed-off-by: Ed Warnicke <hagbard@gmail.com>