Remove CSS code JIRA: TSC-111 Change-Id: Ib74c1d3dfc029c2472b8834ae55ce05c8231d225 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix checkstyle reported by odlparent-3.0.0 Change-Id: I08c548fbbbef8527ad7b037b0def33d3c1c09bf6 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix checkstyle issues to enforce it Fix checkstyle issues to enforce it. Change-Id: I306255919cdfe43208d7c254f2f6455f4126b92f Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
config-manager: final parameters This automatically-generated patch flags all appropriate parameters as final (including caught exceptions). Change-Id: I78de8a8a8f9766a654432e8ba5a0497f06c4438a Signed-off-by: Stephen Kitt <skitt@redhat.com>
Fixed few sonar warnings. Removed static imports. Change-Id: Ife05c6c4fc288c70624880eefbe9c5be8b47b974 Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
BUG-4514: clear destroyed modules When the transaction concludes we do not need to know the destroyed modules anymore. Clear them out as part of the close sequence. Change-Id: Ia2a43ed424d96a99cc27df7b685e6abf7393f8a3 Signed-off-by: Robert Varga <rovarga@cisco.com>
Remove RuntimeGeneratedMappingService from config-manager Replace with BindingRuntimeContext Change-Id: I8e3ef881898f6ea7b9c3922a3bfaf3094667c644 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2283 Fix close order when reconfiguring config modules. Close is called from top(dependency source) to bottom(dependency target) while createInstance is called in opposite direction. This commit changes API and SPI of config subsystem and thus breaks runtime compatibility. Change-Id: I5b03f0673c5ecb95efbfccad7fa6ed7a490ff61b Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2381: do not retain references to DependencyResolverManager Instead of creating an anonymous subclass, define a proper class and pass it the three required fields. Change-Id: I5c9eea66284b60597ac77b336ef3afa652633479 Signed-off-by: Robert Varga <rovarga@cisco.com>
Issue fix for config subsystem Change-Id: I73d02158accb65c92dabc76eb8b353b052ac2d05 Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Bug 1022 - Add ability to lookup dependent Module's attribute. Add 2 methods to DependencyResolver to allow modules look up values of dependent bean attributes. Change-Id: I2ebee82cc1260a84a16f5e69b32c9234bf576e87 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Resolve Bug:807 - Keep ModuleFactory references shutdown purposes. Retain ModuleFactory instances even if they disappear from OSGi SR, so that the already committed instances can be closed cleanly. Also remove shutdown customization (stopping config-manager as first bundle) from shutdown-impl. Change-Id: I8e90a7d593b7e4cc84c7a9a7d3f8bb804daf5f41 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Add watchdog thread to detect illegal blocking calls during second phase commit. Add a thread that starts when second phase commit starts, that will monitor if a module instance occupies the commit thread for more than 5 seconds. If so, log a warning every second informing about possible misuse of config subsystem to block on external resources. Added a proxy module that caches Module#getInstance() call as this method is idempotent. Change-Id: Ia1e56386bdd8c6b7a6dc625cfc69253b927c92a9 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Add support for identity-ref config attributes to config/netconf subsystem Change-Id: I79d5147f1d6bb1acd6b5a374bb76f48b6a3aaf55 Signed-off-by: Maros Marsalek <mmarsale@cisco.com> Signed-off-by: Tomas Olvecky <tolvecky@cisco.com> Signed-off-by: Robert Varga <rovarga@cisco.com>
Persist service references as separate MBeans. Create dummy MBean - ServiceReferenceMXBean - that contains link to implementation of the service as an attribute. Add support for resolving of SR to dependency resolver. Each time user saves SR, create MBean and add the interface QName together with user defined reference name to ObjectName of the newly created SR MBean. Change-Id: I71ddb762e00d9be8b426fb979ff5ade046d46050 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Add warning when user destroys default module. Change-Id: I0a2b27fa8bac7e00b138847935cf803bb1ee8156 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Change fix for default module's dependency resolver creation into two steps. Call dependencyResolverManager.getOrCreate in scope of creating default modules. Add check to putConfigBeanToJMXAndInternalMaps so that identifier of module and dependency resolver must match. Remove deprecated method from DependencyResolverImpl. DependencyResolver interface now extends Identifiable<ModuleIdentifier> Change-Id: I04207882b6501e71ac4e0fc321fb7932ebb747fb Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Fix star import and enable checkstyle rule to prevent it. Change-Id: I62a1b8e3e85c2575939c3710524a98c91227648d Signed-off-by: Alissa Bonas <abonas@redhat.com>
Add ModuleFactory#getDefaultModules method to config-api. Add method to populate pre-existing state. Modify code generator to generate a blank implementation. Calling of the method is done by config-manager every time new ModuleFactory is discovered in OSGi service registry, each time in a separate transaction. Implement default module functionality in config-manager. Add DependencyResolverFactory for default modules to be able to lookup dependencies. Implement new service tracker tracking ModuleFactory instances in order to commit blank transactions every time ModuleFactory service appears or disappears. Clean up pom versions: merge config.yangstore.version into config.version. Change-Id: I47229c9e403b817b24740c8f77ad43abcc720094 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Initial code drop of yang model driven configuration system Configuration system employs two phase commit to validate and push configuration changes to a running system. It allows changing simple attributes, complex transfer objects, and also provides dependency injection between configured modules. Module config-api contains base yang model config.yang, defining language extensions and other elements required by all configuration models. Other than that it contains both apis implemented by config-manager and spis to be implemeted by configuration providers. Since the configuration system is internally driven by JMX, package org.opendaylight.controller.config.api.jmx contains all M(X)Bean interfaces exposed by config-manager. Module config-manager is implementation of config-api. Module config-util contains clients (both JMX and jolokia, which is http based bridge to JMX) of configuration system. Module yang-jmx-generator parses yang models and creates java representation of configuration models and service interfaces. Module yang-jmx-generator-plugin is connector to yangtools yang-maven-plugin that generates skeletons of java files needed by configuration providers. Module yang-test contains example yang file, from which code is being generated. Module yang-jmx-generator-it tests yang-test. Module yang-store-api contains api for a registry of all yang models parsed by yang-jmx-generator. Module yang-store-impl uses OSGi extender pattern to read META-INF/yang/*.yang from all bundles and provides snapshot view of currently available configuration models. Change-Id: Icf3201f9754e4ca28ebce3411d2a667dcd7e75c8 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>