Remove CSS code JIRA: TSC-111 Change-Id: Ib74c1d3dfc029c2472b8834ae55ce05c8231d225 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 9165: Log config subsystem readiness as INFO Change-Id: I487760e19ac317f7246ac9b9b47f2a65df100e6b Signed-off-by: Vratko Polak <vrpolak@cisco.com>
config-persister-impl: use lambdas This series of patches uses lambdas instead of anonymous classes for functional interfaces when possible. Lambdas are replaced with method references when appropriate. Change-Id: I20e8b07b839c168d0944c44a57602c3b9a96ce6a Signed-off-by: Stephen Kitt <skitt@redhat.com>
config-persister-impl: final parameters This automatically-generated patch flags all appropriate parameters as final (including caught exceptions). Change-Id: Ib950fb9560113b780898767f03c58edfa022c568 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Removed sonar warnings. Change-Id: I030527e8d6ec5762e63707b157b77a4f21683bbb Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Mechanical code cleanup (config) * Remove unnecessary type specifiers (use Java 7 <>) * Remove unnecessary "extends Object" declarations * Remove unnecessary semi-colons * Merge identical catch blocks * Remove redundant modifiers: - enum constructors are private by default - interface properties are public static final by default - interface methods are public abstract by default - interfaces are abstract by default - inner interfaces are static by default - inner classes in interfaces are public static by default Change-Id: Iefd8363a5eb120fdd43a4632b9e3db0e7e347dba Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 4560: Improve config system logging for debuggability Manually cherry-picked from https://git.opendaylight.org/gerrit/#/c/28985 as the files have moved in master. Also the code has changed slightly in master, specifically the ConfigPusherImplTest no longer uses a Thread uncaught exception handler for verification. However it does rely on exceptions thrown from the ConfigPusherImpl so, to keep the same behavior, I added a propagateExceptions flag to ConfigPusherImpl#process. The ConfigPersisterActivator production code passes false so unchecked exceptions aren't handled as uncaught exceptions. Change-Id: Iabc22030abc22cf11a1476986ba3d3366021b4fb Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Fix ModuleFactory not found errors https://git.opendaylight.org/gerrit/#/c/27874/ improvements to the config system but had the side-effect of introducing timing issues where a ModuleFactory wasn't found when trying to push a config. The reason is that yang schemas load earlier and much quicker than ModuleFactory's, which are scanned from ACTIVE bundles, so the capabilities may resolve but a ModuleFactory may not be available yet. As a result, that patch was partially reverted for the time being. To fix the missing ModuleFactory issue, I added retries in the ConfigPusherImpl when a ModuleFactory isn't found, similar to the ConflictingVersionException retries. The backend now throws a new checked exception, ModuleFactoryNotFoundException, which is caught to trigger a retry after a delay. Prior, it threw an InstanceNotFoundException which was wrapped in an IllegalArgumentException. I didn't keep the InstanceNotFoundException b/c it can be thrown for other reasons and I wanted to distinguish missing ModuleFactoryNotFoundException. I derived ModuleFactoryNotFoundException from RuntimeException to avoid having to change signatures in the call chain and thus changing the API. Prior it threw an unchecked IllegalArgumentException anyway so it's consistent plus other areas of the code throw unchecked exceptions along with checked exceptions. Since the missing ModuleFactory issue is fixed, I re-enabled scanning of RESOLVED bundles in the ModuleInfoBundleTracker. Change-Id: I89ff346c0a89afdfa76ce402f2cf3211ac68b5c0 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Decouple config and netconf subsystems. Extract a common mapping for config pusher and config subsystem netconf Add a ConfigPersisterFacade for XML that allows reads/writes from/to config subsystem using XML format Push notifications from YangStoreService to NetconfNotificationManager instead of using custom listeners Migrate netconf features from controller features, untangle features Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca Signed-off-by: Tomas Cere <tcere@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com> Signed-off-by: Ed Warnicke <hagbard@gmail.com>