Remove odl-controller-exp-netty-config Remove all of configuration remnants, as there is just a single downstream user. JIRA: CONTROLLER-2092 Change-Id: I2d0bb01cfd061c2f0086fcc80b27e6b0a336e5dc Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Do not allow global timer to be stopped We have a globally-shared instance, it should never be stopped via Timer.stop(). Log a warning whenever that is atttempted. Change-Id: Id29f3799024b826d2278bf95f75cc661f85ab8e8 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Use constructor injection for OSGiGlobalTimer Upgraded SpotBugs is warning about field initialization, side-step it by using constructor injection. Change-Id: I1697459db8d72c956649f3c61f3d090322c3e9fb Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Convert netty-timer-config to OSGi DS This is an extremely simple forwarder, convert it to OSGi DS. JIRA: CONTROLLER-1882 Change-Id: I8fbb71fba704e273b8e1c8fa79b4e4dd90aeff31 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Another round of checkstyle fixes This fixes failures reported by upgraded checkstyle, as well as some non-enforced violations. Change-Id: I8b6a9667c6586bef528587d455f7a8597b4f483f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Reduce JSR305 proliferation retention=runtime annotations are mixing really badly with Java EE injection and Java 11. Make sure we do not use javax.annotation package in APIs and reduce overall proliferation inside implementations. Change-Id: I569815f0336efdc0de662c3b80f0fa6e5dd47d8a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Move BP xml files to standard OSGI-INF/blueprint We originally used org/opendaylight/blueprint in case we needed to customize how BP bundles are processed but this wasn't needed. So let's move to the standard BP dir. We'll keep the BlueprintBundleTracker as is for backwards compatibility - the only change was to modify it to look in both dirs for BP xml files when restarting the container for a bundle. Change-Id: I777e831ef4d8293b49d7aa6c8cdecec96b97937f Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Integrate MRI projects for Neon This patch bumps: - odlparent to 4.0.2 - yangtools to 2.1.2 - mdsal to 3.0.1 It also deals with: - DOMRpcError.getErrors() changing - java.util.Optional being used in MD-SAL - xmlunit upgrade via xmlunit-legacy - any(Class) not matching nulls - lists disappearing and hence requiring at least one item - remove explicit <null/> in blueprints, as that breaks blueprint-core - adjust sal-binding-it to include byte-buddy, which is a mockito dependency - adjust dependencies to account for ietf-{inet,yang}-types movement - moving to tech.pantheon.triemap - mdsal.common.api removals JIRA: CONTROLLER-1860 Change-Id: I31b2d011015846537a99f963ded1d38e7b29d71e Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove unused exceptions This drops exception declarations which are never used. Change-Id: Icc8938b9c3b437a0d5961ec1b481fd06c52d47f2 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Remove CSS features Change-Id: I963daed0f5cc379edeaa98054890dcde0b75cf54 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 6794: Remove threadpool config modules With the removal of the CSS netconf connector, the threadpool config modules are no longer used so remove them. The *Wrapper classes are used via blueprint so they remain. Also removed the eventbus config modules which were deprecated in Carbon. Change-Id: Ic528e5817a9f5ccdb67ef41987128ead4db51cbd Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
netty-timer-config: final parameters This automatically-generated patch flags all appropriate parameters as final (including caught exceptions). Change-Id: I71a80cceb92ea77c2880d26ab311dd1c797e502d Signed-off-by: Stephen Kitt <skitt@redhat.com>
Use nullOrNonPositive instead of nullOrNonZero The method name should match it's functionality to test whether the duration is positive or not. Change-Id: I830d1072d5854d88a96f02a3f161456329a50be7 Signed-off-by: Jacky Hu <hudayou@hotmail.com>
Mechanical code cleanup (config) * Remove unnecessary type specifiers (use Java 7 <>) * Remove unnecessary "extends Object" declarations * Remove unnecessary semi-colons * Merge identical catch blocks * Remove redundant modifiers: - enum constructors are private by default - interface properties are public static final by default - interface methods are public abstract by default - interfaces are abstract by default - inner interfaces are static by default - inner classes in interfaces are public static by default Change-Id: Iefd8363a5eb120fdd43a4632b9e3db0e7e347dba Signed-off-by: Stephen Kitt <skitt@redhat.com>
Deprecate netty config modules Marked the md-sal dom/binding config yang modules, 01-md-sal.xml and associated Module classes as deprecated. Change-Id: I5c2b531ac489b3ce06e54078f28ad0ea76a35670 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Enable netty config modules to restart when blueprint container restarts Added the necessary service properties such that when the blueprint container is restarted on config change the associated config system Module instances are recreated/restarted. This for backwards compatibility for existing CSS modules that inject the netty CSS modules. Change-Id: Icb12968805d8760cb03d3eea1e8ceda5ec1de2f5 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Modify config Module impls to co-exist with blueprint Modified various config system Module implementation classes which have corresponding instances created and advertised via blueprint to obtain the instance in createInstance from the OSGi registry. The instance may not be available yet so it will wait. I added a WaitingServiceTracker class to encapsulate this logic using a ServiceTracker. For those modules that don't advertise services, createInstance simply returns a noop AutoCloseable since the components are created via blueprint. I also added the new disable-osgi-service-registration flag to the corresponding service yang identities to prevent the CSS from duplicating the service registrations. This patch also adds the blueprint bundle to the mdsal features and "turns on" blueprint. Change-Id: I60099c82a2a248fc233ad930c4808d6ab19ea881 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Add blueprint wiring for netty configs Wiring for netty-threadgroup-config, netty-timer-config, and netty-event-executor-config. Change-Id: I759b222c6f3fcad1cacbc4aeb1af4cec19faff0d Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Fix checkstyle warnings in netty-timer-config Change-Id: I8c2127cfd7cf00edc8ffcc90882ec2965f4bb775 Signed-off-by: Marian Dubai <mdubai@cisco.com>