Remove odl-controller-exp-netty-config Remove all of configuration remnants, as there is just a single downstream user. JIRA: CONTROLLER-2092 Change-Id: I2d0bb01cfd061c2f0086fcc80b27e6b0a336e5dc Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix FlexibleThreadPoolWrapper checkstyle Nested static classes are detected as checkstyle violations if they are not final. Fix that. Change-Id: Ifa5878890cabe845ecf8d98d46f2fc8015a78770 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Migrate users of Optional.get() We have an incoming enforcement patch, prepare to adopt it. Change-Id: If73abd4ceaea71a216a4bc3a3968b400b508ec38 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump odlparent to 6.0.0 This bumps odlparent to 6.0.0 as part of Magnesium MRI. Change-Id: I084c6a32c4facafd85e3b87c6d8a9a29a33848a8 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Use OptionalInt in FlexibleThreadPoolWrapper This gets rid of Guava Optional and fixes an unboxing warning through use of Java 8. Change-Id: I9c22bbedfcdd08f18c5ff14283dd8f130d6020c6 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump odlparent to 5.0.0 This bumps odlparent references to 5.0.0, removing use of the JSR305 remnants. Also a useless javadoc plugin override is removed. Change-Id: Iae5355e49115afdd73b60bd26ac85f7f542bbff8 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove unused exceptions This drops exception declarations which are never used. Change-Id: Icc8938b9c3b437a0d5961ec1b481fd06c52d47f2 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 6794: Remove threadpool config modules With the removal of the CSS netconf connector, the threadpool config modules are no longer used so remove them. The *Wrapper classes are used via blueprint so they remain. Also removed the eventbus config modules which were deprecated in Carbon. Change-Id: Ic528e5817a9f5ccdb67ef41987128ead4db51cbd Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 6794 - Deprecate eventbus, async-eventbus and fixed-threadpool Those modules aren't used anymore, I couldn't find any reference of them, expect some in netconf regarding the fixed-threadpool. But those reference are coming from big xml test files that I suppose are pretty odl. This deprecation notice is to warn potential downstream consumer that those are now deprecated, and that those will be removed in next release, Nitrogen. Change-Id: I8810b39a632c2d4c678c31bb46b8284aa33593f2 Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Mechanical code cleanup (config) * Remove unnecessary type specifiers (use Java 7 <>) * Remove unnecessary "extends Object" declarations * Remove unnecessary semi-colons * Merge identical catch blocks * Remove redundant modifiers: - enum constructors are private by default - interface properties are public static final by default - interface methods are public abstract by default - interfaces are abstract by default - inner interfaces are static by default - inner classes in interfaces are public static by default Change-Id: Iefd8363a5eb120fdd43a4632b9e3db0e7e347dba Signed-off-by: Stephen Kitt <skitt@redhat.com>
BUG-2283 Fix close order when reconfiguring config modules. Close is called from top(dependency source) to bottom(dependency target) while createInstance is called in opposite direction. This commit changes API and SPI of config subsystem and thus breaks runtime compatibility. Change-Id: I5b03f0673c5ecb95efbfccad7fa6ed7a490ff61b Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Fix checkstyle warnings in threadpool-config-impl Change-Id: If16877977975fa07190ea8c245be3a80264a29ec Signed-off-by: Marian Dubai <mdubai@cisco.com>
Migrade JUnitMatchers references With JUnit 4.11 JUnitMatchers.containsString() has been deprecated in favor of org.hamcrest.CoreMatchers.containsString(). Same goes for hasItem(). Change-Id: Ie11616588b126110579e92bfb4b72de022bf211c Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1291 Fix executor for netconf-connector rejecting tasks. Flexible threadpool rejected tasks with SynchronousQueue and did not spawn threads with LinkedBlockingQueue. Added custom Queue that makes the underlying threadpool to spawn threads as expected. Change-Id: I28d27316cf63b3370aa802bbd31ee976aa54fbf7 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Fix unstable FixedThreadPoolConfigBeanTest Test was failing because threads were not cleaned up right after the thread pool was shut down. Test now waits up to 60 seconds before failing on threads that should have been destroyed. Change-Id: Ie9ac856007772f39426dbcbb2af0fb66226fc2c0 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Do not use deprecated destroyConfigBean in config tests Replace org.opendaylight.controller.config.util.ConfigTransactionJMXClient destroyConfigBean with destroyModule in tests. Test resource leaks in FixedThreadPoolConfigBeanTest. Change-Id: If3847d3cb9211d9e830006400c258dad9e6ffb35 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Resolve Bug:681 - Fix config module registration to Service Registry. Rework OSGi service registration during second phase commit: only service references will be registered into SR, instead of old behaviour when each module's service interfaces were used. Only one key-value entry is persisted in registration: {name: name of service reference} . Change-Id: I25249fe8f9e51570cd3ea963e91145b7e44da57d Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Resolve Bug:745 - remove windows line endings from config and netconf. Change-Id: Id60c44a5f3fd4979f4e13cb00e6537998718e94f Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Fix: removed tabs from yang files. Signed-off-by: Milos Fabian <milfabia@cisco.com> Change-Id: I1f6fcba1c5dfc3eddb53adc89950ed20795dddfb
Add missing headers to config, netconf subsystems Only java files Change-Id: If434e47d42265ed4e71507ac4998554aa6d434ab Signed-off-by: Maros Marsalek <mmarsale@cisco.com>