Remove CSS code JIRA: TSC-111 Change-Id: Ib74c1d3dfc029c2472b8834ae55ce05c8231d225 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Adjust to yangtools-2.0.0 changes Change-Id: Ib86747e5ed19c0c00bb46b8d7e4936f4d90c4364 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> Signed-off-by: Stephen Kitt <skitt@redhat.com>
String performance and maintenability Use StringBuilder for strings built in loops. Use plain concatenation for string construction not involving loops. Change-Id: I8299eb54a347d132f0d19dfb39c8fb52366049f2 Signed-off-by: Stephen Kitt <skitt@redhat.com>
StringBuffer cleanup This patch cleans up StringBuffer use, mostly replacing StringBuffer with StringBuilder or plain String concatenation for short sequences (or constants). * HexEncode: additionally, avoid using a separate return variable, drop the useless ":" handling in bytesToHexString(), and add the test class from l2switch. * HardcodedModuleFactoriesResolver: rework the conflicting module handling. Change-Id: Id76e91bba9ce40bd8ed5947c2d40e3a7baf0a949 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 6859 - Binding generator v1 refactoring Based on transfer of Binding generator v1 from Yangtools project to MDSAL in past, we need to finalize this process by refactoring package naming: org.opendaylight.yangtools -> org.mdsal.binding org.opendaylight.yangtools.sal -> org.mdsal.binding Refactoring changes in MDSAL, see: https://git.opendaylight.org/gerrit/#/c/52107 By using of Binding generator v1, this change needs to be addressed in Controller project. - refactoring itself - add META-INF to gitignore Change-Id: Ib7ec1b39466c0c814459bcbc2adce437b2a0ca64 Signed-off-by: Jakub Toth <jatoth@cisco.com> Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix JMX generator unit test MDSAL change to use static factory methods for instantiating well-known types has changed the way Longs are instantiated, breaking this test. Fix it up to reflect the change. Change-Id: I930c04baf07005216d81cfe1e123b10b21cdc396 Signed-off-by: Robert Varga <rovarga@cisco.com>
Gen. Abstract*ModuleFactory handleChangedClass() with DependencyResolver Bug: 2855 Change-Id: Ieb010d67983a4807bd1e5b55886ba0c4c3f13385 Signed-off-by: Michael Vorburger <vorburger@redhat.com>
BUG-4329: switch to javaparser Instead of using Eclipse JDT, which has not been published in ages, use comgithub.javaparser, which supports Java 8 and is quite convenient. Change-Id: I30d3975679b6b24952eabe5488fbce2db49ab0e6 Signed-off-by: Robert Varga <robert.varga@pantheon.sk>
Fix license header violations in yang-jmx-generator-plugin Change-Id: Iac866a580e9d07e9f2614a7c5c25e91e755cb4ba Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
BUG 2839: Config: remove dependencies on commons-io Migrated commons-io users to guava and custom solutions when there were no alternatives in guava. Change-Id: I399030df1fbd7ea6e40b2591346802068e32f681 Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-2976 Generate hash/equals for config generated DTOs The DTOs generated by config subsystem did not have hashCode and equals methods This caused the canReuse instance to return false even if the old module could be reused. Change-Id: I11392c2947f570a05d1a5b84fdaaee9e6b89a717 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Fix checkstyle violations caused by checkstyle 6.1.1 Change-Id: I84f356707f97184ae8708e429c6b440db8bd632f Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Update JMX generator This takes advantage of the fact maven 3.1.1 supports slf4j natively. Also fixup some of the coding style issues still present. Change-Id: I37724cc0a5c194fc333c577f39deaf550c341d34 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-2627: Fix ambiguous lookup in test case Looking up by java name "stream" matches two potential beans, which means that the returned value depends on underlying collections. This breaks when upgrading to Java 8, for example. Fix by performing an explicit prefix name, which returns the right bean everytime. Change-Id: I4c7f7f26bc00cc1b03b9ea99ef84004da46c3caa Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-2283 Fix close order when reconfiguring config modules. Close is called from top(dependency source) to bottom(dependency target) while createInstance is called in opposite direction. This commit changes API and SPI of config subsystem and thus breaks runtime compatibility. Change-Id: I5b03f0673c5ecb95efbfccad7fa6ed7a490ff61b Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Fix checkstyle warnings in yang-jmx-generator-plugin Change-Id: I2c1d564b8ddbc04beaa0f2a1914fb6c64bfc2dfb Signed-off-by: Marian Dubai <mdubai@cisco.com>
Update junit Assert imports JUnit 4.11 has moved Assert to org.junit, and deprecated junit.framework.Assert. This adjust the imports to fix the warnings. Change-Id: Iecbf2a1b4ae097989e840ad6f6d5bf759c521639 Signed-off-by: Robert Varga <rovarga@cisco.com>
Migrade JUnitMatchers references With JUnit 4.11 JUnitMatchers.containsString() has been deprecated in favor of org.hamcrest.CoreMatchers.containsString(). Same goes for hasItem(). Change-Id: Ie11616588b126110579e92bfb4b72de022bf211c Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1410 Fix config yang generator parsing dependency containers Check if the grouping used is of type service-ref. Until now, any container containing grouping was considered a dependency. Add test for this case. Change-Id: I9299b2b39e393d940c71a41f8d33d737564f2530 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-980: stop emiting copyright This is a stop-gap quickfix to stop doing the wrong thing. Change-Id: I51a2ca012ea605632a737788005cf4143d9c1f44 Signed-off-by: Robert Varga <rovarga@cisco.com>