Move adsal into its own subdirectory. Moved various adsal components into an opendaylight/adsal subdir, gave it a parent pom, and changed the root parent pom to have the opendaylight/adsal as a module. Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Migrate bundles' configuration mgmt to ConfigurationService - Change current logic where read/save config is completely managed by each bundle, with moving it to configuration manager. This decoupling will allow configuration manager to decide how to persist the bundles' configurations to disk, withouth necessarely depend on java serialization as today controlelr does. Also now file names can be static and each bundle does not need to track the container context in the file name (which was lame). This allow controller to erase container startup files on container removal, which was not possible today. - Global and in container configuration services to expose two APIs for the other bundles to retrieve and save their config - Per container startup files organized in directories (directory name = container name) - Container startup directory removed on container removal, and created on container creation if not present Change-Id: I58c283eb796cf2a60466a97162428a8c2ae478ae Signed-off-by: Alessandro Boch <aboch@cisco.com>
Fixed inappropriate uses of log level INFO This is done per the recommendation here: https://wiki.opendaylight.org/view/Draft_Syslog_Level_Settings Change-Id: I69bbe15d81ed49511f643fd4a8c0ad60f58a0c22 Signed-off-by: Ed Warnicke <eaw@cisco.com>
The config now is loaded only from the coordinator. The previous way of loading the config only if empty had some side-effects. Change-Id: I4f1819c60b491a36e1c14a78ec376e2dfcee8583 Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
HostTracker hosts DB key scheme implementation Requirements :- i) IP only scheme for hosttracker hosts db key is by default supported. ii) IP + MAC scheme for hosttracker hosts db key addition. iii) Only one scheme at a time will be active. The configuration is controller by the setting hosttracker.keyscheme in config.ini. By default it has a value of zero which indicates IP only scheme. The value 1 can be set for choosing IP+MAC scheme. Changes done :- i) Marker interface named IHostId is used for the implementation. ii) IPHostId and IPMacHostId are the classes which implement the marker interface. iii) All the hostttracker apis have been aligned to the new key using the marker interface IHostId as the key. iv) Version of the hosttracker and it's dependent bundles like arphandler,loadbalancer,static routing etc.. have been bumped up. v) HostIdFactory has been provided to create the keys based on the scheme the user is using. Tests done :- i) pingall has worked. ii) NB APIs of hosttracker. Made distribution changes which were needed and other pom changes as well. Integration test for hosttracker has been fixed with the right version. Other module integration test failures and review comments have been taken care off. Host DB Key classes have been serialized. Change-Id: I328a1b6d3702d5268832f0e3ea6ee47122f20205 Signed-off-by: Deepak <dudapudi@in.ibm.com>
Remove commented out code to fix sonar warnings Change-Id: I541069ede01e456824e8e10eb196a34e477bdbd8 Signed-off-by: Alissa Bonas <abonas@redhat.com>
Couple of changes 1. StaticRoutingImplementation now updates cache after updating nodeconnector for \ the static route 2. The clone method of MatchField now clones the valid flag and the type Change-Id: I7e4e274742a4680f1369eecbeff155bbede3283c Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
Remove unused class member SAVE. Change-Id: I936914928b92b314bd9aa5e9b0d4454a53cc0722 Signed-off-by: Alissa Bonas <abonas@redhat.com>
Misc fix for some error seen during IT and javadoc - Silent StaticRoutingImplementation when thread is interrupted, it can happen. - During IT logging bridge complain for a null exception because unhandled. - Fix some deprecation warning not really needed and some spellings in javadocs Change-Id: Id6daa0560943a52b25fbdd4b8a24624e0254353e Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Fix bug in Static Route configuration path ISSUE: Multiple equivalent static route configurations with different names not detected CHANGE: In addStaticRoute() perform proper equality check on existing StaticRoute objects (using available StaticRoute compareTo() method) instead of checking on StaticRouteConfig objects which can never be positive as same name config is detected at the beginning of method Change-Id: I51d2e1a641f612f5e79eb11063a868739a275209 Signed-off-by: Alessandro Boch <aboch@cisco.com>
Migrating caches to TRANSACTIONAL Caches and enabled use1PcForAutoCommitTransactions. In addition, - Removed all the unused Caches (especially the save event cache). - Changed ARP Handler's ICacheUpdateAware processing to not process the cache event in its own thread (instead of the infinispan's thread). Change-Id: I608aecd425d0394ba9c4e665424c82790bb874ca Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
Out of Memory when static Routes are configured with unresolved next hop Root cause: This problem happens when there are staticRoutes configured but their next hop IP are unresolved (ie. not responding to ARP Request). StaticRouteImpl.java spawns a thread requesting hostTracker to discover the host, this thread is waiting forever due to a bug in the thread (HostTrackerCallable) that handles the discovery which never returns since the host is not responding. Solution: - Instead of creating threads dynamically, we create a threadpool of 2 and reuse the threads. - Fix the bug in HostTrackerCallable to sleep(2000) and returns. Change-Id: Ic04d1dbaf17d5cd6672646050d71abb9885695e9 Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
HA - Cache synch for Topology Manager - Allocate/retrieve cluster cache for topology mgr caches - Remove destroyCache from bundle shutdown callbacks in HostTracker, TopologyMgr and StaticRouting - Style fixes Change-Id: I352f5cb4cfab8fd06b15be708cf07ae1ef64c9bf Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
Checkstyle enforcer Started to enforce checkstyle, if the code style doesn't match the checkstyle settings build will break. This is needed in order to make sure folks comply to one code style and don't start diverging. For now the enforcement is only limited to: - make sure no TABS are present in the java files - make sure that no trailing whitespaces are present Along with code style enforcement updates all the files that didn't comply else compilation would not be successful. Added new exclusion in .gitignore Added new parent for commons.opendaylight, please read the README in the commons.parent project for the reason for it. Make sure the violation of checkstyle are reported on the console to avoid for a developer to be able to dig through the log in the target directory Change-Id: I4e35aa74e685e5cebb8182caf0b3b39da0906948 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Revert "Checkstyle enforcer" This reverts commit 541d0a36997f292bb037a2199463431eee538358 We are going to talk a bit more about this before doing it. Change-Id: I788ecea18796c6eb325285dfaa83a6aae300634c
Checkstyle enforcer Started to enforce checkstyle, if the code style doesn't match the checkstyle settings build will break. This is needed in order to make sure folks comply to one code style and don't start diverging. For now the enforcement is only limited to: - make sure no TABS are present in the java files - make sure that no trailing whitespaces are present Along with code style enforcement updates all the files that didn't comply else compilation would not be successful. Added new exclusion in .gitignore Change-Id: Ic95da373575cec3cfe0c99b31fce92f66bc41263 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Update comments for JavaDoc Added comments for the followings interfaces: IForwardingStaticRouting, IRouting. Removed the method saveConfig() from IForwardingStaticRouting since it is not a public method and is only use privately. Change-Id: I15e15916287fe05a02e31536e064fb78c827c26a Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
Logging related enhancements. Signed-off-by: Madhavan Kasthurirangan <mkasthur@cisco.com>
Redirecting Caught and Uncaught Exceptions to OSGI Console and Log File The existing mechanism int the Controller allows the exceptions to be printed only the console. This applies to both caught and uncaught exception. If the console buffer is not too large and gets overwritten or gets cleared, there is no way for the user to know what exceptions occurred. This commit implements a new mechanism by which both types of exceptions will get printed on the console as well as logged to the file. Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
OpenDaylight Controller functional modules. Change-Id: I1cd6668738099e8db3cfe83f812a92c922ced38c Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>