Move adsal into its own subdirectory. Moved various adsal components into an opendaylight/adsal subdir, gave it a parent pom, and changed the root parent pom to have the opendaylight/adsal as a module. Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Incrementing versions by 0.1.0 for post-Helium master branch * The only version not incrmented is aaa.version, which is left at 0.1.0-SNAPSHOT since they depend on controller and can't update yet. * To break the cyclic dependency, this patch temporarily stops running the netconf-connector and restconf feature tests. * Also fixing a bug causing Errors like "Choice has two nodes case with same qnames". A second patch (to be run after AAA increments their versions to 0.2.0-SNAPSHOT) wiil update aaa.version and re-enable these tests. Change-Id: I70a3987d32504e798c5ed05a67a0a1174338844b Signed-off-by: Colin Dixon <colin@colindixon.com> Signed-off-by: Robert Varga <rovarga@cisco.com>
Flow request containing an invalid action should be rejected When ODL Controller receives a request to install a flow, it is processed by FlowConfig class in forwardingrulesmanager bundle. There is method named "validate" which validates the matches and actions specified in the flow request. If this method encounters an invalid action, it simply ignores it and moves to the next action. The result of this behavior is that if flow request contains only one action and it happens to be invalid, the FlowMod request will be sent to the switch without any action. An OVS conforming switch will install this flow and set the action to drop. However, ideally Controller should reject this request (or any request containing an invalid action). Few invalid unit test cases were also escaping due to this error, which have been corrected. Change-Id: I4df3226d6ec9c663476cae1991c194bc36cb2f99 Signed-off-by: maquresh <maquresh@cisco.com>
Unify maven-bundle-plugin version at 2.4.0 This removes superfluous version declarations, fixing about 70 eclipse warnings. At the same time it bumps the version 2.4.0, to unify it -- we were using both 2.3.7 and 2.4.0 at the same time. Change-Id: I0f3f6b68c5c05cb9cc226f75b4eb4dab7d58651d Signed-off-by: Robert Varga <rovarga@cisco.com>
FRM should use async function on southbound event - On reacting to southbound events (switch up/down, ports added/removed, ...) FRM is supposed to use asynchronous calls for flows installation/removal. This is needed because these events may affect a large number of flows, for which we do not want to slow down the processing via sync calls. Also, logic has been we never do process synchronously a southbound event. - In case of port up, FRM was still using a synchronous call. This patch is for taking care of that. Change-Id: I4b6dae0df75ad778ea2f1d555a258a48ea66c57b Signed-off-by: Alessandro Boch <aboch@cisco.com>
Adding auto-sorting plugin to all Controller via parent/pom.xml leveraging google's sortpom plugin, all controller poms are sorted at build time as per the opendaylight/commons/parent/pom.xml configuration. Sorted lists of properties, dependencies, and plugins will increase pom readability and help prevent duplicate entry errors. This first submission is huge as I changed one pom.xml and all are then sorted. Only if the sortpom plugin is reconfigured will all pom's again be changed. Note that if any pom.xml is pushed without having been through a build ... folks are going to see pom.xml files showup as modified unintentionally. Change-Id: I8553f38b9f0e5f6d27177ad6b9b9c35a4b43d55a Signed-off-by: jameshall03885 <ghall@brocade.com>
Unify jacoco versions to 0.6.2.201302030002 This cleans up previously unused pluginManagement sections and bumps jacoco version 0.6.2.201302030002 (previously used by config subsys). Change-Id: I027b219e7fd0225fe2ef12cbdcc1f7d47509e993 Signed-off-by: Robert Varga <rovarga@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Add async addStaticFlow api to FRM Change-Id: I6189ab2f617895a780bd14b9a620250476058da5 Signed-off-by: Alessandro Boch <aboch@cisco.com>
Add Enqueue validation check in FlowConfig Backend validation to check enqueue queue is within range 0 - 2147483647 Change-Id: Ib17f3259a75fe3553455775bf7f26649ced40612 Signed-off-by: Andrew Kim <andrekim@cisco.com>
Merge "FlowConfig to only run syntactic validation"
Eliminate superfluous pluginManagement section This structure is a recipe for a warning: jacoco.version is specified in a parent pom, so there is no use specifying it in the pluginManagement section here. Rather move it to the parent -- where it belongs. Change-Id: Iadc84620ad69cccd681b9898ab87459520daafd5 Signed-off-by: Robert Varga <rovarga@cisco.com>
We already have a merged and validated flow entry. There is no need for extracting the original flow entry and then validating and merging it again with the containerflow. Change-Id: I131abdefc3bde14b148af0264cd220ea0c61c528 Signed-off-by: Asad Ahmed <asaahmed@cisco.com>
FlowConfig to only run syntactic validation - The validate function of FlowConfig class should only run syntactic validation The opearational validation like input/output/enqueue port presence, flood action on non default container check, etc. should be run only at installation time. Also this validation should be run for all the flow installation requests either they come from static flow config or from Flow Entry install/modify request coming from other bundles. - With the above change at controller restart, static flow configurations which were valid at controller stop but no longer after reboot (for ex. switch sdn enabled ports have changed) will still show on the Flow GUI as non installed, and their toggling with fail with proper message. Change-Id: I49d97af49d58102e51a3c8c12db915b60bcb6f4b Signed-off-by: Alessandro Boch <aboch@cisco.com>
Requestor FRM to update the sw views on remote execution - When FRM relay the flow add/remove/modify action to an executor FRM on another cluster node, it should be in charge of updating the sw view caches. As this happens inside the caller application's transaction. Currently the executor updates the cache, update which is not reflected in the requestor until the caller application commits the transaction. Change-Id: I36f3efa2770e71c24e0d059d6bf08eee2c1684f5 Signed-off-by: Alessandro Boch <aboch@cisco.com>
Merge changes I8c23739a,Ia0e70828 * changes: Bulk-add copyright headers to java files Bulk-add copyright headers to .xtend files