BUG-2637: migration final - cleanup - remove migrated features (feature-flow, odl-adsal-compatibility) - remove migrated apps (model-flow*, sal-compatibility, sm, im, tp, frm) - remove temporary fix in toaster-it Change-Id: Ida315250f0035e09aa2e2afd0f8df076d9770861 Signed-off-by: Michal Rehak <mirehak@cisco.com>
Bug 2368: MD-SAL FRM may update/remove unexpected flow entries. FRM should always set strict flag into update-flow/remove-flow RPC input. Change-Id: I6027442b56f4cd93cfc3f954dc8501bb57e2d64a Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
bug 1888 - FRM Flow Listener registration fail * sometimes BindingAware doesn't load codec, so FRM try to register listener 5x and after rise IllegalStateException system needs to start again. Change-Id: I47def2f4ebd6605eb00942ed56f762cb7465592e Signed-off-by: Vaclav Demcak <vdemcak@cisco.com> Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
BUG-1871: FRM rpc register path (nodeIdent) - removed FlowCapableNode from the end of provider lookup identifier Change-Id: I7939a1dd8f2bcef60c3ca18600350515985598c3 Signed-off-by: Michal Rehak <mirehak@cisco.com> Signed-off-by: Robert Varga <rovarga@cisco.com>
Bug 1699 - FRM: Change data change listener scope from BASE to SUBTREE * changed data change listener scope from BASE to SUBTREE Change-Id: Ifbc161c2c709157d5665fae9e49059477053ff82 Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
FRM performance refactoring: * Interface definitions for FRM functionality * ForwardingRulesManager (old provider) * ForwardingRulesCommiter (DS changeListener/sender for SalServices) * FlowNodeReconciliation (reconcil contract definition) * Centralization Provider/Manager bundle functionality * fix possibility not unique transaction ID * implement active NodeHolder (remove unnecessary Operation/DS check) * Listeners * identify correct data by wildCarded InstanceIdentifier * move registration functionality to listener class * remove all unnecessary functionality * functionality fragmented * Cleaning * move FlowCookie to StatistManager (performance killer, fixing update Flow functionality, possibly speed up delete functionality) * cleaning unnecessary object creation * Added MockTests tests PASS: https://jenkins.opendaylight.org/integration/job/integration-master-csit-base-of13/ (Base-OF13/AD_SAL_NSF/TopologyManager/getTopology sometimes fail) Change-Id: If5ec9920e4574bd170192b14ca978fb628fd051b Signed-off-by: Vaclav Demcak <vdemcak@cisco.com> Signed-off-by: Jan Hajnar <jhajnar@cisco.com> Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Fixed possible NPE in flow reconciliation Code assumed non-null lists when processing augmentation but Binding Specification allows null to be present. Change-Id: Ifec62afc2ffd9eb3073685251b62359591ee955d Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
bug 537 - Node Reconciliation https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:Backlog:Node_Status_Reconciliation * FRM Reconciliation Notify Listener (DataChangeScope.BASE for FlowCapableNode in DataStore/OPERATIONAL) * FlowCookieProducer - MapHolder for an unique relation flow_cookie to flow_id via FRM * FlowStatTracker changes * search flow_id by flow_cookie for exist flow * add flow_id - flow_cookie for new Flow * FRM migration for new DataBroker API * merge with new DataStore/OPERATIONAL hierarchy (Flow vs. FlowStatistics) * fixed flow delete - generated cookie is bypassed with mask=0 In additional commit has fixed Bug 282 - Pre-configuration of flows causes exception + remove the transaction validators - not needed for now Change-Id: Iadc2b111780524b9a8fd86cfc248e5fa194e6638 Signed-off-by: Vaclav Demcak <vdemcak@cisco.com> Signed-off-by: Michal Rehak <mirehak@cisco.com>
BUG-272: remove trailing whitespace from Java files Preparatory patch, bulk-removes all trailing whitespace from Java files. Change-Id: I1fbef5746df7277b3865429d4faa82fc8ba8cbb5 Signed-off-by: Robert Varga <rovarga@cisco.com>
Bug 740: Forwardingrules-Manager support for DataChangeListeners + Bug 619 - Eliminate the use of xtend in md-sal/forwardingrules-manager migration from xtend to java files FRM add DataChangeListener to FRM (Flow, Meter, Group) remove FRM handlers (Flow, Meter, Group) fix delete changes registration (in ImmutableDataChangeEvent -> old DataStore) Change-Id: I56003833519d9689a489ed5f77b3f7fc4ac2e204 Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Bulk-add copyright headers to java files Change-Id: I8c23739a21f3f6cecb138f62a54efbabf03b9c55 Signed-off-by: Robert Varga <rovarga@cisco.com>
Bulk-add copyright headers to .xtend files Change-Id: Ia0e70828399607e3e5b4193e01200420f85c0a8a Signed-off-by: Robert Varga <rovarga@cisco.com>
removing the old FRM code Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com> Change-Id: I43c97b6b0e430f7085c81b855e343c9c7b8e60ce
Updated review comments.Bulk transaction support added trasaction attribute with RPC inputs Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com> Change-Id: Ia7fe0d53730fd5c2e0eb92abb622c8711bf393d1
modified the FRM for group and meter to send ref to plugin for events Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com> Change-Id: I346dff61b8bb2815b011ac089b46d2ac928f3f64
Added notification for Flow add/delete/update. Flow ref added to all Flow notification RPC messages. Flow ref needed to for NSF to co-relate XID with the operation. FlowTransaction.xtend modified to put flow reference. Signed-off-by: Prasanna Huddar <prasanna.huddar@ericsson.com> Change-Id: I76406f995b2bdd0e0c3c6ffea98bd28c8fe90cec
Fix to allow RESTCONF PUTing of Flows - Due to a bug in the JAXB spec, which is propogated to JAXRS, which forbids '/', even escaped, in path segments in URLs... we can't use the nesting by refs under /flows. - Therefore I've moved flow config to nodes -> node -> table -> flow - Making that change in the existing FlowConsumerImpl proved extremely hard. Due to the press of time I've introduced a very simple set of FlowProvider, FlowCommitHandler, FlowTransaction, FlowTransactionValidator, to cleanly separate the logic. We can migrate over the validation rules as need be. PatchSet 11: Abstract the Transaction. Add Groups. PatchSet 12: Fixes for Meters PatchSet 13: Yet another rebase PatchSet 14: Squashing https://git.opendaylight.org/gerrit/#/c/3304/8 Must proceed: http://git.opendaylight.org/gerrit/3596/1 in openflowplugin Change-Id: I1f1cd04a04f7a30630062725e63112cda4b049f1 Signed-off-by: Ed Warnicke <eaw@cisco.com> Signed-off-by: Tony Tkacik <ttkacik@cisco.com>