Remove deprecated MD-SAL APIs The APIs in controller have been deprecated for removal and cannot sustain an upgrade to Guava-28+. Remove them along with all supporting implementations. JIRA: CONTROLLER-1903 Change-Id: I213797b7045cfd7bef744e249614e2b1f6169c1c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate old MD-SAL APIs for removal These APIs are slated for removal in Aluminium, make sure our warning is more stern. JIRA: CONTROLLER-1917 Change-Id: Ib4f7dcfd5183b87dd10b9ce2b773a59a548892c9 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump odlparent to 6.0.0 This bumps odlparent to 6.0.0 as part of Magnesium MRI. Change-Id: I084c6a32c4facafd85e3b87c6d8a9a29a33848a8 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate all MD-SAL APIs These APIs have either been completely deprecated or have their replacements in the mdsal project. Mark all of them as deprecated, including their implementations. JIRA: CONTROLLER-1902 Change-Id: I903afcef57c70c1013ab479cfcf31a42f475dc0f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Reduce JSR305 proliferation retention=runtime annotations are mixing really badly with Java EE injection and Java 11. Make sure we do not use javax.annotation package in APIs and reduce overall proliferation inside implementations. Change-Id: I569815f0336efdc0de662c3b80f0fa6e5dd47d8a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix findbugs warnings Upgraded findbugs finds these, fix them up. Change-Id: Id5a008cddc6616c3a93f0528efca00b86843fc3c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Allow filtering transaction traces with a minimum This adds a "minimum open number of transactions" option to trace:transactions and print out a clear final message indicating whether any leaks were found or not. JIRA: CONTROLLER-1765 Change-Id: Ie9f4ee263ed7defcb84c8b82dc8ec6f1f81ba07d Signed-off-by: Michael Vorburger <vorburger@redhat.com> Signed-off-by: Stephen Kitt <skitt@redhat.com>
fix tracing ping-pong DataBroker wiring bug in trace blueprint XML JIRA: CONTROLLER-1834 Change-Id: I4fda43c578ee55218acc40be1fbf4427c81c73c3 Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Remove DataChangeListener and friends AsyncDataChangeEvent is being kept for now as ovsdb still independently uses it internally. JIRA: TSC-112 Change-Id: Ia68ac1cdf31dec3645f675442db14b7697d63b64 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
sort by descending number of suspected transaction leaks in trace output Change-Id: I7b780c3df72f87f6f1e693e9ec995a8f48da5c3b Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Fix findbugs violations in md-sal - part 3 - sal-binding-broker - sal-connector-api - sal-dummy-distributed-datastore - messagebus-impl - mdsal-trace-dom-impl - May expose internal representation by returning reference to mutable object - May expose internal representation by incorporating reference to mutable object - Private method is never called - Non-transient non-serializable instance field in serializable class - Class is Serializable, but doesn't define serialVersionUID - Parameter must be non-null but is marked as nullable - Unread field - Consider returning a zero length array rather than null - Useless object created - Method ignores return value - Incorrect lazy initialization of static field - Should be a static inner class Change-Id: Ia8847db80bca98c6f7ff7aae267efc408a5dd8fd Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix checkstyle reported by odlparent-3.0.0 Change-Id: I08c548fbbbef8527ad7b037b0def33d3c1c09bf6 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
mdsal-trace: log whether listeners are ClusteredDOMDataTreeChangeListener Change-Id: Ia7f5d7e722fa0b5400fc10ff72dd1eb0e575f2d0 Signed-off-by: Josh <jhershbe@redhat.com>
TracingBroker: collapse ellipses This avoids printing multiple "(...)" lines in succession. (The test is made a little more change-resistant by removing the expected line number.) Change-Id: I9ede5d0d15afecb06c61cbe2b2c5a70967616280 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 9060: Filter TracingBroker stack trace elements Just to make them a lot easier to read, because what is really interesting in them is the "middle part" (before the trace close tracking infra classes and after the lower level e.g. BP set up class stack frames). Change-Id: I5f90b69a10ec0ea3f3e3407279c523751813418d Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Bug 9060: Karaf CLI command to print open transactions including some minor changes to make output more pretty / readable. This is, for now, the last in a serious of commits which is part of a solution I'm proposing in order to be able to detect OOM issues such as Bug 9034, based on using the mdsal-trace DataBroker. Change-Id: I83af00a0713be4e8fab3085942b7b57d7183a20c Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Bug 9060: TracingBroker printOpenTransactions This method is intended to be used from a Karaf CLI command in the next change (and maybe JMX or something else like that later), which can be invoked during future automated testing to detect Tx leaks during CSIT. This is one of a serious of commits which is part of a solution I'm proposing in order to be able to detect OOM issues such as Bug 9034, based on using the mdsal-trace DataBroker. Change-Id: I682700bef9644834e8b4ca36b21729f021a76bf0 Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Bug 9060: mdsal-trace tooling with getAllUnique() to find Tx leaks This is one of a serious of commits which is part of a solution I'm proposing in order to be able to detect OOM issues such as Bug 9034, based on using the mdsal-trace DataBroker. Change-Id: I9cf4d8d9965468d77a0d82455655b9445535f0b0 Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Bug 9060: TracingBroker with transaction-debug-context-enabled This is one of a serious of commits which is part of a solution I'm proposing in order to be able to detect OOM issues such as Bug 9034, based on using the mdsal-trace DataBroker. Change-Id: If62b7f76ea03d8cabe0c5a2088983275cfe50e44 Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Bug 9034: TracingBroker with TracingReadOnlyTransaction The new TracingReadOnlyTransaction wrapper doesn't do anything interesting yet - but it will, in the related upcoming next change. This is one of a serious of (small, easy to review) commits which is part of a solution I'm proposing in order to be able to detect OOM issues such as Bug 9034, based on using the mdsal-trace DataBroker. Change-Id: Ifa82c50d9c9eac76af99bf6a58e5e1955ee7429c Signed-off-by: Michael Vorburger <vorburger@redhat.com>