Remove odl-controller-exp-messagebus Messagebus bridge is an unfinished concept, which was never productized. It was deprecated in previous release, now we remove it. JIRA: YANGTOOLS-1974 Change-Id: I8d544f8edf54bcacfb36419badb5003976e6b409 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate messagebus for removal This component is going away, deprecate it. JIRA: CONTROLLER-1973 Change-Id: I993cf6311c30b37bc64c9d7dbd244d54c26c8da5 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Convert messagebus-impl to OSGi DS messagebus-impl is an extremely simple component, convert it to Declarative Services. JIRA: CONTROLLER-1882 Change-Id: I5131530f3ba907525a7a29775136cd5123f56f18 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump odlparent/yangtools/mdsal Update upstream references to: - odlparent-7.0.1 - yangtools-5.0.0-SNAPSHOT - mdsal-6.0.0-SNAPSHOT Also adjust the codebase to match changes in yangtools/mdsal and scala-2.13. Change-Id: Ib082e955b5106fa002522dfe3d7a21fe990006d8 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix modernization issues This fixes issues pointed out by Modernizer, which mostly boil down to using Objects.requireNonNull() and direct java.util collections. Change-Id: Id32530a6722cd101f96c23f6a745f91b2f09e2f9 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Reduce JSR305 proliferation retention=runtime annotations are mixing really badly with Java EE injection and Java 11. Make sure we do not use javax.annotation package in APIs and reduce overall proliferation inside implementations. Change-Id: I569815f0336efdc0de662c3b80f0fa6e5dd47d8a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Migrate messagebus-impl to MDSAL APIs This removes yet another user of long-deprecated APIs, migrating it over to MD-SAL. Change-Id: I51f2ce0e01ed3078dbd2fa4ad6eb91081d692fa3 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix findbugs warnings Upgraded findbugs finds these, fix them up. Change-Id: Id5a008cddc6616c3a93f0528efca00b86843fc3c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fixup Augmentable and Identifiable methods changing This is a fixup of the change in binding codegen, adjusting: - getKey() -> key() - setKey() -> withKey() - getAugmentation() -> augmentation() As a drive-by cleanup, some more references to CheckedFuture are gone. Change-Id: Ifa573f93d1776ab2db98524df4da63259e811767 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Adjust for Binding RPC codegen changes This adjusts RPC implementations to conform to YANG-compatible layout with ListenableFuture. It also fixes BindingToNormalizedNodeCodec to realign it with mdsal version. Since we are guaranteed to be dealing with ListenableFutures, this patch also eliminates all references to JdkFutureAdapters. Change-Id: I068a5821493b36e03d6a34a93bf49509b970507e Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix findbugs violations in md-sal - part 3 - sal-binding-broker - sal-connector-api - sal-dummy-distributed-datastore - messagebus-impl - mdsal-trace-dom-impl - May expose internal representation by returning reference to mutable object - May expose internal representation by incorporating reference to mutable object - Private method is never called - Non-transient non-serializable instance field in serializable class - Class is Serializable, but doesn't define serialVersionUID - Parameter must be non-null but is marked as nullable - Unread field - Consider returning a zero length array rather than null - Useless object created - Method ignores return value - Incorrect lazy initialization of static field - Should be a static inner class Change-Id: Ia8847db80bca98c6f7ff7aae267efc408a5dd8fd Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix checkstyle violations in messagebus Change-Id: I4af49c607bbbd607f8ea4fbcbe43ba4f078329d0 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
DataChangeListener cleanup - Removed the DCL example from the car model - Converted messagebus-impl DCL to DCTL Change-Id: I14436f1f80642ce0d35b71be8e1ae4dae658e2a2 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Decouple message bus from netconf connector Change-Id: I6a143e868adc1e5c7a9b114798e7009bb6ef8675 Signed-off-by: Maros Marsalek <mmarsale@cisco.com> Signed-off-by: Tomas Cere <tcere@cisco.com>
Decouple config and netconf subsystems. Extract a common mapping for config pusher and config subsystem netconf Add a ConfigPersisterFacade for XML that allows reads/writes from/to config subsystem using XML format Push notifications from YangStoreService to NetconfNotificationManager instead of using custom listeners Migrate netconf features from controller features, untangle features Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca Signed-off-by: Tomas Cere <tcere@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com> Signed-off-by: Ed Warnicke <hagbard@gmail.com>
BUG 3121 - destroy topic implementation - implementing destroyTopic rpc in EventSourceTopology - add rpc dis-join-topic in event-sourec.yang and implement it - fixed bugs identified during test with real device - revision of code and cleaning up - rebased Change-Id: I0f43ef2ca1f54db5a08c379792a59c3894a77767 Signed-off-by: Marian Adamjak <madamjak@cisco.com> (cherry picked from commit d039ff1e73202fa815e72db49d63ded711386f07)
BUG 3030 - reconnect netconf event source - replay notification - publish notification about connection status (cherry picked from commit 4c147b35d298b281afccb53c7fb8b83b1b96ddfc) Change-Id: Ia6ead39a2e1a81135dcd86163fb7adb40a3d7d5c Signed-off-by: Marian Adamjak <madamjak@cisco.com>
Merge "Event Source: switch from wildcards to regexs"