Remove deprecated MD-SAL APIs The APIs in controller have been deprecated for removal and cannot sustain an upgrade to Guava-28+. Remove them along with all supporting implementations. JIRA: CONTROLLER-1903 Change-Id: I213797b7045cfd7bef744e249614e2b1f6169c1c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate old MD-SAL APIs for removal These APIs are slated for removal in Aluminium, make sure our warning is more stern. JIRA: CONTROLLER-1917 Change-Id: Ib4f7dcfd5183b87dd10b9ce2b773a59a548892c9 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Refactor AbstractBrokerAwareActivator This simplifies the implementation by encapsulating state. Change-Id: I673e71f431026302974057af5933dba14e4c19c3 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fixup checkstyle Updated checkstyle does not like some our docs, fix them up. Change-Id: I2d4f608fe9c44a56cdcac511cc1e2ae75c03b413 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate all MD-SAL APIs These APIs have either been completely deprecated or have their replacements in the mdsal project. Mark all of them as deprecated, including their implementations. JIRA: CONTROLLER-1902 Change-Id: I903afcef57c70c1013ab479cfcf31a42f475dc0f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Reduce JSR305 proliferation retention=runtime annotations are mixing really badly with Java EE injection and Java 11. Make sure we do not use javax.annotation package in APIs and reduce overall proliferation inside implementations. Change-Id: I569815f0336efdc0de662c3b80f0fa6e5dd47d8a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Introduce ReadTransaction.exists() This method exists in the DOM API, but for some reason it was left out if the Binding API. Introduce it as default methods riding on the read() method and override them in all known implementations, so the request is efficiently routed. JIRA: MDSAL-389 Change-Id: Id56332d6f720396305ac68e40554e62fd17c34fb Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Allow DataObjectModification to address grouping nodes This adds the API and implementation required to address child nodes introduced in cases by the use of a grouping. JIRA: MDSAL-342 Change-Id: I70871dcaa3441fbef81dfb15bfd965d133aa0894 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Add (DOM)Action(Provider) bridges We need to add bridge interfaces which allow NETCONF to expose DOMActionService through Controller's mountpoints. Also add binding equivalents, so users of Controller Binding have access to them. JIRA: MDSAL-283 Change-Id: Ie6b0819345928637df29c5a15bf1634f8932de19 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate controller APIs Deprecated the high-level interfaces, eg DataBroker. Change-Id: I754e3a5059c05d70616f3bd4ff3a00a05115fead Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Remove unused exceptions This drops exception declarations which are never used. Change-Id: Icc8938b9c3b437a0d5961ec1b481fd06c52d47f2 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Remove DataChangeListener and friends AsyncDataChangeEvent is being kept for now as ovsdb still independently uses it internally. JIRA: TSC-112 Change-Id: Ia68ac1cdf31dec3645f675442db14b7697d63b64 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Adjust for Binding RPC codegen changes This adjusts RPC implementations to conform to YANG-compatible layout with ListenableFuture. It also fixes BindingToNormalizedNodeCodec to realign it with mdsal version. Since we are guaranteed to be dealing with ListenableFutures, this patch also eliminates all references to JdkFutureAdapters. Change-Id: I068a5821493b36e03d6a34a93bf49509b970507e Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Default AsyncWriteTransaction.submit() Now that all downstream implementations implement commit(), the deprecated submit() method can be defaulted instead instead of commit(). Change-Id: Idd684bc3fdc7d4f048257154988ef1f7c7811e97 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>