Remove CSS modules The CSS features are still installed until we can work out the ModuleInfoBackedContext/ClassLoaderStrategy situation that is currently provided by the ConfigManagerActivator. Change-Id: Id3b2cc287d17532482a2dd893c41e2dcd8d29ff0 Signed-off-by: Tom Pantelis <tompantelis@gmail.com> Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix findbugs violations in md-sal - part 2 - sal-broker-impl - sal-dom-broker-config - sal-binding-config - sal-akka-raft-example - clustering-it-provider Violations: - Method may return null, but is declared @Nonnull - Method with Optional return type returns explicit null - Method ignores exceptional return value - Field not guarded against concurrent access - Unchecked/unconfirmed cast of return value from method - Load of known null value - Parameter must be non-null but is marked as nullable - Class implements same interface as superclass - Redundant nullcheck of value known to be non-null - Unread field - Reliance on default encoding - Should be a static inner class - Questionable cast to concrete collection - Dead store to local variable - Dereference of the result of readLine() without nullcheck - Method ignores return value - Finalizer does not call superclass finalizer - An increment to a volatile field isn't atomic - Dead store to local variable - Redundant nullcheck of value known to be non-null Change-Id: Iec7205b49a0cbafff33db97c9c753a5425f929a6 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix checkstyle violations in sal-dom-broker-config and sal-binding-config Change-Id: I5cbd04bfb598481fc6b107f426cf01819ab8d4b2 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Create a parent pom for md-sal sub-projects This will contain common configurations for checkstyle and findbugs (once all violations are fixed). Also, isolates the config system dependencies in one place which will make it easier to remove CSS. Change-Id: Ifcf4bcd5e1b96483714bad51858264f511c21237 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Switch to mdsal codec APIs Codec APIs with yangtools in their package are going away, make sure we are ready for that. Change-Id: I5515cf455df9cbdd746153a515e7102f11f02a80 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bug 8568: Removed deprecated HydrogenNotificationBrokerImpl Change-Id: I707a787b3e705fb9959056e50f06b2207933bcd3 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 8568: Remove deprecated MountProviderService from RootBindingAwareBroker The MountProviderService API has been deprecated since Helium so it should be safe to remove it from the RootBindingAwareBroker. Change-Id: I7dc7b05feaafb08004f104da8495adc87e5078b1 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 8568: Remove DataProviderService/DataBrokerService APIs Change-Id: If9b8bc26c3f4d1c5eea09c1c5ad993732fbc5f6c Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 8568: Remove deprecated HydrogenDataBrokerAdapter Removed the deprecated DataProviderService implementation class HydrogenDataBrokerAdapter and the corresponding config yang and ForwardedCompatibleDataBrokerImplModule. Change-Id: Ie18e6e1ae6a9e68b97e39b278618a4a0c1c9219d Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 8568: Remove DataProviderService from RootBindingAwareBroker Change-Id: Ib5e4f70ef72819103544cd6388558dc4a05b55d2 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
target-ide/ support by resourceBaseDir using ${project.build.directory} without explicitly setting this, org.opendaylight.yangtools.maven.sal.api.gen.plugin.CodeGeneratorImpl defaults to hard-coded target/generated-sources/spi for META-INF/services/org.opendaylight.yangtools.yang.binding.YangModelBindingProvider instead of target-ide. Minor: Also add target-ide/ to .gitignore of this git repository. Change-Id: I330646f5a4e71cda021697410d452298a4127f4f Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Revert "Clean-up pom.xml layout" Since this got merged, I'm facing issue building the project correctly, it's failing in samples/toaster-it and runtime is broken because of mess-up classpath. If others are facing the same issue, this should be merged. I'll rework the overall patch later. This reverts commit 8a637013c102c11323230dae08fa4407863945d6. Change-Id: I61aae87439736d0163e6b4c49d8753052b28bac0 Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Remove global BindingToNormalizedNodeCodec instance The BindingToNormalizedNodeCodec was made a global static instance for backwards compatibility for CSS users that inject the binding-dom-mapping-service identity which defines the provided service as the concrete BindingToNormalizedNodeCodec class instead of an interface. Therefore the global static instance was created via blueprint and advertised via its interfaces and was obtained via the static reference by the RuntimeMappingModule for use by CSS users. The RuntimeMappingModule must return an instance of BindingToNormalizedNodeCodec in order to provide the binding-dom-mapping-service so obtaining the blueprint advertised OSGi service via its interfaces and casting to BindingToNormalizedNodeCodec failed b/c Aries creates a service proxy which loses the fact that it's a BindingToNormalizedNodeCodec instance. However the global BindingToNormalizedNodeCodec instance is not clean and is problematic for supporting blueprint container restarts. Aries supports concrete class proxies so I added an additional service export for the BindingToNormalizedNodeCodec class in the binding-broker blueprint XML. In addition, the blueprint XML now calls a new method, "newInstance", on the BindingToNormalizedNodeCodecFactory to create a new instance and calls a new method, "registerInstance", to register it with the SchemaService. The returned ListenerRegistration instance is put into a bean so it can be closed on destroy. The RuntimeMappingModule now obtains the BindingToNormalizedNodeCodec instance from the OSGi registry as the other blueprint-bridged CSS modules do. This eliminates the need for the global instance. Change-Id: I969ad5470967a81b37078393701c69d1898086cd Signed-off-by: Tom Pantelis <tpanteli@brocade.com>