Remove deprecated MD-SAL APIs The APIs in controller have been deprecated for removal and cannot sustain an upgrade to Guava-28+. Remove them along with all supporting implementations. JIRA: CONTROLLER-1903 Change-Id: I213797b7045cfd7bef744e249614e2b1f6169c1c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Suppress modernization Modernize as much as possible, but as we have legacy APIs in play, we have to add also some suppressions. Change-Id: I844821f129ad0bb0e186b6a4848a6d2937513f7b Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Another round of checkstyle fixes This fixes failures reported by upgraded checkstyle, as well as some non-enforced violations. Change-Id: I8b6a9667c6586bef528587d455f7a8597b4f483f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Cache reflection operations in AbstractSchemaAwareTest The design of AbstractSchemaAwareTest requires reflection-based loading of SchemaContext for each test case, which is slow. Instantiate weak caches to speed up tests which are co-located on the same class loader. Change-Id: I1a79d7e99f6efcccab37445f3de25a74cb6f02b6 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove unused exceptions This drops exception declarations which are never used. Change-Id: Icc8938b9c3b437a0d5961ec1b481fd06c52d47f2 Signed-off-by: Stephen Kitt <skitt@redhat.com>
Use moved BindingReflections BindingReflections are being evacuated from yang-binding, use them from their new location. Change-Id: Ib14971102980688227f1f761c17a22362d4e7e3c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix DOMRpcRouter breakage from mdsal MD-SAL's DOMRpcRouter no longer directly implements services, acquire them from the accessor methods. Change-Id: Icf337e8b8183726c87bf38d3252dccb0b911ba17 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Restore binding RPC shortcut The binding -> binding RPC serialization shortcut was broken by recent changes so restore it. The LazyDOMRpcResultFuture from the binding adapter is preserved by DOMRpcRouter via intermediate DOMRpcResult adapters. Change-Id: I98942471f4e8430d0043f5c09cb8a38ce2a5d7b9 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fixup Augmentable and Identifiable methods changing This is a fixup of the change in binding codegen, adjusting: - getKey() -> key() - setKey() -> withKey() - getAugmentation() -> augmentation() As a drive-by cleanup, some more references to CheckedFuture are gone. Change-Id: Ifa573f93d1776ab2db98524df4da63259e811767 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Remove DataChangeListener and friends AsyncDataChangeEvent is being kept for now as ovsdb still independently uses it internally. JIRA: TSC-112 Change-Id: Ia68ac1cdf31dec3645f675442db14b7697d63b64 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Convert DCL tests to use DTCL Change-Id: I05bd3a9b42e1ab3d9a1e682aaacb585aee313e7a Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Adjust for Binding RPC codegen changes This adjusts RPC implementations to conform to YANG-compatible layout with ListenableFuture. It also fixes BindingToNormalizedNodeCodec to realign it with mdsal version. Since we are guaranteed to be dealing with ListenableFutures, this patch also eliminates all references to JdkFutureAdapters. Change-Id: I068a5821493b36e03d6a34a93bf49509b970507e Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Default AsyncWriteTransaction.submit() Now that all downstream implementations implement commit(), the deprecated submit() method can be defaulted instead instead of commit(). Change-Id: Idd684bc3fdc7d4f048257154988ef1f7c7811e97 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Add AsyncWriteTransaction.commit() Equivalent to the recent md-sal API addition. The CommitInfo class is re-used from md-sal. I also modified all implementations in the controller to implement commit even though it's defaulted. As soon as implementations in other projects do the same then we can default submit(). Change-Id: I0801d5aa4c197177af838e7fbb71b7766a90e043 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Adjust unit test to YangModuleInfo API change YangModuleInfo has better interface, hence we can take advantage of it. Change-Id: I971bd0bd9fe521b63bb0133fdac3a1b1a30504a7 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Add default implementation for AsyncWriteTransaction#commit This method has been deprecated for quite some time and time for removal. There are still sub-classes in other projects that override it so first add a default implementation to throw UnsupportedOperationException. When patches are merged in the pther projects, we can remkve this method (and TransactionStatus). Change-Id: I5e3581d50a4f92df3984a663d04ce026a52252b2 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Adjust to yangtools-2.0.0 changes Change-Id: Ib86747e5ed19c0c00bb46b8d7e4936f4d90c4364 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> Signed-off-by: Stephen Kitt <skitt@redhat.com>
sal-binding-dom-it: use lambdas This series of patches uses lambdas instead of anonymous classes for functional interfaces when possible. Lambdas are replaced with method references when appropriate. Change-Id: Id3c04094ba78356b59e3faaf3ae7bb9008146f5a Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 8568: Remove deprecated MountProviderService from RootBindingAwareBroker The MountProviderService API has been deprecated since Helium so it should be safe to remove it from the RootBindingAwareBroker. Change-Id: I7dc7b05feaafb08004f104da8495adc87e5078b1 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 8568: Remove deprecated HydrogenDataBrokerAdapter Removed the deprecated DataProviderService implementation class HydrogenDataBrokerAdapter and the corresponding config yang and ForwardedCompatibleDataBrokerImplModule. Change-Id: Ie18e6e1ae6a9e68b97e39b278618a4a0c1c9219d Signed-off-by: Tom Pantelis <tompantelis@gmail.com>