Remove deprecated MD-SAL APIs The APIs in controller have been deprecated for removal and cannot sustain an upgrade to Guava-28+. Remove them along with all supporting implementations. JIRA: CONTROLLER-1903 Change-Id: I213797b7045cfd7bef744e249614e2b1f6169c1c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Another round of checkstyle fixes This fixes failures reported by upgraded checkstyle, as well as some non-enforced violations. Change-Id: I8b6a9667c6586bef528587d455f7a8597b4f483f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Cache reflection operations in AbstractSchemaAwareTest The design of AbstractSchemaAwareTest requires reflection-based loading of SchemaContext for each test case, which is slow. Instantiate weak caches to speed up tests which are co-located on the same class loader. Change-Id: I1a79d7e99f6efcccab37445f3de25a74cb6f02b6 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Use moved BindingReflections BindingReflections are being evacuated from yang-binding, use them from their new location. Change-Id: Ib14971102980688227f1f761c17a22362d4e7e3c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fixup Augmentable and Identifiable methods changing This is a fixup of the change in binding codegen, adjusting: - getKey() -> key() - setKey() -> withKey() - getAugmentation() -> augmentation() As a drive-by cleanup, some more references to CheckedFuture are gone. Change-Id: Ifa573f93d1776ab2db98524df4da63259e811767 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Bug 8568: Convert sal-binding-dom-it tests to use DataBroker Converted the tests in sal-binding-dom-it to use the DataBroker API instead of the deprecated DataProviderService. Change-Id: I6d4a3442d3c5cf5ddf34806b6a71454c48e3b54a Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Remove deprecation suppression Suppressed deprecation leads to false sense of completeness. This patch removes suppression in tests, so we see how muchh of the code relies on deprecated APIs. Change-Id: I01d56f3ef4fe385806a8fbebdbe96fd6af63828c Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-2682: switch sal-binding-dom-it to sal test models - DilcardedDataChangeListenerTest - ConcurrentImplicitCreateTest - BrokerIntegrationTest - ChangeOriginatedInDomBrokerTest Change-Id: I20f2c6d5d93a535f0ccfb0efc484ec099a75f53b Signed-off-by: Michal Rehak <mirehak@cisco.com>
Bug 2682 - Switch sal-binding-dom-it to sal-test-model * Migration to sal-test-model Change-Id: If46014ec4cc8b3311a7766bcb2cb9a61b9e71592 Signed-off-by: Jan Hajnar <jhajnar@cisco.com> Signed-off-by: Martin Bobak <mbobak@cisco.com> Signed-off-by: Michal Rehak <mirehak@cisco.com>
Fix compilation warnings: replace deprecated junit.framework.Assert Replace deprecated junit.framework.Assert with org.junit.Assert. Change-Id: I94fb065d9015955f2abc91a95be0a4137717e485 Signed-off-by: Gary Wu <gary.wu@gmail.com>
Bug 865: Fixed use of removed deprecated YANGInstanceIdentifier methods. Some components in controller still used methods which was deprecated before Helium and was removed after Helium was released to accomodate API changes for 0.7.0 Yangtools. This patch migrates code to replacement methods. Change-Id: Ia7ef044eb3af4f5652dc71d9cba2bb64efd95187 Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
BUG-1092: adjust to YangInstanceIdentifier This is a compation to I1e30a0df93d8bfb891d047c58abcb117d4006c76, adjusting the components to use the new name. Change-Id: I615763240581e850f7752f82e44d752c8fceb169 Signed-off-by: Robert Varga <rovarga@cisco.com>
Minor cleanup of test suites in MD-SAL - Added SuppressWarning("deprecation") to test suites which test backwards compatibility with Hydrogen APIs - Marked test which needs to be rewritten for new DataBroker API - Removed superflous version for test dependencies Change-Id: I6e8805e1895bc2171aa5c653d8d87fd8b5c9055b Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Bug 1227: Removed #close() from Write Transactions. Termination of write transactions was unclear due to several terminal methods such as commit, cancel and close. Close was removed from write transactions and is only available for read-only transactions. Termination methods for write transactions are close and commit. Introduced new interfaces for ReadOnly transactions to clearly distinguish between read capability of transaction and read-only semantic (which has close method). Change-Id: I74b3fd2066a55160da3b674156fc0dc54ba14a67 Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
BUG-868: stop using InstanceIdentifier.builder() The static helper method has been deprecated. Use either the non-static one, or child()/augmentation() helpers. Change-Id: Ic69057d2db669153dde60ba1797e8139623a755c Signed-off-by: Robert Varga <rovarga@cisco.com>
Bug 509: Added support for merge operation to InMemoryData Store Merge operation support is critical for backwards compatibility and for Binding-Aware mapping and Restconf, which are not aware of Mixin nodes representing lists, leaflists and choices. Semantics of merge operation are similar to subtree modified, but when node is not existing it creates one based on state provided by user of the Data Broker APIs. Merge operation also fixes concurrent creations of mixin nodes as demonstrated in ConcurrentImplicitCreateTest, where two separate applications may indirectly create same root node. Change-Id: I9ab290b512601bd99750a68ee53564e67ef0c879 Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
BUG-509, BUG-808: Added datastore support for lists without keys. The datastore needs to support users who do not specify a list key, but how expect the item ordering to be retained. Added test which test all three possible behaviours of list statement: ordered map, unordered map and list without keys. Change-Id: I9e136267f57a88e4d2a6a4476025c33497373518 Signed-off-by: Tony Tkacik <ttkacik@cisco.com> Signed-off-by: Robert Varga <rovarga@cisco.com>