Remove deprecated MD-SAL APIs The APIs in controller have been deprecated for removal and cannot sustain an upgrade to Guava-28+. Remove them along with all supporting implementations. JIRA: CONTROLLER-1903 Change-Id: I213797b7045cfd7bef744e249614e2b1f6169c1c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate old MD-SAL APIs for removal These APIs are slated for removal in Aluminium, make sure our warning is more stern. JIRA: CONTROLLER-1917 Change-Id: Ib4f7dcfd5183b87dd10b9ce2b773a59a548892c9 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Migrate from YangInstanceIdentifier.EMPTY This migrates to the replacement empty() method. Change-Id: I32ca026a33835edb16f8e1e6142e9192c880076b Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate all MD-SAL APIs These APIs have either been completely deprecated or have their replacements in the mdsal project. Mark all of them as deprecated, including their implementations. JIRA: CONTROLLER-1902 Change-Id: I903afcef57c70c1013ab479cfcf31a42f475dc0f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Reduce JSR305 proliferation retention=runtime annotations are mixing really badly with Java EE injection and Java 11. Make sure we do not use javax.annotation package in APIs and reduce overall proliferation inside implementations. Change-Id: I569815f0336efdc0de662c3b80f0fa6e5dd47d8a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Proxy MD-SAL interfaces in DOMMountPointServiceImpl This patch deals with the case where a mount point is registered via Controller interfaces and then accessed via MD-SAL interfaces by providing any missing MD-SAL services via proxies built on top of their Controller counterparts. This also adds utility convertors to DOM{DataTree,Rpc}Identifier, so they are readily available. JIRA: CONTROLLER-1869 Change-Id: Iece3f1d2a2bba58669114f6f8b8abf89fd188690 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix DOMDataReadTransaction javadoc Remove double start of the javadoc. Change-Id: I6524d117e3eecaeda77c0e7b40a50053dc944b96 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Add (DOM)Action(Provider) bridges We need to add bridge interfaces which allow NETCONF to expose DOMActionService through Controller's mountpoints. Also add binding equivalents, so users of Controller Binding have access to them. JIRA: MDSAL-283 Change-Id: Ie6b0819345928637df29c5a15bf1634f8932de19 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate controller APIs Deprecated the high-level interfaces, eg DataBroker. Change-Id: I754e3a5059c05d70616f3bd4ff3a00a05115fead Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Remove sal.core.api.mount.MountProvisionListener There are no in-tree users, remove this interface. Change-Id: I88c1b370db95db1e21bcd14bc21dbadd1f782852 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate sal.core.api.mount.MountProvisionListener This interface has an exact copy in DOMMountPointListener, deprecate it and adjust implementations to not require it. Change-Id: If19a3a34094a9dbbc25665967074a32e562a7dca Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove sal.core.api.BrokerService This interface has been long deprecated and it is not really used anywhere. Remove it. Change-Id: I8dcee98f19d80df4532891f73776dc4c268ef025 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Proxy DOMNotificationRouter to the mdsal implementation Proxying to the dom mdsal notification service(s) will allow an easier migration path where both can co-exist. Change-Id: I514c319d457bce3261e6f9b36cb189828800fe97 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Proxy DOMRpcRouter to the mdsal implementation Proxying to the dom mdsal RPC service(s) will allow an easier migration path where both can co-exist. Change-Id: Ib31efc2985b24e83106e6a25d2c94c9c29850eb2 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Remove DataChangeListener and friends AsyncDataChangeEvent is being kept for now as ovsdb still independently uses it internally. JIRA: TSC-112 Change-Id: Ia68ac1cdf31dec3645f675442db14b7697d63b64 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Remove DOMDataTreeService and related classes DOMDataTreeService has been deprecated and it lives in MD-SAL, remove it from the controller, taking related classes along for the ride. Change-Id: I30a4e3ac493e16e37bd812be4ac470691a0b2b5a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix findbugs violations in md-sal - part 1 - sal-common-util - sal-common-impl - sal-dom-api - sal-dom-spi - sal-binding-api - sal-inmemory-datastore Violations: - Non-transient non-serializable instance field in serializable class - Field isn't final but should be - Unchecked/unconfirmed cast - Class names shouldn't shadow simple name of implemented interface - Redundant nullcheck of value known to be non-null - Field not initialized in constructor but dereferenced without null check - Equals checks for incompatible operand - Method ignores return value Change-Id: I57ceba7dae12114eba962c01aea259004f4a2983 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix checkstyle violations in sal-dom-api Change-Id: I2be21dbde5cca70ca327828fd479779ceb958c3e Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Bug 9057: Revert "Take advantage of default" ... ... " methods in DOMRpcProviderService" This reverts commit adf49155eced15c9f654d7bed7ee45cd95686e4f. This is perhaps only a workaround, depending on why test app expects class in the first place. Change-Id: I68840f79aec25b128ddb78edc1a1e5514de16631 Signed-off-by: Vratko Polak <vrpolak@cisco.com>