Remove sal.core.api.mount.MountProvisionListener There are no in-tree users, remove this interface. Change-Id: I88c1b370db95db1e21bcd14bc21dbadd1f782852 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate sal.core.api.mount.MountProvisionListener This interface has an exact copy in DOMMountPointListener, deprecate it and adjust implementations to not require it. Change-Id: If19a3a34094a9dbbc25665967074a32e562a7dca Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove sal.core.api.BrokerService This interface has been long deprecated and it is not really used anywhere. Remove it. Change-Id: I8dcee98f19d80df4532891f73776dc4c268ef025 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove sal.core.api.RpcRoutingContext This class is not used anywhere, remove it. Change-Id: Ibaad5ad39fe1726016c87b4d1c01660b1f301613 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove sal.core.api.model This removes deprecated and unused sal.core.api.model package along with its only implementation, migrating final stragglers to DOMSchemaService. Change-Id: Id355ffd96a5aaa0ffa48e018bfadea596ec58ac8 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove deprecated controller.sal.core.api interfaces Broker, Consumer, Provider and related classes have been deprecated for a long time and no longer have any in-tree users. Remove them. Change-Id: I82aab628b7612e636d2c18427e5e71f93c11083f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate Broker and related APIs These are remnants of the config system and not needed for blueprint. If we remove the config system in Flourine, perhaps we can just remove these classes as well but deprecate for now. Change-Id: I6c14ab3a86b11137da12a8655848a6810e47a5f6 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix findbugs violations in md-sal - part 1 - sal-common-util - sal-common-impl - sal-dom-api - sal-dom-spi - sal-binding-api - sal-inmemory-datastore Violations: - Non-transient non-serializable instance field in serializable class - Field isn't final but should be - Unchecked/unconfirmed cast - Class names shouldn't shadow simple name of implemented interface - Redundant nullcheck of value known to be non-null - Field not initialized in constructor but dereferenced without null check - Equals checks for incompatible operand - Method ignores return value Change-Id: I57ceba7dae12114eba962c01aea259004f4a2983 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix checkstyle violations in sal-dom-api Change-Id: I2be21dbde5cca70ca327828fd479779ceb958c3e Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Remove explicit default super-constructor calls The default constructor is called by default (hence its name), no need to call it explicitly. Change-Id: I0f4ac3bf4a1d582b7a9d50beeaa1de6d2f107499 Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Retrofit DOMSchemaService into SchemaService For migration purposes we need to retrofit SchemaService so that in extends MDSAL's DOMSchemaService. Also allow datastores to be instantiated with DOMSchemaService. Change-Id: Ie71732fb09f4da6dbc2d0819931d5ade2356d6f2 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
BUG-8327: deprecate sal.core.api.model.SchemaService This interface is deprecated in favor of the DOMSchemaService for the MD-SAL project. Change-Id: Icff2cced791bc9fbf5bfadbe2f1cf2b949ff2d58 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix javadocs and enable doclint This eliminates the doclint suppression and fixes up javadoc, so they work with Java 8 out of the box. Change-Id: I7294f0dcd570e3e3c445e54cc8989078175d05d7 Signed-off-by: Robert Varga <rovarga@cisco.com>
Mechanical code cleanup (sal-dom-api) * Remove unnecessary type specifiers (use Java 7 <>) * Remove unnecessary "extends Object" declarations * Remove unnecessary semi-colons * Merge identical catch blocks * Remove redundant modifiers: - enum constructors are private by default - interface properties are public static final by default - interface methods are public abstract by default - interfaces are abstract by default - inner interfaces are static by default - inner classes in interfaces are public static by default Change-Id: I88c96965215d2f5dbf60967afe4a4ddbaed0072f Signed-off-by: Stephen Kitt <skitt@redhat.com>
Remove unused MD-SAL utilities and interfaces. This utilities & interfaces were deprecated before Lithium or were describing internal contracts of MD-SAL prior to Lithium, thus they are unneeded in Beryllium. None of removed classes is used in public Lithium Opendaylight codebase. Change-Id: Ie5f51cf3dc15f0f70efe3e51e0fe0d0c2b8da713 Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Bug 4035: Fixed some sonar / findbugs issues in DOM MD-SAL. Change-Id: Id0ab9f65e4f1663f9e6cd85a6235a0a5fdee6f88 Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
BUG 2412 - Remove CompositeNode from sal-dom-* * removed CompositeNodes from sal-dom-broker * removed deprecated services from sal-dom-broker * removed deprecated services from sal-dom-api * removed deprecated api calls from sal-binding-broker tests and sal-dom-spi Change-Id: Iae44e5c0acd0ad602bf98b9961fcd808657ac07b Signed-off-by: Jan Hajnar <jhajnar@cisco.com>