BUG-509: migrate to TreeNodes This patch performs the switchover to SPI-provided TreeNodes. It also extracts the information needed for checking applicability of a modification into a separate interface. Also adds some documentation in the non-trivial write+merge path. Change-Id: I83f5ca30bff21774759f9b675b19b6e9622076a2 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-509: there is only one createRecursively() The naming and exposure of two and three arugment variants made things confusing -- let it be clear there is only one version. Change-Id: If05620e99c2200ee10c1881de8eecd015f18eb9b Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-509: Remove unused methods These two have no users, so let's remove them to make navigating the code easier. Change-Id: I515570db5a8a4095ff525f1ca5614f9f627616df Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-509: node version is always required This just clarifies the requirement to know the node version you are attempting to build before instantiating a builder. Also remove some unused methods. Change-Id: I09406bbedee963624b43a280529d4b8cbc9931c6 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-509: cleanup StoreMetadataNode Removes StoreTreeNode<StoreMetadataNode> interface and tightens visibility of a few methods. Change-Id: I3bbf303025046f217bdcea81fcc14c420dbf9478 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-509: Refactor listener walking This patch creates a proper abstraction for examining a DataTreeCandidate for changes. This has the nice property of finishing the hiding of all implementation details behind proper interfaces, such that our implementation is free to do proper lifecycle as it pleases. Also gets rid of the AutoCloseable from candidate. It can be reintroduced in the need appears. Change-Id: I13301548594d4ae34e929c7202661997ea5aca90 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-509: Move ModificationApplyOperation This patch moves ModificationApplyOperation at al. to the data tree package, improving its isolation. Change-Id: I37081222e30c149a87baf6f4a5d3ce2e84f13acb Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-509: Move DataTree concepts into separate package Create a new package for the data tree and related concepts to clean out interactions. Also create and document the API and hide implementation classes from the user itself. Change-Id: I69f2a9b7bcac863b531f46f669bfd2fcfcd5b743 Signed-off-by: Robert Varga <rovarga@cisco.com>