Remove deprecated MD-SAL APIs The APIs in controller have been deprecated for removal and cannot sustain an upgrade to Guava-28+. Remove them along with all supporting implementations. JIRA: CONTROLLER-1903 Change-Id: I213797b7045cfd7bef744e249614e2b1f6169c1c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate old MD-SAL APIs for removal These APIs are slated for removal in Aluminium, make sure our warning is more stern. JIRA: CONTROLLER-1917 Change-Id: Ib4f7dcfd5183b87dd10b9ce2b773a59a548892c9 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate all MD-SAL APIs These APIs have either been completely deprecated or have their replacements in the mdsal project. Mark all of them as deprecated, including their implementations. JIRA: CONTROLLER-1902 Change-Id: I903afcef57c70c1013ab479cfcf31a42f475dc0f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Reduce JSR305 proliferation retention=runtime annotations are mixing really badly with Java EE injection and Java 11. Make sure we do not use javax.annotation package in APIs and reduce overall proliferation inside implementations. Change-Id: I569815f0336efdc0de662c3b80f0fa6e5dd47d8a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Default AsyncWriteTransaction.submit() Now that all downstream implementations implement commit(), the deprecated submit() method can be defaulted instead instead of commit(). Change-Id: Idd684bc3fdc7d4f048257154988ef1f7c7811e97 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Add AsyncWriteTransaction.commit() Equivalent to the recent md-sal API addition. The CommitInfo class is re-used from md-sal. I also modified all implementations in the controller to implement commit even though it's defaulted. As soon as implementations in other projects do the same then we can default submit(). Change-Id: I0801d5aa4c197177af838e7fbb71b7766a90e043 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Add default implementation for AsyncWriteTransaction#commit This method has been deprecated for quite some time and time for removal. There are still sub-classes in other projects that override it so first add a default implementation to throw UnsupportedOperationException. When patches are merged in the pther projects, we can remkve this method (and TransactionStatus). Change-Id: I5e3581d50a4f92df3984a663d04ce026a52252b2 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix checkstyle violations in sal-dom-spi Change-Id: Ifc0955a9dcd162879681cb30ef925b05f37a1fd6 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Introduce forwarding DOMData classes These classes are useful for implementing various decorator. Their sole functionality is to forward calls to a backing instance. Change-Id: I8a65283ab6e3f9787dc59f43d7b7e8eb37459538 Signed-off-by: Robert Varga <rovarga@cisco.com>