Remove deprecated MD-SAL APIs The APIs in controller have been deprecated for removal and cannot sustain an upgrade to Guava-28+. Remove them along with all supporting implementations. JIRA: CONTROLLER-1903 Change-Id: I213797b7045cfd7bef744e249614e2b1f6169c1c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate old MD-SAL APIs for removal These APIs are slated for removal in Aluminium, make sure our warning is more stern. JIRA: CONTROLLER-1917 Change-Id: Ib4f7dcfd5183b87dd10b9ce2b773a59a548892c9 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix modernization issues This fixes issues pointed out by Modernizer, which mostly boil down to using Objects.requireNonNull() and direct java.util collections. Change-Id: Id32530a6722cd101f96c23f6a745f91b2f09e2f9 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Deprecate all MD-SAL APIs These APIs have either been completely deprecated or have their replacements in the mdsal project. Mark all of them as deprecated, including their implementations. JIRA: CONTROLLER-1902 Change-Id: I903afcef57c70c1013ab479cfcf31a42f475dc0f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Allow SnapshotBackedReadTransaction customization In some specific cases we need to customize abort-like handling, which is already implemented for write-like transactions, but is not present for read-only transaction. This patch adds the capability to attach a close() handler and makes sure AbstractSnapshotBackedTransactionChain takes advantage of it. JIRA: CONTROLLER-1879 Change-Id: Ic7027956556b5dd25120ee81613a6151e5dbc501 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Reduce JSR305 proliferation retention=runtime annotations are mixing really badly with Java EE injection and Java 11. Make sure we do not use javax.annotation package in APIs and reduce overall proliferation inside implementations. Change-Id: I569815f0336efdc0de662c3b80f0fa6e5dd47d8a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove deprecated controller.sal.core.api interfaces Broker, Consumer, Provider and related classes have been deprecated for a long time and no longer have any in-tree users. Remove them. Change-Id: I82aab628b7612e636d2c18427e5e71f93c11083f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove DataChangeListener and friends AsyncDataChangeEvent is being kept for now as ovsdb still independently uses it internally. JIRA: TSC-112 Change-Id: Ia68ac1cdf31dec3645f675442db14b7697d63b64 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Deprecate Broker and related APIs These are remnants of the config system and not needed for blueprint. If we remove the config system in Flourine, perhaps we can just remove these classes as well but deprecate for now. Change-Id: I6c14ab3a86b11137da12a8655848a6810e47a5f6 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix checkstyle violations in sal-dom-spi Change-Id: Ifc0955a9dcd162879681cb30ef925b05f37a1fd6 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Delay snapshot backed transaction ready error Delay snapshot backed transaction ready error to 3PC canCommit. Change-Id: Ief659423b401936a286f04c2f6c3732722c5aabf JIRA: CONTROLLER-1812 Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
Adjust to yangtools-2.0.0 changes Change-Id: Ib86747e5ed19c0c00bb46b8d7e4936f4d90c4364 Signed-off-by: Robert Varga <robert.varga@pantheon.tech> Signed-off-by: Stephen Kitt <skitt@redhat.com>
Deprecate org.opendaylight.controller.md.sal.dom.spi.AbstractRegistrationTree This is a utility class, which has a conterpart in mdsal. Deprecate it and related classes, migrating users. Change-Id: I8206350ddb60bb19aed93ff3840e0e68e288d55a Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Optimize use of YangInstanceIdentifier.getPathArguments() This method returns a list, hence we can lookup the first item without iterating and also can use Lists.transform(). Change-Id: Ie26bfcc225c74154d65ef963e3444ac5ec10bafb Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix Verify/Preconditions string format These methods take a String.format() string, not a logging one, hence we are not getting the information we want. Change-Id: I46de0d64c85594e3d7b8be97951f1cf5249bca8f Signed-off-by: Robert Varga <robert.varga@pantheon.tech> (cherry picked from commit 3e9ac68fea1aef0c7fedec346e50882efdde8acc)
Fix javadocs and enable doclint This eliminates the doclint suppression and fixes up javadoc, so they work with Java 8 out of the box. Change-Id: I7294f0dcd570e3e3c445e54cc8989078175d05d7 Signed-off-by: Robert Varga <rovarga@cisco.com>
Mechanical code cleanup (sal-dom-spi) * Remove unnecessary type specifiers (use Java 7 <>) * Remove unnecessary "extends Object" declarations * Remove unnecessary semi-colons * Merge identical catch blocks * Remove redundant modifiers: - enum constructors are private by default - interface properties are public static final by default - interface methods are public abstract by default - interfaces are abstract by default - inner interfaces are static by default - inner classes in interfaces are public static by default Change-Id: I68a6f9ee118c8ff47bc2511efa234b93b09de32a Signed-off-by: Stephen Kitt <skitt@redhat.com>
Bug 4774: Add Tx ID to logging on Tx chain failures To help with debugging, it's useful to see the tx ID when a create fails due to previous tx not ready. Change-Id: I0547048ea62340a0297affed3512271908eba65a Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Bug 4202: Migrate also toaster to use mdsal project This only changes dependency feature omitted from Change 26079, perhaps Java edits are also needed to keep toaster working. Also, git has somehow enforced change of line endings everywhere. Change-Id: I810fba0ae7a55e123dd6f78ba23a7e77a7118b57 Signed-off-by: Vratko Polak <vrpolak@cisco.com>