Remove CSS modules The CSS features are still installed until we can work out the ModuleInfoBackedContext/ClassLoaderStrategy situation that is currently provided by the ConfigManagerActivator. Change-Id: Id3b2cc287d17532482a2dd893c41e2dcd8d29ff0 Signed-off-by: Tom Pantelis <tompantelis@gmail.com> Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix checkstyle violations in sal-inmemory-datastore Change-Id: I4e8dec800b8e5a2871e51ec4cd150f06c8af1bd1 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Deprecated in-memory datastore Change-Id: Ib960e71d0e73b0ebc72be3279345425853ca50cb Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Add missing license headers Change-Id: I8c49e33e015df601b4825c861a54c9719b42bc93 Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
BUG-1014: convert IMDS This patch fixes the IMDS to properly pass down the TreeType. Change-Id: I724fac68e62c58ed71eefbf03d50c82fb8d4a4e7 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-650: remove executor abstraction This patch removes sameThreadExecutor from the commit path, eliminating associated overhead. Relevant benchmarks show improvement pretty much across the board: BEFORE millis error write100KSingleNodeWithOneInnerItemInCommitPerWriteBenchmark 2213.735 77.597 write100KSingleNodeWithOneInnerItemInOneCommitBenchmark 171.524 2.289 write10KSingleNodeWithTenInnerItemsInCommitPerWriteBenchmark 164.282 1.391 write10KSingleNodeWithTenInnerItemsInOneCommitBenchmark 14.161 0.196 write50KSingleNodeWithTwoInnerItemsInCommitPerWriteBenchmark 982.697 29.397 write50KSingleNodeWithTwoInnerItemsInOneCommitBenchmark 93.233 2.174 AFTER millis error delta write100KSingleNodeWithOneInnerItemInCommitPerWriteBenchmark 2138.900 75.844 -3.4% write100KSingleNodeWithOneInnerItemInOneCommitBenchmark 177.839 3.997 +3.5% write10KSingleNodeWithTenInnerItemsInCommitPerWriteBenchmark 158.666 1.090 -3.5% write10KSingleNodeWithTenInnerItemsInOneCommitBenchmark 13.022 0.105 -8.0% write50KSingleNodeWithTwoInnerItemsInCommitPerWriteBenchmark 935.490 30.395 -4.8% write50KSingleNodeWithTwoInnerItemsInOneCommitBenchmark 89.907 1.204 -3.6% Furthermore it cleans up and marks FIXMEs for defunct statistics. These will need to be replaced with implementation which does not assume underlying implementation. Change-Id: I01c51462a8529a2f874ecd2f9af05faba503bc58 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1679: optinally log allocation context Transactions can now print their allocation context. Change-Id: I801a44d1270f8becd2835cc31b514e2e0fdaee33 Signed-off-by: Robert Varga <rovarga@cisco.com>
Bug 1446: Add JMX stats for in-memory data store Added stats, available via JMX, to track data for the various thread pool executors used by the in-memory data store. Also added commit stats. Change-Id: Ica8dff7aef8989f2b23b1fc8c100a535998273b1 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Bug 1636: Fixed invalid model of inmemory-datastore configuration. Change-Id: I280cd4478d1dd5ab65e333658e802394693272bb Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Bug 1430: Obtain config params from config system This is a follow-up patch to obtain the various data store executor config params from the config system intsead of system properties. Change-Id: Ib7fa03f053d6165fdcb52300be9add8ebe80b2c2 Signed-off-by: tpantelis <tpanteli@brocade.com>
Bug 1430: Off-load notifications from single commit thread Modified the InMemoryDOMDataStore to use the new QueuedNotificationManager class added to yangtools common util for DataChangeListener notifications. Modified DOMDataCommitCoordinatorImpl's ListeningExecutorService to one that off-loads ListenableFuture Runnable callbacks on a separate executor. Change-Id: I31f2fb002131c6d91b205d33255dd1bbc6433d9b Signed-off-by: tpantelis <tpanteli@brocade.com>
BUG-868: Migrate to SchemaContextListener SchemaServiceListener is deprecated, SchemaContextListener is its new name. The class hierarchy allows for incremental migration. Change-Id: I15d495d805eb7a08c3bcd3ab0cf8b5a8d2797db5 Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix config attributes with same names for different modules. Yang does not allow attributes in different cases to have the same name. In yang modules for config, the configuration is located in cases and if 2 cases in same yang module contain child with same name, the transformation of data from CompositeNode to NormalizedNode NOTE: This might break bgpcep and SP distribution, check. Change-Id: I9bad24df9ac149da74b745ff648c72345e33deb1 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Added SingleThreadedExecutors to data store instance. Change-Id: I18900f4db121fe7728ecd3c0aae90cbd6e83fee2 Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Having InMemoryDOMDatastore in its own bundle.To make it configurable using the config subystem. patch 5 changes: md-sal/pom.xml correction patch 4 changes: Moved data tree api and impl to yang-tools based on earlier comment Patch 3 changes: 1. Included sal-inmemory-datastore dependency in TestHelper.java for PaxExam integration test cases [Weird that it was working earlier and my local controller full build were passing] Patch 2 changes: 1. Keeping schema service as part of opendaylight-dom-broker-impl for backward comptability scenario 2. Initializing InMemoryDOMDataStore by default if config-dom-datastore and operation-dom-datastore are not found 3. Updated 01-md-sal.xml based on 1. 4. Regarding the comment of moving data tree in yangtools. It shall be done in separate patch. This is done to replace InMemoryDOMDatastore with distributed-datastore The changes done are: 1. Created a new sal-inmemory-datastore bundle and moved the store/impl source files from sal-dom-broker and the corresponding InMemoryDOMDatastore test cases. 2. Created two yang config models in sal-dom-spi that represent the configurable config-dom-datastore and operational-dom-datastore, that are of service type DOMStore 3. In opendaylight-dom-broker-impl.yang of sal-dom-broker, in the augment of dom-inmemory-data-broker added two container config-data-store and operational-data-store that refer the service implementations of service defined in sal-dom-spi 4.In sal-inmemory-datastore bundle, created a yang model opendaylight-inmemory-datastore that provide the implementation of the sal-dom-spi service definitions mentioned in 2 -- The implementaions are augmented to have schema-service container required by InMemoryDOMDatastore for registering itself for scheam changes 5. Updated the 01-md-sal.xml with the above changes 6. Update the distribution pom.xml to include sal-inmemory-datastore. Change-Id: Ib2f0f0556869981e7e60b3eeae9b1e5e6cc96a0f Signed-off-by: Basheeruddin Ahmed <syedbahm@cisco.com>