Decouple config and netconf subsystems. Extract a common mapping for config pusher and config subsystem netconf Add a ConfigPersisterFacade for XML that allows reads/writes from/to config subsystem using XML format Push notifications from YangStoreService to NetconfNotificationManager instead of using custom listeners Migrate netconf features from controller features, untangle features Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca Signed-off-by: Tomas Cere <tcere@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com> Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Fix license header violations in sal-netconf-connector Change-Id: I8235e1cbe1ed7bce9d017276dd6d9f4fb26ead70 Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Remove deprecated constructors from RemoteDeviceId Change-Id: I26d48930a16213d2264de964f60103e67f80b9bd Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-3095 Add EventTime attribute to DOMNotification from netconf Introduced new interface DOMEvent and DOMNotifications from sal-netconf-connector implement this interaface. The eventTime is parsed from the the notification xml. Change-Id: I833d86d91f752be55fef3e641a6c8654d2f65a28 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Avoid IllegalArgument on missing source If source was not reported in hello, but was listed in ietf-netconf-monitoring and it was unable to download it, sal-netconf-connector would fail to build unavailable-capability from it and fail with IllegalArgumentException. Look up the QNames for Sources properly. Change-Id: Ic60135e3ba569fe52e6552f62f846d2aa9c8cc21 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG 2412 - Remove CompositeNode from sal-dom-* * removed CompositeNodes from sal-dom-broker * removed deprecated services from sal-dom-broker * removed deprecated services from sal-dom-api * removed deprecated api calls from sal-binding-broker tests and sal-dom-spi Change-Id: Iae44e5c0acd0ad602bf98b9961fcd808657ac07b Signed-off-by: Jan Hajnar <jhajnar@cisco.com>
BUG-2314 Allow rpcs with no input in netconf connector Change-Id: I81b05c98032c8bda7b34608c33ddcb5a0888ba67 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2314 Migrate netconf-connector to NormalizedNode CompositeNodes are wiped out from sal-netconf-connector. The inital operations performed on a remote netconf device (e.g. Schema download) is performed using a special schema context that contains base netconf, netconf monitoring and netconf notification schemas. With this schema context, it is possible to also use normalized nodes. YangInstanceIdentifier -> NormalizedNode filter structure is handled by a class named InstanceIdToFilter that was extracted from deprecated DataNormalizer. Change-Id: Ibcc399c3ef9413aa4f96dba5b4bb2611db7123a8 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2632 Netconf connector (optionally) reconnects after a schema change is detected A notification listener is used for schema change detection Change-Id: Ieab4eaf9e87b2b88dd2dc5429039494c8f9b5731 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2310 - widen yang model for netconf-node. Netconf datastore is now in topology, added connection state, resolved/unresolved schemas with failure reasons and host to netconf node. Deprecated old netconf node in inventory. Change-Id: Id34a17b82420eaf69d03d72b9a1523210cc87cc2 Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-2370 Reset schema context on disconnect in nc Change-Id: I64197fc4ec375a07b2f0ea1dfb1215c4e31e206c Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Add generic arguments to Answer Just use Object as the argument to get rid of the warnings. Change-Id: I17d2ee9c518ed53c27bd5e1c330e7c161a388194 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-997 Use shared schema context factory in netconf-connector + Fix disconnect by netconf-connector. Until now, the connection to remote device was still open even if initialization failed. Change-Id: I23ee999c7898665498519abf19610deef3d410a3 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-997 Consult QNames of yang modules with ietf-netconf-monitoring/netconf-state/schemas Change-Id: Ie0fcb6d9ba44207cb14d31d51c1f3068983d514e Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-692 Fix intermittent failure in NetconfDeviceTest Error in NetconfDeviceTest.testNotificationBeforeSchema, verification without timeout was performed before the actual call. Fixed by adding timeout to all verifications. Change-Id: I494523036fff456d66398f0d17b0003fe6c083a0 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Merge "Bug-1376 Add caching for premature notifications in netconf connector"
Bug-1376 Add caching for premature notifications in netconf connector If a notification is received before schema context is fully built for device, it is cached and forwarded when schema is present. Change-Id: Ib21fc0fab9cf83a1102ccbb5c9dc98330aa95577 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Deprecated Rpcs and RpcErrors helper classes With the new RpcResultBuilder class, we can deprecate the Rpcs and RpcErrors classes. Also migrate all uses of the deprecated classes to RpcResultBuilder in the controller code. Change-Id: I86408bba0ce19e70c7d7a41555e94052e54e93f8 Signed-off-by: tpantelis <tpanteli@brocade.com>
Bug 977: Return RpcError result on neconf failure NetconfDocumentedException: - Added methods to convert to and from XML. NetconfMessageTransformUtil: - Added code to convert a NetconfDocumentedException to an RpcError. - Modified checkSuccessReply and checkValidReply to throw NetconfDocumentedException instead of IllegalStateException. NetconfDeviceCommunicator: - Modified processMessage to return an RpcError result for invalid message and netconf error reply. - Modified other places that previously returned an exception in the Future to intsead return an RpcError result. - Improved synchronization by removing synchronized from method sigs and locking only the code that needs it. SendErrorExceptionUtil: - Modified createDocument to call NetconfDocumentedException.toXMLDocument XmlNetconfConstants: - Moved to netconf-api so NetconfDocumentedException could access it. The rest of the changed files were to change the import for XmlNetconfConstants. Change-Id: Id0ef3ac91bbcb85c9a7a198ceac272fb07f4b9f9 Signed-off-by: tpantelis <tpanteli@brocade.com>
BUG-832 Refactor netconf connector - Extract general API for remote connectors - Split NetconfDevice into more classes - Make data operations over netconf device in inventory binding aware (fixes 969) - Add dependency on binding-broker - Make connector crash if schema is not present for device - Improve logging Change-Id: Idf4fa4994b3ac067bd69e9cd629b6d8c225d7b77 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>