Clean up sal-remoterpc-connector We are using a number of deprecated methods here, clean that up. Change-Id: I19b37967cd7cac472efff3ae6018ea008111c49b Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump upstreams Adopt: - yangtools-13.0.1 - mdsal-13.0.0 Also adopts AbstractDOMDataBroker from mdsal-dom-spi, so that we have less code duplication and maintenance. UTs mocking NormalizedNode are updated to ContainerNode, as mocking sealed classes does not work with Mockito (out of the box). Change-Id: I6d3d3c8ced297b6850aea951040d16437df9e3f0 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Use constructor injection in OSGiRemoteOpsProvider We have a simple component here, use constructor injection to preempty upgraded SpotBugs issuing errors on it. Change-Id: Id65f63b374497aabccb98ebe06b52195f76f8099 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix sal-remoterpc-connector checkstyle Upgraded checkstyle is flagging a few nested classes as potentially final, fix that up. Change-Id: Ie3835769d50e3a692644fc0dbed480e6c4d5f2de Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump upstreams Adopt: - odlparent-13.0.1 - yangtools-11.0.0-SNAPSHOT - mdsal-12-0.0-SNAPSHOT Since the format of NormalizedNode tree is updated to not include AugmentationNode (and AugmentationIdentifier), we must force an incompatible update, as we do not have enough information to produce compatible payload. Change-Id: Ibf444540ed052b49651ba66ca7b93c806a6c8a97 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Migrate users of Optional.get() We have an incoming enforcement patch, prepare to adopt it. Change-Id: If73abd4ceaea71a216a4bc3a3968b400b508ec38 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Clean up RpcErrorsException Fix whitespace and use local variable type inference to improve sizing. Change-Id: I344305a59e3b0078d942636c339d1686c006e4a3 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Remove commons-lang dependencies Use commons-lang3 instead, as it provides better interface anyway. Change-Id: I8574166cf77f8f40c9a2ada4b06cc0d8b14244a9 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Modernize sal-remoterpc-connector Use instanceof patterns to reduce casts. Change-Id: Iafcb05461e2c241310857ee2bf93591bed66a7d4 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump upstreams Adopt: - odlparent-12.0.0 - yangtools-10.0.0 - mdsal-11.0.0-SNAPSHOT Update toaster test to not use the same transaction for both config and oper access. Update RPC invocation paths to assume ContainerNode as opposed to a plain NormalizedNode. Change-Id: I31c6350746be4e176a389d8a14a12de89119a78b Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Promote BucketStoreAccess This is no longer @Beta. Change-Id: I294085026f7306547230d476951793e09b3d0618 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change RTE to an ISE SpotBugs does not like our throwuign a plain RuntimeException, throw an ISE instead. Change-Id: I1d900144757294df2ebd5b230010cf654372cfcb Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump upstream SNAPSHOTS Adopt: - odlparent-10.0.0 - yangtools-8.0.0-SNAPSHOT - mdsal-9.0.0-SNAPSHOT Change-Id: I60991718a6d1ef6f108c2b1f7b2c09b0c5f973c4 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
akka.actor.provider set to 'cluster' A number of sal-akka-raft test logs are polluted by ConfigurationException. ActorSystem needs to have 'akka.actor.provider' set to 'cluster' in the configuration. JIRA: CONTROLLER-2023 Change-Id: If6e873864ffe0ea8261c80c233b6d40459d05164 Signed-off-by: Dominik Vrbovsky <dominik.vrbovsky@pantheon.tech>
Bump odlparent/yangtools/mdsal Adopt latest versions, namely; - odlparent-9.0.1 - yangtools-7.0.1 - mdsal-8.0.0-SNAPSHOT There are a few adjustments needed, which mostly deal with the interface to NormalizedNode. Change-Id: I918fb885a6df62e16e17119a7e04ba1672ef7c39 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump akka to 2.6.12 Release notes: https://akka.io/blog/news/2019/11/06/akka-2.6.0-released https://akka.io/blog/news/2019/12/06/akka-2.6.1-released https://akka.io/blog/news/2020/01/27/akka-2.6.2-released https://akka.io/blog/news/2020/01/28/akka-2.6.3-released https://akka.io/blog/news/2020/03/13/akka-2.6.4-released https://akka.io/blog/news/2020/04/30/akka-2.6.5-released https://akka.io/blog/news/2020/06/08/akka-2.6.6-released-split-brain-resolver https://akka.io/blog/news/2020/07/10/akka-2.6.7-released https://akka.io/blog/news/2020/07/16/akka-2.6.8-released https://akka.io/blog/news/2020/09/09/akka-2.6.9-released https://akka.io/blog/news/2020/10/09/akka-2.6.10-released https://akka.io/blog/news/2021/01/15/akka-2.6.11-released https://akka.io/blog/news/2021/01/28/akka-2.6.12-released JIRA: CONTROLLER-1962 Change-Id: Ibbfc11a8ca27a8c09337bf49de910c38a9239886 Signed-off-by: tadei.bilan <tadei.bilan@pantheon.tech> Signed-off-by: Robert Varga <robert.varga@pantheon.tech> Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Bump upstreams for Silicon Adopt the following upstream versions: - odlparent-8.0.0 - yangtools-6.0.0-SNAPSHOT - mdsal-7.0.0-SNAPSHOT Also add bundle-parent to host the scala/akka definitions we need. Change-Id: I98452920bf7cebf176d3b20723be40929a9a7268 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Convert sal-remoterpc-provided to OSGi DS Declarative Services offer better integration with OSGi lifecycle, use them instead of blueprint. Change-Id: I49b41fa0fba4714f54e097820b85aefe7da67364 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix OpsManager registry instantiation We have a day-zero bug with actions, as OpsManager ends up instantiating the wrong actor -- hence we have two RpcRegistry instances and no ActionRegistry instances. JIRA: CONTROLLER-1943 Change-Id: I3b374454af3225cf13d5e23e4fb6744bf3f9ed99 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Partially revert "Adjust for RPCService methods changing" This reverts commit ba6824307ad4b3c272abefe9682d623adc3b42d2, as it was overzealous with regards to ContainerNode conversion. This reverts parts of it, so that we arrive at something sane. JIRA: MDSAL-303 Change-Id: I9bd61b6dd1c88b53c39ac1b8791edaf38cad7885 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>