Bump upstreams Adopt: - yangtools-13.0.1 - mdsal-13.0.0 Also adopts AbstractDOMDataBroker from mdsal-dom-spi, so that we have less code duplication and maintenance. UTs mocking NormalizedNode are updated to ContainerNode, as mocking sealed classes does not work with Mockito (out of the box). Change-Id: I6d3d3c8ced297b6850aea951040d16437df9e3f0 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Switch KitchenServiceImpl to CompositeListener Do not use generated ToasterListener, just internalize the dispatch methods. Change-Id: I3ab8948a07003d9d563dd9b8282c550406f6d1b7 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Do not use RpcService in toaster-consumer Migrated usage of RpcService to Rpc<?,?> for toaster-consumer. JIRA: CONTROLLER-2085 Change-Id: I85db90c9a2fe104bded1835ae9d4263e893311bb Signed-off-by: Oleksandr Zharov <oleksandr.zharov@pantheon.tech> Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Use Futures.submit() Do not wrap the ExecutorService and just use Futures.submit() to arrive at a ListenableFuture with any executor. Change-Id: Id43ba68f65aa7a358159024364515f8029b95d5f Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Migrate toaster-consumer to OSGi DS Use declarative services instead of blueprint and do not pull in the blueprint extension. JIRA: CONTROLLER-2003 Change-Id: I1c7987086c0469001a7e1ee5cd5e8f921b57f7a7 Signed-off-by: Samuel Schneider <samuel.schneider@pantheon.tech> Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump upstreams to snapshots Adopt: - odlparent-11.0.0-SNAPSHOT - yangtools-9.0.0-SNAPSHOT - mdsal-10.0.0-SNAPSHOT Also adjust to identity mapping change by referencing .VALUE instead of .class. Change-Id: Idf2e4a845aa20ec029708a174e2787490170a927 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump upstream SNAPSHOTS Adopt: - odlparent-10.0.0 - yangtools-8.0.0-SNAPSHOT - mdsal-9.0.0-SNAPSHOT Change-Id: I60991718a6d1ef6f108c2b1f7b2c09b0c5f973c4 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Do not use Binding DTO compat methods This removes the use of compat methods, preferring explicit instantiation of the correct type. Change-Id: Ie3b739e1e31ba2762cdda92444f4734a8ac47ae8 Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Move BP xml files to standard OSGI-INF/blueprint We originally used org/opendaylight/blueprint in case we needed to customize how BP bundles are processed but this wasn't needed. So let's move to the standard BP dir. We'll keep the BlueprintBundleTracker as is for backwards compatibility - the only change was to modify it to look in both dirs for BP xml files when restarting the container for a bundle. Change-Id: I777e831ef4d8293b49d7aa6c8cdecec96b97937f Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Fix findbugs warnings Upgraded findbugs finds these, fix them up. Change-Id: Id5a008cddc6616c3a93f0528efca00b86843fc3c Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Adjust for Binding RPC codegen changes This adjusts RPC implementations to conform to YANG-compatible layout with ListenableFuture. It also fixes BindingToNormalizedNodeCodec to realign it with mdsal version. Since we are guaranteed to be dealing with ListenableFutures, this patch also eliminates all references to JdkFutureAdapters. Change-Id: I068a5821493b36e03d6a34a93bf49509b970507e Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Bump to odlparent 2.0.0 This takes odlparent 2.0.0, adjusts for guava update and feature movement. Since jenkins is failing on the distro run, that is disabled and a follow-up patch will re-enable it to get us going again. Change-Id: If3e1289ed7f73a79a5a47428c634bda9702e824d Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Fix checkstyle/findbugs violations in the toaster sample Also enable enforcement. Change-Id: I25a6b036be4735abffd6b6d4e0b8ed9add637a95 Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Remove CSS-related files from the toaster The toaster is wired with blueprint and, since it's a sample app, it doesn't need to maintain backwards compatibility with CSS so remove the CSS-related files. Change-Id: I4b99933cec6188f3eb628eedffe20ce198ed1ab5 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Address comments in prior patches Follow-up patch to address comments in https://git.opendaylight.org/gerrit/#/c/36476/ and https://git.opendaylight.org/gerrit/#/c/36485/. Change-Id: Ic4e9c4957a3440c8772fe814a3f4732c054b3271 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Modify config Module impls to co-exist with blueprint Modified various config system Module implementation classes which have corresponding instances created and advertised via blueprint to obtain the instance in createInstance from the OSGi registry. The instance may not be available yet so it will wait. I added a WaitingServiceTracker class to encapsulate this logic using a ServiceTracker. For those modules that don't advertise services, createInstance simply returns a noop AutoCloseable since the components are created via blueprint. I also added the new disable-osgi-service-registration flag to the corresponding service yang identities to prevent the CSS from duplicating the service registrations. This patch also adds the blueprint bundle to the mdsal features and "turns on" blueprint. Change-Id: I60099c82a2a248fc233ad930c4808d6ab19ea881 Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Add blueprint wiring to the toaster sample Change-Id: I79922dd24847fd8682a0f2133e6effae9b608a0c Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Add missing license headers Change-Id: I8c49e33e015df601b4825c861a54c9719b42bc93 Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Fix license header violations in toaster-consumer Change-Id: Ib522fe2ed5a47fefaed18554badde343368f306d Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
BUG-432: migrate users of Registration as appropriate This patch adjust all users to the non-generic nator of Registration, plus migrates a few to ListenerRegistration. Change-Id: I69c1c61890f866d24a4b50e685bddba32bac7815 Signed-off-by: Robert Varga <rovarga@cisco.com>