BUG-2637: migration final - cleanup - remove migrated features (feature-flow, odl-adsal-compatibility) - remove migrated apps (model-flow*, sal-compatibility, sm, im, tp, frm) - remove temporary fix in toaster-it Change-Id: Ida315250f0035e09aa2e2afd0f8df076d9770861 Signed-off-by: Michal Rehak <mirehak@cisco.com>
Bug 2551 - Statistics collection of random node fails when large number if switches disconnects from controller. When statistics manager is collecting stats and large number of switches disconnects from controller ,some time it causes OptimisticsLockFailedException while processing the existing multipart reply present in dataStoreOperQueue. Exception occures because it tries to write data to the Node that doesn't existing in the data store. While handling OptimisticsLockFailedException, statistics manager flush existing data store related operation task from dataStoreOperQueue. This queue also holds Operational task for cleaning up internal data of the disconnected nodes and because it flushes the queue, those operational task don't get executed and statistics manager assumes that those nodes are yet connected to the controller. When all the switches connects back with different mode (e.g previsouly Openflow13 but reconnects in OpenFlow10 mode), statistics collection of those node fails. Change-Id: I50a44dfd20f90e3179bcd15bde67247da6565af7 Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Fix bug 2450 - Statistics collection slow - performance * fix timeout value for statWaiter to notification (30 sec is mistake - 3sec is correct value) * add check TransactionId for every notification (prevent unexpected notification for collecting next statistics) * timeout has to clear TransactionId (prevention for notification from slower statistics processes * patch 3 - revert the log level msg (debuging issue in StatPermCollectorImpl) - change an expiration calculation for cached RPC results (StatRpcMsgManagerImpl) - fix conditions for call notifyToCollectNextStat (Meter, Group) succesfull tested for karaf-compatible Change-Id: I54d7fe9e5c1a5d265c9378507fce1163691b62e5 Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Fix bug 2413 NPE for group and meters * group/meter features * Device RPC features Calls for group/meter depend on FlowCapableNode data change event (create event only) * Remove Meter's and Group's feature calls from perm. stat. collect * Add API methods for additional registration new StatCapabTypes for a specific Node statistic collecting process * Fix NPE for features * refactoring group/meter stats update processing (Target: Don't block the RPC Notification threads as soon as is possible) * Fix NPE List processing * queue - add delete processing (becasue queues has to be edit outside and we are not cleaning it) * add validations input values * remove unnecessary validation input values (StatRpcMsgManagerImpl) Signed-off-by: Vaclav Demcak <vdemcak@cisco.com> Change-Id: If10a0ea0bb098ca70cd19ce32a7ca5790159aae5
BUG-2078 Stats not being collected from all nodes, dangling nodes left in oper data store after mininet disconnects BUG-2049 DataStore failure in StatisticsManager * fix performance issues * fix occurrence zombie nodes * fix NPE for StatCollector * fix NPE for Meter/Group lists Change-Id: I95a821aaf308bdb6e989c4a740aa014d5aaab4c2 Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Bug 1484 - StatisticManager performance improvement refactoring * migration to new MD-SAL API (DataBroker DataChangeListener) * splitting project api/impl + (javaDoc for api) * clean pom.xml (xtend dependency and private-package, add sal-binding-broker-impl for test) * chaining req/resp StatisticNotification per FlowNode per statistic for prevent DS and RPC queue overload * add multipart msg joiner (StatManager wait for all relevant multipart msg for notification before write relevant Oper/DS action) - possibility to remove all not used subtrees (target -> reflect actual device contain asap for all alien node's data). * add FlowNode registratration - registration needs all SwitchFuture information for make a correct Stat target list (flows, groups, meters, queues, tables, nrOfTables, ports) - fix for sending not supported notifications to device * add logic for unique identification FlowId - DeviceFlow (create unique tweens FlowId and flowHash from responded device flow fields like match, priority, flowCookie, flowCookieMask) * change FlowCookieMap to FlowHashMap -> List<FlowHash, FlowId> * implement parallel statistics collecting for FlowCapableNode Sets * add MockTestSuite for a StatManager workflow interaction testing (neet to be fixed for newest changes) PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-base-of13 PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-karaf-l2switch-only/ PASS tests https://jenkins.opendaylight.org/integration/job/integration-master-csit-karaf-compatible-min/ Change-Id: I265b57378fc19573d6f18036825cb57f4131ca80 Signed-off-by: Jan Hajnar <jhajnar@cisco.com> Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>