Delete netconf Change-Id: I69f0c921df155606d296f448b11297c7382795c8 Signed-off-by: Tomas Cere <tcere@cisco.com>
Decouple config and netconf subsystems. Extract a common mapping for config pusher and config subsystem netconf Add a ConfigPersisterFacade for XML that allows reads/writes from/to config subsystem using XML format Push notifications from YangStoreService to NetconfNotificationManager instead of using custom listeners Migrate netconf features from controller features, untangle features Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca Signed-off-by: Tomas Cere <tcere@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com> Signed-off-by: Ed Warnicke <hagbard@gmail.com>
BUG-2453 (De)Serialize enum values as defined in yang Netconf endpoint for config subsystem did not (de)serialize enum values properly It assumed the enum constants are identical in yang and in generated binding Change-Id: If46c770a49653348201cd5d5c9303b5207048252 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2600 Dynamic schemas in netconf server Netconf server does not preserve snapshots of schema contexts for each netconf session anymore Every netconf session is using current SchemaContext + Use notification manager to notify about capability changes Change-Id: Ie47125e1eb6851b54b09d5e4afe38fee323850de Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Fix checkstyle warnings for config-netconf-connector Change-Id: I8234bbfdb7092f6423cedc7f95de07995871756d Signed-off-by: Marian Dubai <mdubai@cisco.com>
BUG-692 Fix major issues reported by sonar for netconf subsystem Change-Id: I2f7cd479a773b7c3edc111c45add8ab5510fb47f Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Bug 977: Return RpcError result on neconf failure NetconfDocumentedException: - Added methods to convert to and from XML. NetconfMessageTransformUtil: - Added code to convert a NetconfDocumentedException to an RpcError. - Modified checkSuccessReply and checkValidReply to throw NetconfDocumentedException instead of IllegalStateException. NetconfDeviceCommunicator: - Modified processMessage to return an RpcError result for invalid message and netconf error reply. - Modified other places that previously returned an exception in the Future to intsead return an RpcError result. - Improved synchronization by removing synchronized from method sigs and locking only the code that needs it. SendErrorExceptionUtil: - Modified createDocument to call NetconfDocumentedException.toXMLDocument XmlNetconfConstants: - Moved to netconf-api so NetconfDocumentedException could access it. The rest of the changed files were to change the import for XmlNetconfConstants. Change-Id: Id0ef3ac91bbcb85c9a7a198ceac272fb07f4b9f9 Signed-off-by: tpantelis <tpanteli@brocade.com>
Bug 1062 - Disallow implicit serviceref creation. Remove auto registration of service references by netconf. Old behaviour was adding ref_ + module name for each interface module implements even if it is not declared in /services node. Fix code style warning in config-netconf-connector. Change-Id: I8dc2b4dffac212d9b8b8243ccd7aaf290b87499b Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Bug 460 - Fix warning throughout netconf subsystem Change-Id: I461a7bab47ef67c13c6fd5864d8938cdd47c3c8b Signed-off-by: Martin Bobak <mbobak@cisco.com>
Bug 451 - Fix netconf exception handling Change-Id: I815b34da996cf2660650577edb2e8ca623ae96df Signed-off-by: Martin Bobak <mbobak@cisco.com>
Bug 714 - Fixed creating DOM Document's element with namespace Change-Id: Ic7449e11a9b2057d350dc889fcb81872d9ce24f8 Signed-off-by: Milos Fabian <milfabia@cisco.com>
Resolve Bug:448 - Remove yang-store api and impl. Depends on yangtools commit https://git.opendaylight.org/gerrit/#/c/5579/ . Instead of having multiple bundle trackers for config and netconf, keep only one. Each bundle containing yang files should use sal code generator, which generates YangModuleInfo objects. Using this instead of speculatively having to parse all current yang files for each adding bundle event allows not having to deal with broken yang dependencies when bundle events come in wrong order. Put SchemaContextProvider to OSGi SR in config-manager, so that any bundle working with yang can use it. This replaces too specific YangStoreService which was coupled with yang-jmx-generator. Users can listen for changes directly on OSGi SR - they receive service changed event when yang module is added or removed. Change-Id: Iabcb35929a1eeef0df328f3f948d70e1bfcbba0d Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Remove duplicate netconf namespace constant Change-Id: I7af2cb2631136fb4ae947f7150ad2e5d8f2df567 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Get rid of netconf operation filters Merge NetconfOperationFilter interface into NetconfOperation Execute all operations that can handle a certain request in chained execution (ordered by priority) Reimplement all current filters as chained operations Remove NetconfOperationRouter parameter from NetconfOperation NetconfOperations handling the same request must have different priorities Change-Id: Iab9c680e6eceab4059feb77616a9d006fb613711 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Fixed inappropriate uses of log level INFO This is done per the recommendation here: https://wiki.opendaylight.org/view/Draft_Syslog_Level_Settings Change-Id: I69bbe15d81ed49511f643fd4a8c0ad60f58a0c22 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Fixed some TODOs in netconf. Remove duplicate code Remove commented modules in get-config response Add test for netconf - persister integration Remove already fixed TODOs Change-Id: If79fa8652a7018ba2927044d6784d7c9dfafb220 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Fix no response from netconf server if no operation is available to handle message. Change-Id: Ia3e319ee6b9d224a92def7652ed50f4ae7021b4a Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Added support for list, leaf-list and container in output under rpc node in yang definition. Added support for leaf-list in state data definition. Updated config subsystem as well as netconf mapping. Change-Id: I4bdfbed352e29d6d3dc569f38c07022383d565c8 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Initial code drop of netconf protocol implementation This implementation is based on infrastructure provided by the framework artifact and contains server as well as client side code. Netconf subsystem structure: Netconf-api: Api definition for client and server. Netconf-impl: Netconf server implementation. Server handles basic communication and delegates handling of rpcs to an implementation of netconf-mapping-api. Netconf-mapping-api: Api definition for pluggable rpcs handler. Implementations of this api are plugged dynamically into netconf-impl using OSGi apis. Config-netconf-connector: Implementation of netconf-mapping-api that handles netconf rpcs and delegates requests to configuration subsystem Netconf-util: Utility classes used by client and server code. Netconf-client: Netconf client implementation. Netconf-it: Integration tests for netconf. These tests verify correct cooperation of netconf server, config-netconf-connector, config subsystem and netconf client. Config-persister-api: Api definition for config persister. Config persister is a component that is responsible for storing configuration snapshots after every change to the configuration via netconf rpcs. (Pushed to config-subsystem) Config-persister-impl: Implementation of config persister that receives notifications from netconf-impl about changes to the configuration and uses pluggable adapters to store received snapshots. Config-persister-file-adapter: Implementation of config persister adapter that stores and restores config snapshots from a file. (Pushed to config-subsystem) In order to run netconf in OSGi, some configuration issues had to be resolved in config-subsystem bundles. Change-Id: I8e0421c924b0714a4d49962c4bb5ca01ef68ac78 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>