Delete netconf Change-Id: I69f0c921df155606d296f448b11297c7382795c8 Signed-off-by: Tomas Cere <tcere@cisco.com>
Fix various netconf warnings Overridden version, potentially static methods. Change-Id: I54af7e8b48335b4b81594d4deeb0f75e21dbc932 Signed-off-by: Robert Varga <rovarga@cisco.com> (cherry picked from commit 2660b697228bb3e708a556b53e06a89d5ea00440)
BUG-2459: reuse EXI Reader The reader performs an internal reset on each invocation of parse(), so it can be freely reused as long as we guarantee there are no concurrent invocations. Our decoder class is not Shared, so netty guarantees this. Change-Id: Icd575988e48ca5252d6f6716f4e08f83b23c99ca Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-2459: reuse EXI Transmogrifier EXI Transmogrifier performs an internal reset whenever we acquire the SAXTransmogrifier. This means that we are free to reuse the instance between individual invocations as long as we can guarantee there are no concurrent access. That is guaranteed by our Handler not being Shared. Change-Id: Iba141915000b016579b273d4413ecd205f8da777 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-2459: centralize codec allocation This moves EXI codec allocation into AbstractNetconfSession, so it is can be standardized for both client and server. Change-Id: I304bec5e19efaa6c3ff63ac66f2bd0d9c55c6b7a Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix checkstyle warnings in netconf-client Change-Id: I94d8c31a16f0755451a3bebad5a8792a97d426d2 Signed-off-by: Marian Dubai <mdubai@cisco.com>
Fix raw reference to SessionNegotiatior Add a wildcard and be done with it. Change-Id: Ifc72e1fe88e9d5ee9047c55ed93fc0fae7db331a Signed-off-by: Robert Varga <rovarga@cisco.com>
Merge "Fix raw references to Promise"
Fix raw references to Promise Adds the proper type, so we do not have the warnings. Change-Id: Ib02779460f60f54e31f64815fd5cc6f68460ba83 Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix non-generic references to Set Adds arguments as appropriate. Change-Id: Ib8faba91bd9fc8751014ea00f1859636e0fcda6d Signed-off-by: Robert Varga <rovarga@cisco.com>
Remove unused imports This fixes warnings stemming from unused imports. Change-Id: I7e91ca9fdde55f19d0463c9f662ca96f8270c87d Signed-off-by: Robert Varga <rovarga@cisco.com>
Add generic arguments to Answer Just use Object as the argument to get rid of the warnings. Change-Id: I17d2ee9c518ed53c27bd5e1c330e7c161a388194 Signed-off-by: Robert Varga <rovarga@cisco.com>
BUG-1521 netconf-client line coverage Change-Id: I44c7d6a627e21aabe9c46ea678a90d81268ef438 Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Bug 1239 - Clean up and refactor netconf-ssh client Remove commented and dead code in netconf-netty-util. Move SshHandler to client package in order to make it package private. Wrap OutputStream in SSHClientHandler with a buffer. Remove VirtualSocketException as it was a workaround for passing context without checking whether session was established. Change-Id: I992d3b8ba2b2a58b69bd2e8be4ad0e4bdfa36c01 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
BUG 624 - Make netconf TCP port optional. Previously netconf-impl opened a TCP port with no authentication on localhost, and netconf-ssh used it as a bridge to forward trafic after processing authentication and encryption. This patch creates new project netconf-tcp and modifies netconf-impl to open the netconf server on LocalAddress. Both tcp and ssh modules now communicate with this local server. Config ini is modified so that the TCP port (8383) is not enabled by default. Change-Id: I74bded660f10b20d09535d32308aff5b2ae611d9 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
BUG-693 Config module for netconf client dispatcher. netconf/ NetconfClientDispatcher and NetconfSSHClientDispatcher merged into NetconfClientDispatcherImpl. Introduced NetconfClientConfiguration to contain all configuration attributes for netconf clients. Introduced interface for NetconfClientDispatchers. Removed NetconfITSecureTest since it did not test secure connection. config/ Added netconf-config-api maven module, which contains service definition of client-dispatcher. Added netconf-config-dispatcher maven module, which contains config module for client-dispatcher. md-sal/ Updated configuration for sal-netconf-connector with client dispatcher dependency (backwards compatibility preserved). Change-Id: I05e784af6a9b8e11fad21d3bad0311c110754d31 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-459 Remove deprecated NetconfClient class. NetconfClient moved to test sources, now will be used only by tests. Change-Id: Ia98abe3f6fa4f05566b71d57c519c2149726bcb6 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Improve logging in NetconfClient, logging-bridge. Increase connection timeout in sal-netconf-connector. Stop polluting log file with unnecessary 'Exception' messages by logging-bridge, print stack trace with exceptions using slf4j. Increase connection timeout in sal-netconf-client from 5s to 20s. Include label in NetconfClient exceptions. Change-Id: If6819029fb79ea6ebead6b6745adf2c439d107da Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Add configurable connection timeout to netconf client. Make connection timeout configurable. Previous behavior was having hardcoded connection timeout set to 1 minute. Make NetconfConnectorModule more configurable, allow (and this is new default) to retry on connection failures forever. Change-Id: Ia9280cff1b751a4e7318e1e0331175c960823dad Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Move NetconfUtil to netconf-util. Implement simple acceptance netconf client test that can connect to a remote machine. Clean up helper functions from netconf-impl and persister-impl to netconf-util. Change-Id: I1dd221822c6e6fff69388f65c4df3bb39fa21d60 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>