Delete netconf Change-Id: I69f0c921df155606d296f448b11297c7382795c8 Signed-off-by: Tomas Cere <tcere@cisco.com>
Decouple config and netconf subsystems. Extract a common mapping for config pusher and config subsystem netconf Add a ConfigPersisterFacade for XML that allows reads/writes from/to config subsystem using XML format Push notifications from YangStoreService to NetconfNotificationManager instead of using custom listeners Migrate netconf features from controller features, untangle features Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca Signed-off-by: Tomas Cere <tcere@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com> Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Fix various netconf warnings Overridden version, potentially static methods. Change-Id: I54af7e8b48335b4b81594d4deeb0f75e21dbc932 Signed-off-by: Robert Varga <rovarga@cisco.com> (cherry picked from commit 2660b697228bb3e708a556b53e06a89d5ea00440)
Remove isCloseMsg check for each rpc Performance improvement The check re-read the message and checked if its close-session rpc. DelayedClose method was added to netconf server session that replaces the isCloseSession method with a simple bollean check. Change-Id: Ic4f6d473b948bd4f63771748dac793ba43693828 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2635 Netconf monitoring for md-sal netconf northbound Monitoring for mdsal's netconf stores all available monitoring data in the datastore and provides get-schema operation Change-Id: I573c5d57e5cf25d7688f3355b602327c7af75c65 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2635 Prepare netconf monitoring service for md-sal monitoring. So that the monitoring service provides all the information in one place. Also move get-schema rpc into netconf-monitoring from netconf-impl. Change-Id: Ia7dc47ea4997df417795f079a7c045709dbaaf47 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
BUG-2633 - Netconf northbound mapping. Supported operations for now are: get, get-config - candidate and running datastore, without filtering edit-config - only on candidate datastore discard-changes lock, unlock - supported only for compatibility reasons since we don't support locking of running datastore, and each session has it's own candidate datastore. commit Change-Id: Idb0bad09dc1d8925674576290fecb47ccd1e5dbd Signed-off-by: Tomas Cere <tcere@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Cleanup message logging in netconf handlers This wraps LOG.trace() invocations in LOG.isTraceEnabled(), as they construct potentially big objects which may end up being unused. Also cleans up method declarations to not use Exception, as Sonar warns about these. Change-Id: I8a1a01291b04eea0823b72e254f9ca4cc11557ea Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix checkstyle warnings in netconf-impl. Change-Id: I921b51e79475bdc7a0a03398bb6a709836bffdb2 Signed-off-by: Marian Dubai <mdubai@cisco.com>
Fix checkstyle warnings in opendaylight/netconf Change-Id: I4f3da06f1166a924a4a7623047251167df84a389 Signed-off-by: Robert Varga <rovarga@cisco.com>
Bug 977: Return RpcError result on neconf failure NetconfDocumentedException: - Added methods to convert to and from XML. NetconfMessageTransformUtil: - Added code to convert a NetconfDocumentedException to an RpcError. - Modified checkSuccessReply and checkValidReply to throw NetconfDocumentedException instead of IllegalStateException. NetconfDeviceCommunicator: - Modified processMessage to return an RpcError result for invalid message and netconf error reply. - Modified other places that previously returned an exception in the Future to intsead return an RpcError result. - Improved synchronization by removing synchronized from method sigs and locking only the code that needs it. SendErrorExceptionUtil: - Modified createDocument to call NetconfDocumentedException.toXMLDocument XmlNetconfConstants: - Moved to netconf-api so NetconfDocumentedException could access it. The rest of the changed files were to change the import for XmlNetconfConstants. Change-Id: Id0ef3ac91bbcb85c9a7a198ceac272fb07f4b9f9 Signed-off-by: tpantelis <tpanteli@brocade.com>
Bug 451 - Fix netconf exception handling Change-Id: I815b34da996cf2660650577edb2e8ca623ae96df Signed-off-by: Martin Bobak <mbobak@cisco.com>
BUG-472 Initial EXI encoder/decoder implementation in Netconf according to http://tools.ietf.org/html/draft-varga-netconf-exi-capability-02 Change-Id: I861c126a8df1b26f477aa354ed1f8dba59d651cd Signed-off-by: Martin Bobak <mbobak@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Resolve Bug:745 - remove windows line endings from config and netconf. Change-Id: Id60c44a5f3fd4979f4e13cb00e6537998718e94f Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Merge "Bug 714 - Fixed creating DOM Document's element with namespace"
Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean. Fixes race condition that was observed in ITs, where config pusher started pushing empty configuration and immediately registered itself as notification listener of a JMX bean that was not yet present. Fix waits both for netconf-impl and config-netconf-connector services so that both dependencies are activated before pushing of configuration can occur. Change-Id: Id328dc3bd7e41bad59bb84b03461d89f5faeeea4 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Bug 714 - Fixed creating DOM Document's element with namespace Change-Id: Ic7449e11a9b2057d350dc889fcb81872d9ce24f8 Signed-off-by: Milos Fabian <milfabia@cisco.com>
Resolve Bug:448 - Remove yang-store api and impl. Depends on yangtools commit https://git.opendaylight.org/gerrit/#/c/5579/ . Instead of having multiple bundle trackers for config and netconf, keep only one. Each bundle containing yang files should use sal code generator, which generates YangModuleInfo objects. Using this instead of speculatively having to parse all current yang files for each adding bundle event allows not having to deal with broken yang dependencies when bundle events come in wrong order. Put SchemaContextProvider to OSGi SR in config-manager, so that any bundle working with yang can use it. This replaces too specific YangStoreService which was coupled with yang-jmx-generator. Users can listen for changes directly on OSGi SR - they receive service changed event when yang module is added or removed. Change-Id: Iabcb35929a1eeef0df328f3f948d70e1bfcbba0d Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>