Delete netconf Change-Id: I69f0c921df155606d296f448b11297c7382795c8 Signed-off-by: Tomas Cere <tcere@cisco.com>
Decouple config and netconf subsystems. Extract a common mapping for config pusher and config subsystem netconf Add a ConfigPersisterFacade for XML that allows reads/writes from/to config subsystem using XML format Push notifications from YangStoreService to NetconfNotificationManager instead of using custom listeners Migrate netconf features from controller features, untangle features Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca Signed-off-by: Tomas Cere <tcere@cisco.com> Signed-off-by: Maros Marsalek <mmarsale@cisco.com> Signed-off-by: Ed Warnicke <hagbard@gmail.com>
Remove isCloseMsg check for each rpc Performance improvement The check re-read the message and checked if its close-session rpc. DelayedClose method was added to netconf server session that replaces the isCloseSession method with a simple bollean check. Change-Id: Ic4f6d473b948bd4f63771748dac793ba43693828 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Fix checkstyle warnings in netconf-impl. Change-Id: I921b51e79475bdc7a0a03398bb6a709836bffdb2 Signed-off-by: Marian Dubai <mdubai@cisco.com>
Bug 977: Return RpcError result on neconf failure NetconfDocumentedException: - Added methods to convert to and from XML. NetconfMessageTransformUtil: - Added code to convert a NetconfDocumentedException to an RpcError. - Modified checkSuccessReply and checkValidReply to throw NetconfDocumentedException instead of IllegalStateException. NetconfDeviceCommunicator: - Modified processMessage to return an RpcError result for invalid message and netconf error reply. - Modified other places that previously returned an exception in the Future to intsead return an RpcError result. - Improved synchronization by removing synchronized from method sigs and locking only the code that needs it. SendErrorExceptionUtil: - Modified createDocument to call NetconfDocumentedException.toXMLDocument XmlNetconfConstants: - Moved to netconf-api so NetconfDocumentedException could access it. The rest of the changed files were to change the import for XmlNetconfConstants. Change-Id: Id0ef3ac91bbcb85c9a7a198ceac272fb07f4b9f9 Signed-off-by: tpantelis <tpanteli@brocade.com>
Merge "Bug 714 - Fixed creating DOM Document's element with namespace"
Resolve Bug:707 - ConfigPusher should wait for netconf-impl to register JMX bean. Fixes race condition that was observed in ITs, where config pusher started pushing empty configuration and immediately registered itself as notification listener of a JMX bean that was not yet present. Fix waits both for netconf-impl and config-netconf-connector services so that both dependencies are activated before pushing of configuration can occur. Change-Id: Id328dc3bd7e41bad59bb84b03461d89f5faeeea4 Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Bug 714 - Fixed creating DOM Document's element with namespace Change-Id: Ic7449e11a9b2057d350dc889fcb81872d9ce24f8 Signed-off-by: Milos Fabian <milfabia@cisco.com>
Get rid of netconf operation filters Merge NetconfOperationFilter interface into NetconfOperation Execute all operations that can handle a certain request in chained execution (ordered by priority) Reimplement all current filters as chained operations Remove NetconfOperationRouter parameter from NetconfOperation NetconfOperations handling the same request must have different priorities Change-Id: Iab9c680e6eceab4059feb77616a9d006fb613711 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Remove unused DefaultNetconfOperation marker DefaultCloseSession and DefaultGetSchema do not need the netconf session. so drop their use of DefaultNetconfOperation. Change-Id: I724bd56d913b0f836c88ca8d1b436be308852a30 Signed-off-by: Robert Varga <rovarga@cisco.com>
Initial implementation of netconf monitoring module according to tools.ietf.org/html/rfc6022 Response from netconf GET operation now contains monitoring information about current netconf state. Modified netconf-impl module: added monitoring capabilities to netconf-impl module exposed as OSGi service. Added netconf-monitoring module that provides a filter for netconf GET operation and adds monitoring information retrieved from netconf-impl to the response of the GET operation. It implements netconf-mapping-api similar to config-netconf-connector and currently provides information about current netconf SESSIONS and yang SCHEMAS (these information is retrieved via the netconf monitoring OSGi service provided by netconf-impl). Added ietf-netconf-monitoring module that contains sources generated from ietf-netconf-monitoring yang. These sources serve as an interface between netconf-impl and netconf-monitoring. Change-Id: I62c457cde42e01781d9039c6dde0a03115134df4 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
- Added exi capability utilities, handlers and necessary modifications - Exi parameters decomposition - Introduced HandlerManipulator class in netconf-api to be used for handlers management on channel pipeline - Exi encoding/decoding test added - exi returns NetconfMessage - added DOM attributes - exi encode decode test to expect NetconfMessage instead of Document - XmlElement.getName() returns localName first and tagName if localName not present, incorporated notes from Robert - NetconfSession implements all common methods - added copyright where needed - ProtocolMessageEncoder/Decoder stored in session and replaced with Exi enc/dec - exi encoder/decoder interface become comaptible with ProtocoleMessageEncoder/Decoder and no longer needs to be taken care of this handlers - created thirdParty bundle for exi - incorporation of Maros's notes Author: Martin Bobak <mbobak@cisco.com> Signed-off-by: Martin Bobak <mbobak@cisco.com> Change-Id: If9f20cef34ec05495eb212f6a584dd65a401dc0a Signed-off-by: Martin Bobak <mbobak@cisco.com>
Initial code drop of netconf protocol implementation This implementation is based on infrastructure provided by the framework artifact and contains server as well as client side code. Netconf subsystem structure: Netconf-api: Api definition for client and server. Netconf-impl: Netconf server implementation. Server handles basic communication and delegates handling of rpcs to an implementation of netconf-mapping-api. Netconf-mapping-api: Api definition for pluggable rpcs handler. Implementations of this api are plugged dynamically into netconf-impl using OSGi apis. Config-netconf-connector: Implementation of netconf-mapping-api that handles netconf rpcs and delegates requests to configuration subsystem Netconf-util: Utility classes used by client and server code. Netconf-client: Netconf client implementation. Netconf-it: Integration tests for netconf. These tests verify correct cooperation of netconf server, config-netconf-connector, config subsystem and netconf client. Config-persister-api: Api definition for config persister. Config persister is a component that is responsible for storing configuration snapshots after every change to the configuration via netconf rpcs. (Pushed to config-subsystem) Config-persister-impl: Implementation of config persister that receives notifications from netconf-impl about changes to the configuration and uses pluggable adapters to store received snapshots. Config-persister-file-adapter: Implementation of config persister adapter that stores and restores config snapshots from a file. (Pushed to config-subsystem) In order to run netconf in OSGi, some configuration issues had to be resolved in config-subsystem bundles. Change-Id: I8e0421c924b0714a4d49962c4bb5ca01ef68ac78 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>