Move adsal into its own subdirectory. Moved various adsal components into an opendaylight/adsal subdir, gave it a parent pom, and changed the root parent pom to have the opendaylight/adsal as a module. Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Remove redundant expression true:false The expression that is evaluated already returns boolean, no need for additional 'true:false' decision, the correct value is already returned. Change-Id: I48378e88f30a4d9ebd8b9a56b287fb6d9536ec46 Signed-off-by: Alissa Bonas <abonas@redhat.com>
Declare a urlPrefix for reuse in NorthboundIT. All test cases use the same url prefix, but prior to this patch it was copy pasted in all test methods. For easier code maintenance, declared it once in the class and reused it in all test cases. Change-Id: I4c6430799c935293c7b9715b5b68e84e4baefd3a Signed-off-by: Alissa Bonas <abonas@redhat.com>
Upgrade jackson library to version 2.3.0 This change purpose is to use a newer version of the library, as well as align it with the jackson version used by ovsdb project repo. Main change areas: 1.Upgrade the jackson from codehaus.jackson version 1.9.x to fasterxml.jackson version 2.3.0. change all usages in pom files and fix the imports in Java classes. 2.Remove the usage of jersey-json library. Main resource for upgrade information: http://wiki.fasterxml.com/JacksonUpgradeFrom19To20 Change-Id: I2caa9f94a81af1e5ad0ead90c60c912396b8a390 Signed-off-by: Alissa Bonas <abonas@redhat.com>
creating a default subnet This changes how SwitchManager handles subnets so that when there are no configured subents, it returns a default subnet that spans all ports in the network and spans all IP addresses, i.e., 0.0.0.0/0. This makes it so that HostTracker will discover all hosts by default instead of only discovering hosts in configured subents. This, in turn, makes SimpleForwarding forward traffic correctly without any configuration. Change-Id: Ice31b6035b970dd69fc69df3d9560b4aac41630d Signed-off-by: Colin Dixon <ckd@us.ibm.com>
Stop using deprecated pax Configuration annotation. Move the code to use not deprecated annotation. Change-Id: Ibbf861d52ef3f352b5367e3e140b1b32e496c462 Signed-off-by: Alissa Bonas <abonas@redhat.com>
Northbound IT works unreliably - The root cause of the issue is in the fact the hosttracker northbound bundles takes long time to reply to a query, why is that is todo. To avoid this issue however i'm making the timeout for the HTTP request in the IT to be infinity. Change-Id: I8b857a24d6ebd03ff27f13c5061106c5202a8c2a Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Add HTTP Client library and refactor Northbound IntegrationTest Create a new commons.httpclient library for bundles that need to function as an HTTP client. Refactor the existing NB IntegrationTest code to use this new library. Ammended - library is now a profile of apache httpclient classes to ensure things like timeouts are set on default and resources are correctly released when finished. Change-Id: I76f513b77700213752f4183e917fe239a9c324ff Signed-off-by: Ryan Moats <rmoats@us.ibm.com>
Aligning JSON marshalled output for Properties similar to the XML counterpart. After the Jackson migration (https://git.opendaylight.org/gerrit/#/c/1131), the marshalled JSON output got misaligned from its XML counterpart. This is because of the "special" handling of XmlElementRef by Jettison. Please refer to http://pastebin.com/6kCSuddg for various marshalled JSON output for Jettison, Jackson and Moxy. Having tried & exhausted various mechanisms (using Jackson and Moxy), finally decided to use the Jackson annotations to take care of this requirement. Changes involves : 1. Modified NodeConnectProperties, EdgProperties and NodeProperties to use @JsonIgnore and @JsonProperty 2. Reverted a few NorthboundIT changes as prior to the gerrit#1131 version to align to the JSON format. 3. Added @XmlAccessorType(XmlAccessType.NONE) in all the Property classes to avoid including unnecessary data. Change-Id: I574956328fa841b2165e0c10ddec995c70b76e4d Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
Configure jackson to turn off FAIL_ON_UNKNOWN_PROPERTIES. This ensures that Jackson is more lenient when it sees extra attributes in the request payload. Add custom exception mapper for handling jackson json exceptions during deserialization Change-Id: Id2da67b4edfc92f1d11e41fd349814c2de05079c Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
Address @XmlSeeAlso limitation. Provide the ability to inject the JAXB types without having the need to explicitly define the inherited types with @XmlSeelAlso. Introduced BundleScanner service which scans bundle classes for annotations dynamically and provides proper artifacts for NB applications to bootstrap. Eliminate the need for NB application extensions. Change-Id: I08b6a30a551f63a304732e8fdda9a594d1a6ca93 Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
Refactor SubnetConfig - Change Subent Config to represent the switch ports with the NodeConnector notation - Added validity check on zero subnet configuration - Change device js to correctly set the value in the ports selects, JQuery changes from Andrew (andrekim@cisco.com) - While uniform Subnet northbound to other NB modules, removed the node-ports endpoints. Have the subnet as end resource, we already have the POST for it. - Added ISwitchManager.modifySubnet(SubnetConfig s) - Added SubnetConfigTest.java for junit - Updated subnet northbound junit Change-Id: I7777d0dc3b60f6532836a5115d8fc2dd48c18768 Signed-off-by: Alessandro Boch <aboch@cisco.com>
Container Management and associated Northbound APIs. Features : 1. Create, Modify and delete containers 2. ContainerFlow management 3. Northbound APIs 4. Application authorization support (contributed by Alessandro Boch) Change-Id: I080d58c2869720c7e78fcdff673b51b142b1c2c2 Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
Bug #65 - Fix inconsistencies in the NB REST APIs 1) PUT is used to create resources (when resource path is known to client and the action is idempotent). 2) Use plural resource name when listing contents. 3) Rename service names (flow -> flowprogrammer, host -> hosttracker, subnet -> subnetservice) as they conflict with resource names. Change-Id: I7171ec725b83799ec3686460ab7aa23c7df56c9b Signed-off-by: Prasanth Pallamreddy <ppallamr@cisco.com>
Bug #60 : JSON list responses from the NB-APIs returns native object (instead of List) when the API returns a single element. We use Jersey and JAXB frameworks for the NB-API implementation. Jersey by default uses Jettison for the JSON marshalling/demarshalling. It seems like there is a bug in Jettison for this case. And the recommended approach is to use Jackson instead. Among various approaches to replace Jettison with Jackson (including package scanning, etc..), the only easy approach in an OSGi environment is to directly refer to the JerseyJaxbJsonProvider class from the Northbound application. JerseyJaxbJsonProvider has dependancies on jersey-xc which is also pulled in. The Northbound Integration Test has inbuilt assumption that the NB-APIs use Jettison & hence a whole bunch of such bugs were hidden and not visible to the tests as well. The correct approach is to use JAXB bindings in the IT so that immaterial of Jettison or Jackson as the NB Marshalling infra, the IT need not change. But, that is a bigger change and hence to restrict to the changes being addressed, this changeset just fixed these incorrect assumptions and continued to use the Jettison library for demarshalling (while the actual Northbound API uses Jackson). Also note that, such infra changes call for bumping both the NB-API version and the bundle version. But, given the fact that the API freeze is scheduled later in October and more NB related changes are coming, the version bump process can be scheduled later to ease the development work. Change-Id: I47d8309dfbe11c251a30316bca37c7823cb0325a Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>