Move adsal into its own subdirectory. Moved various adsal components into an opendaylight/adsal subdir, gave it a parent pom, and changed the root parent pom to have the opendaylight/adsal as a module. Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Clean all unused and redundant imports in controller. Enable verification of unused and redundant imports via checkstyle. Rename checkstyle configuration file because it no longer checks only for tabs. Change-Id: Id94a92fbc8a79aba01a4177aec3d80a2b3394508 Signed-off-by: Alissa Bonas <abonas@redhat.com>
Move init and destroy empty impl from Activator classes. Have only one empty implementation in parent class instead of having it in more than 20 classes. Only one class actually has a non empty implementation and it overrides the empty implementation from the parent. Change-Id: Ibbe43ba3e48e4eb80402c158cd45be0afc497fae Signed-off-by: Alissa Bonas <abonas@redhat.com>
Fixed typo and remove unecessary java.lang import Fixed typo in comment and remove unecessary java.lang import (as proposed by Sonar report) Change-Id: I4362cd4e25965c9a5c9322a5a25e189241599c18 Signed-off-by: Alissa Bonas <abonas@redhat.com>
Migrating caches to TRANSACTIONAL Caches and enabled use1PcForAutoCommitTransactions. In addition, - Removed all the unused Caches (especially the save event cache). - Changed ARP Handler's ICacheUpdateAware processing to not process the cache event in its own thread (instead of the infinispan's thread). Change-Id: I608aecd425d0394ba9c4e665424c82790bb874ca Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
Implement cluster wide topology notifications and let routing use it - Made TopologyManager to generate ClusterWide updates along with the local ones. - Implemented a mechanism in topology manager to batch the topology updates being synched via clustering services. This would save on unnecessary churn in recalculations under massive topology updates. - Modified routing Dijkstra to be an ITopologyManagerClusterWideAware client rather than on of ITopologyManagerAware. - Modified Dijkstra implementation to generate routing updates notifications only on the coordinator, in fact given Dijkstra will have the same view on all the controllers node in the cluster, then it's pointless to have all the clients of IRoutingAware to recalculate, they would lead to the same result. - Dijkstra edgeUpdate logic was considering the CHANGED topology event as DELETE, that is wrong and this patch fix it. - Added gogo shell CLI to get a route from the DijkstraImplementation.java - Enhanced "TopoEdgeUpdate" class to has the isLocal flag to distinguish between the local updates and the remotes one. Also remove non-key field from equal and hashCode calculation. - Remove unnecessary CONFIGSAVEEVENT in TopologyManagerImpl because now the configuration service provides a cluster wide trigger. Change-Id: Ia74d9d1ec0731e1f5815a69edc25bbb5b4c1f531 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Checkstyle enforcer Started to enforce checkstyle, if the code style doesn't match the checkstyle settings build will break. This is needed in order to make sure folks comply to one code style and don't start diverging. For now the enforcement is only limited to: - make sure no TABS are present in the java files - make sure that no trailing whitespaces are present Along with code style enforcement updates all the files that didn't comply else compilation would not be successful. Added new exclusion in .gitignore Added new parent for commons.opendaylight, please read the README in the commons.parent project for the reason for it. Make sure the violation of checkstyle are reported on the console to avoid for a developer to be able to dig through the log in the target directory Change-Id: I4e35aa74e685e5cebb8182caf0b3b39da0906948 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Revert "Checkstyle enforcer" This reverts commit 541d0a36997f292bb037a2199463431eee538358 We are going to talk a bit more about this before doing it. Change-Id: I788ecea18796c6eb325285dfaa83a6aae300634c
Checkstyle enforcer Started to enforce checkstyle, if the code style doesn't match the checkstyle settings build will break. This is needed in order to make sure folks comply to one code style and don't start diverging. For now the enforcement is only limited to: - make sure no TABS are present in the java files - make sure that no trailing whitespaces are present Along with code style enforcement updates all the files that didn't comply else compilation would not be successful. Added new exclusion in .gitignore Change-Id: Ic95da373575cec3cfe0c99b31fce92f66bc41263 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Redirecting Caught and Uncaught Exceptions to OSGI Console and Log File The existing mechanism int the Controller allows the exceptions to be printed only the console. This applies to both caught and uncaught exception. If the console buffer is not too large and gets overwritten or gets cleared, there is no way for the user to know what exceptions occurred. This commit implements a new mechanism by which both types of exceptions will get printed on the console as well as logged to the file. Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
Gerritt #107 introduced a fix that caused Routing Listener registration issue. Fixing it here. Also removed the unused DS xmls. Change-Id: I2b6105d909bea0691b5568a0791d4920f73cc17e Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
Removing references to a prior branded controller Change-Id: Ie5518714964fd1713ae64274228bf7269e32d728 Signed-off-by: Colin Dixon <ckd@us.ibm.com>
ISSUE Opendaylight controller to get node description from OF description statistics datapath description field CHANGE - Switch Mgr to expose a getNodeDescription() method which returns the description configured by user if any, otherwise the one learnt from the proto plugin - Web bunldes to make use of the above api (Currently they are ignoring the info learnt by the plugin) - OFStatisticsManager to implement a IStatistics interface for informing listeners that the description statistics info has been refreshed - Removing current logic where OFStatisticsManager was explicitely invoking the description property update on InventoryService through IOFInventoryService - Removed logic where InventoryServiceShim queries OFStatisticsManager about node description as information is not available at that time and IStatisticsListener updates will serve same purpose - Removing statistics request timeouts from OFStatisticsManager as the timeout is compeltely handled by core.internal.StatisticsCollector Change-Id: I0d2941d3012ca6dc77a386570dbbd8e5c7832a03 Signed-off-by: Alessandro Boch <aboch@cisco.com>
This commit fixes the followings - Change routing.dijkstra_implementation to implement ITopologyManagerAware instead of IListenTopoUpdates - Correct the bundle bringup sequence using the init(), start() called by dependency manager - Add routing.dijkstra_implementation restartability through OSGI stop/start Change-Id: Ia624ab4ea51f4d35c5ffe31d14b1aed58ca123c3 Signed-off-by: Chi-Vien Ly <chivly@cisco.com>
OpenDaylight Controller functional modules. Change-Id: I1cd6668738099e8db3cfe83f812a92c922ced38c Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>