Move adsal into its own subdirectory. Moved various adsal components into an opendaylight/adsal subdir, gave it a parent pom, and changed the root parent pom to have the opendaylight/adsal as a module. Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Fix raw ProtocolService references Adds a wildcard type to suppress an eclipse warning. Change-Id: I7750d9202802e0785a0c71eafc4c062b5ed5c68e Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix non-generic references to java.util.Map Adds proper arguments. Also eliminates unneeded casts to Map.Entry, caused by unnecessary loss of type. Change-Id: I3d3bc71b88a404b02029d836a3d02d37e304c39e Signed-off-by: Robert Varga <rovarga@cisco.com>
Merge "Add support for metadata to the Match/Action classes"
Add support for metadata to the Match/Action classes - Allow to attach some property to Match and Action so they can be used for passing extra informations, that applications can use. Change-Id: I4225271d7cd3429b11adb191ae178f541bbd635d Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Incrementing versions by 0.1.0 for post-Helium master branch * The only version not incrmented is aaa.version, which is left at 0.1.0-SNAPSHOT since they depend on controller and can't update yet. * To break the cyclic dependency, this patch temporarily stops running the netconf-connector and restconf feature tests. * Also fixing a bug causing Errors like "Choice has two nodes case with same qnames". A second patch (to be run after AAA increments their versions to 0.2.0-SNAPSHOT) wiil update aaa.version and re-enable these tests. Change-Id: I70a3987d32504e798c5ed05a67a0a1174338844b Signed-off-by: Colin Dixon <colin@colindixon.com> Signed-off-by: Robert Varga <rovarga@cisco.com>
Bug 1808: Don't deserialize IPv4 payload in non-first fragments. Protocol header, such as TCP header, is present only in the first fragment. So the payload of IPv4 packet should be treated as raw bytes if the fragmentation offset is not zero. Change-Id: I508a8cfc3c074d5b18f638d80e68ee730e9b7034 Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Bug 1805: Fixed 2 bugs in ICMP.computeChecksum(). * Fixed a bug that caused ArrayIndexOutOfBoundsException if the size of the payload was odd. * Fixed a bug that generated incorrect checksum if the 16-bit checksum overflowed more than 255 times. Change-Id: I8f26cc41dec2d5ba64c3ab31e66a846dfbea7bc5 Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Enable AD-SAL application to configure OF 1.3 PUSH_VLAN action. OF 1.3 PUSH_VLAN action takes only one argument, ethernet type, and its value must be 0x8100 or 0x88a8. Change-Id: I4d6bcabb430245594b747e31f9edb2034f39acb6 Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Bug 1234: Force to use legacy OF plugin if it is installed. This patch enables to prioritize AD-SAL protocol plugin services, and gives higher priority to legacy OF plugin than sal-compatibility. This patch never affects integration.git artifacts because legacy OF plugin is filtered out if MD-SAL OF plugin is installed. Change-Id: Iee40a6f724db2105f2ec36014a10872bad824e86 Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Bug 1536: Fixed minimum values of SET_TP_SRC/DST. This patch changed the minimum values of SET_TP_SRC and SET_TP_DST actions from 1 to 0. Change-Id: I8f328f393fd1e06152283afea30ad4ffffd90705 Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
IEEE802.1q Packet returns incorrect header size IEEE8021Q class uses the Packet.getHeaderSize() which iterates through header fields to determine the size. .1Q header is fixed in size and should return the correct value Change-Id: I4b0123dd943f6e833f14782f2ed7cc0e6e184e87 Signed-off-by: Yevgeny Khodorkovsky <ykhodork@cisco.com>
AD-SAL: Filter packet-in based on container flow - In AD-SAL openflow plugin incoming packets are delivered to listeners in respective container only based on incoming port. - This patch enforces the container flow filtering logic as well Change-Id: I6a23b114712e63b8ffb18c173bbbaad5fb7634bd Signed-off-by: Alessandro Boch <aboch@cisco.com>
Incorrect connect API is called in ConnectionMgr when NodeType is provided Change-Id: I73d7539cfbd97cfd2f3da570c8e29ff0787d8f18 Signed-off-by: Pramila Singh <pramisin@cisco.com>
Bug 1165: ContainerFlow boundary is not always enforced for vlans - When a flow add is requested, ForwardingRulesmanager checks whether the requested flow complies with the ContainerFlow(s) for the current container. The check is performed by ContainerFlow.allowsFlow(Flow x). This function checks if the Match portion of the passed Flow does conflict with the container flow (which is a Match itself). It then checks whether the Flow's Actions are allowed by the container flow (this to avoid cross container redirection of traffic). In order to do so, it constructs a Match which summarizes the actions, then it checks if it conflicts with the container flow Match. BUG: During this last step, it misses to account the SetVlan actions. Because of the above bug an app/user can install a flow which leaks traffic from one container to another, when the containers' flows specify vlan as boundary. Change-Id: Id5a5e60c190b4353ed1fd76966e885a021ee4d2a Signed-off-by: Alessandro Boch <aboch@cisco.com>
Add getChecksum() to the AD-SAL TCP class Fixing Bug 1145 Change-Id: I62b29ecd0bb640632146b93c97250ba00afbe2fa Signed-off-by: Colin Dixon <colin@colindixon.com>
Change in sal.connectionservice.notifyNodeDisconnectFromMaster - On node disconnect from Master, notify the respective protocol plugin, not all of them Change-Id: I2bfb30d2f649a1bc3f07be60150a814bcd1b8a45 Signed-off-by: Alessandro Boch <aboch@cisco.com>