Move adsal into its own subdirectory. Moved various adsal components into an opendaylight/adsal subdir, gave it a parent pom, and changed the root parent pom to have the opendaylight/adsal as a module. Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Add checkstyle rule to prevent empty statements (;) Change-Id: Id8b34fde64988326cf6cab494019f99d2d61cbc5 Signed-off-by: Alissa Bonas <abonas@redhat.com>
Aligning JSON marshalled output for Properties similar to the XML counterpart. After the Jackson migration (https://git.opendaylight.org/gerrit/#/c/1131), the marshalled JSON output got misaligned from its XML counterpart. This is because of the "special" handling of XmlElementRef by Jettison. Please refer to http://pastebin.com/6kCSuddg for various marshalled JSON output for Jettison, Jackson and Moxy. Having tried & exhausted various mechanisms (using Jackson and Moxy), finally decided to use the Jackson annotations to take care of this requirement. Changes involves : 1. Modified NodeConnectProperties, EdgProperties and NodeProperties to use @JsonIgnore and @JsonProperty 2. Reverted a few NorthboundIT changes as prior to the gerrit#1131 version to align to the JSON format. 3. Added @XmlAccessorType(XmlAccessType.NONE) in all the Property classes to avoid including unnecessary data. Change-Id: I574956328fa841b2165e0c10ddec995c70b76e4d Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
Enhancement to switchmanager CLI commands to display all the properties of node and nodeconnector Change-Id: I87ee445168e64cc74a7538593503cb43f4e1f50a Signed-off-by: Pramila Singh <pramisin@cisco.com>
Fix to remove camel case for Northbound API Change-Id: I2d13e9d53b0d73504c15d32a57207110d70afb3a Signed-off-by: Pramila Singh <pramisin@cisco.com>
Checkstyle enforcer Started to enforce checkstyle, if the code style doesn't match the checkstyle settings build will break. This is needed in order to make sure folks comply to one code style and don't start diverging. For now the enforcement is only limited to: - make sure no TABS are present in the java files - make sure that no trailing whitespaces are present Along with code style enforcement updates all the files that didn't comply else compilation would not be successful. Added new exclusion in .gitignore Added new parent for commons.opendaylight, please read the README in the commons.parent project for the reason for it. Make sure the violation of checkstyle are reported on the console to avoid for a developer to be able to dig through the log in the target directory Change-Id: I4e35aa74e685e5cebb8182caf0b3b39da0906948 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Revert "Checkstyle enforcer" This reverts commit 541d0a36997f292bb037a2199463431eee538358 We are going to talk a bit more about this before doing it. Change-Id: I788ecea18796c6eb325285dfaa83a6aae300634c
Checkstyle enforcer Started to enforce checkstyle, if the code style doesn't match the checkstyle settings build will break. This is needed in order to make sure folks comply to one code style and don't start diverging. For now the enforcement is only limited to: - make sure no TABS are present in the java files - make sure that no trailing whitespaces are present Along with code style enforcement updates all the files that didn't comply else compilation would not be successful. Added new exclusion in .gitignore Change-Id: Ic95da373575cec3cfe0c99b31fce92f66bc41263 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Seven more Equals/HashCode/StringBuilder replacements I'm intentionally breaking these up into small groups so they can be reasonably reviewed, rather than one giant group that can't. Contributes to fixing bug 20. Fifth set. Change-Id: I905753ad4b1c2f6947fae8c447de27e091aa7519 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Initial opendaylight infrastructure commit!! Change-Id: I2f6610f89c8c32dc6dab4e6982ce06a9b038a85a Signed-off-by: Giovanni Meo <gmeo@cisco.com>