Move adsal into its own subdirectory. Moved various adsal components into an opendaylight/adsal subdir, gave it a parent pom, and changed the root parent pom to have the opendaylight/adsal as a module. Change-Id: I1d0e5a7b2a50c65559c2f80dd47cab491b68d561 Signed-off-by: Ed Warnicke <eaw@cisco.com>
Bug 1805: Fixed 2 bugs in ICMP.computeChecksum(). * Fixed a bug that caused ArrayIndexOutOfBoundsException if the size of the payload was odd. * Fixed a bug that generated incorrect checksum if the 16-bit checksum overflowed more than 255 times. Change-Id: I8f26cc41dec2d5ba64c3ab31e66a846dfbea7bc5 Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
Added field getters to class ICMP Change-Id: I436082be38ae00a1825b2cf83a607786f69cfb72 Signed-off-by: Noam Mor <noam.mor@contextream.com>
Fix NPE in ICMP.computeChecksum() ISSUE: ICMP.computeChecksum() incorrectly assumes rawPayload is always present while determining the lenght of the ICMP packet byte stream on which computing the checksum. Change-Id: I41c1e0509f21a2bbb0a5ec6df038ed18a81f327a Signed-off-by: Alessandro Boch <aboch@cisco.com>
Performance improvements: Solution: Use LinkedBlockingQueue with fixed capacity. The MAXQUEUESIZE is now set to 50,000. With the change, the system become stable. Solution: Implemented more efficient way to compute header checksum. As a result, the throughout has more than doubled.See test results below. Used Cbench for testing. Before: RESULT: 16 switches 9 tests min/max/avg/stdev = 9598.35/10395.48/10193.23/225.24 responses/s After: RESULT: 16 switches 9 tests min/max/avg/stdev = 28767.44/32073.92/30335.74/999.70 responses/s Solution: Transmit messages in a tight while loop until the Tx queue is empty. Signed-off-by: Jason Ye <yisye@cisco.com>
Checkstyle enforcer Started to enforce checkstyle, if the code style doesn't match the checkstyle settings build will break. This is needed in order to make sure folks comply to one code style and don't start diverging. For now the enforcement is only limited to: - make sure no TABS are present in the java files - make sure that no trailing whitespaces are present Along with code style enforcement updates all the files that didn't comply else compilation would not be successful. Added new exclusion in .gitignore Added new parent for commons.opendaylight, please read the README in the commons.parent project for the reason for it. Make sure the violation of checkstyle are reported on the console to avoid for a developer to be able to dig through the log in the target directory Change-Id: I4e35aa74e685e5cebb8182caf0b3b39da0906948 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
Revert "Checkstyle enforcer" This reverts commit 541d0a36997f292bb037a2199463431eee538358 We are going to talk a bit more about this before doing it. Change-Id: I788ecea18796c6eb325285dfaa83a6aae300634c
Checkstyle enforcer Started to enforce checkstyle, if the code style doesn't match the checkstyle settings build will break. This is needed in order to make sure folks comply to one code style and don't start diverging. For now the enforcement is only limited to: - make sure no TABS are present in the java files - make sure that no trailing whitespaces are present Along with code style enforcement updates all the files that didn't comply else compilation would not be successful. Added new exclusion in .gitignore Change-Id: Ic95da373575cec3cfe0c99b31fce92f66bc41263 Signed-off-by: Giovanni Meo <gmeo@cisco.com>
ICMP fix and Packet class should store and provide access to the raw payload in case no packet class is available to parse it. - Packet to store a copy of the raw payload if no packet class is present to parse it - Added missing code for ICMP - Refactored PAcket, ICMP and IPv4 code - Fixed corrupted flag setting when comparing checksum after deserializing - Added Junit for IPv4.computeChecksum() and for serilaize/deserialize ICMP message - Addressed some eclipse and static analysis warnings Change-Id:If2ae95cbc3462ffcda8662e27efd9de5614872ef Signed-off-by: Alessandro Boch <aboch@cisco.com>
Initial opendaylight infrastructure commit!! Change-Id: I2f6610f89c8c32dc6dab4e6982ce06a9b038a85a Signed-off-by: Giovanni Meo <gmeo@cisco.com>